Page MenuHomeWildfire Games

[Gameplay] Add Onager for romans
ClosedPublic

Authored by real_tabasco_sauce on Aug 27 2023, 4:20 AM.

Details

Summary

The onager is a area-of-effect siege unit that is trained from the siege workshop or constructed in the field by legionaries.
Since legionaries are added in another patch, their ability to build onagers isn't added here.

Onager:
Splash range of 4, 80 crush.
Direct attack of 40 crush

The onager has much less health than a catapult, and also costs less. It may still be used versus buildings but it is most effective against soldiers.

Test Plan

Do we agree on the values?

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8321/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7232/display/redirect

real_tabasco_sauce requested review of this revision.Aug 27 2023, 7:27 AM
borg- added a subscriber: borg-.Aug 27 2023, 3:57 PM

Is it possible for an artist to model an unpacked according to the catapult?

For the splash attack, it could be given in Hack damage, since that is inherently more effective against units than structures.

I think for realism keeping crush is better. I did some tests and it looks like good numbers, I'll do some more to get a better idea

Stan added a subscriber: Stan.Aug 28 2023, 5:49 PM
The onager (British /ˈɒnədʒə/, /ˈɒnəɡə/, U.S. /ˈɑnədʒər/)[1] was a Roman torsion powered siege engine. It is commonly depicted as a catapult with a bowl, bucket, or sling at the end of its throwing arm. The onager was first mentioned in 353 AD by Ammianus Marcellinus, who described onagers as the same as a scorpion.
borg- added a comment.Aug 28 2023, 5:59 PM

Don't we have a mention of onagers before that? I mean, I remember reading that onagers exist AD. If not, then catapults are outside the scope of the roman republic.

In D5114#217292, @Stan wrote:
The onager (British /ˈɒnədʒə/, /ˈɒnəɡə/, U.S. /ˈɑnədʒər/)[1] was a Roman torsion powered siege engine. It is commonly depicted as a catapult with a bowl, bucket, or sling at the end of its throwing arm. The onager was first mentioned in 353 AD by Ammianus Marcellinus, who described onagers as the same as a scorpion.

Later in the same wiki article it says:
"It may have originated in the third century BC." I think there is enough justification. This is also partially why I initially wanted to lock it behind the reforms upgrade, since this indicates an evolution of the army.

For me it's a yes for this patch, I'll just wait for a new unpacked model.
Could someone work on this @Stan ?

borg- added a comment.Aug 30 2023, 1:34 AM

You have to add onagers to the Legionary Engineers bonus. Actually this bonus is strange, I preferred all sieges 10%, 15% or 20%.

In D5114#217345, @borg- wrote:

You have to add onagers to the Legionary Engineers bonus. Actually this bonus is strange, I preferred all sieges 10%, 15% or 20%.

True.
It is also strange now that legionaries are a real unit. I'll think of a way to handle it. It might be cool to switch this to fire rate instead of damage, since it would result in a visual change.

real_tabasco_sauce added a subscriber: nifa.

Made the siege civbonus description more clear so that onagers are included here.
Unified all values for this bonus to 10% more damage. Reason: 20% is a lot for a civ bonus. By comparison, mace requires training their siege hero to get the same damage buff for rams.
Updated the packed Onager to use the filename of the actor being worked on by @nifa
Made a new onager template file and added damage multiplier of 1.1 for the rome onager.
Locked training packed onagers from arsenal behind marian reforms tech (found in another patch). Reason: Onager use increased later in ancient Rome. Also since the tech unlocks legionaries which can build this siege unit it makes sense for the tech to let them be trained from the arsenal too.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7239/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8328/display/redirect

In D5114#217292, @Stan wrote:
The onager (British /ˈɒnədʒə/, /ˈɒnəɡə/, U.S. /ˈɑnədʒər/)[1] was a Roman torsion powered siege engine. It is commonly depicted as a catapult with a bowl, bucket, or sling at the end of its throwing arm. The onager was first mentioned in 353 AD by Ammianus Marcellinus, who described onagers as the same as a scorpion.

Later in the same wiki article it says:
"It may have originated in the third century BC." I think there is enough justification. This is also partially why I initially wanted to lock it behind the reforms upgrade, since this indicates an evolution of the army.

One could ask the historians on the forums.

borg- added a comment.Aug 31 2023, 2:12 PM

Instead of changing the templates isn't it better to create technology for the siege bonus?

borg- added a comment.Aug 31 2023, 3:04 PM

I also don't see why not add the bonuses to boolt shooter.

In D5114#217378, @borg- wrote:

Instead of changing the templates isn't it better to create technology for the siege bonus?

I thought it better to use a tech as well. but the bonus had previously incorporated the bonus directly into the templates, so I stuck with that approach. I could make it a tech if you think it would be better like that.

In D5114#217379, @borg- wrote:

I also don't see why not add the bonuses to boolt shooter.

Well, I thought the term 'legionary engineers' would apply more to the heavy weaponry than the bolt shooters which are much smaller by comparison. Also, ptol already has a bolt shooter civ bonus.

borg- added a comment.Aug 31 2023, 7:43 PM

I thought it better to use a tech as well. but the bonus had previously incorporated the bonus directly into the templates, so I stuck with that approach. I could make it a tech if you think it would be better like that.

Yes, pls.

Well, I thought the term 'legionary engineers' would apply more to the heavy weaponry than the bolt shooters which are much smaller by comparison. Also, ptol already has a bolt shooter civ bonus.

Maybe just for stone throwers then? +10% attack and movement speed?

real_tabasco_sauce added a comment.EditedAug 31 2023, 8:03 PM
In D5114#217382, @borg- wrote:

I thought it better to use a tech as well. but the bonus had previously incorporated the bonus directly into the templates, so I stuck with that approach. I could make it a tech if you think it would be better like that.

Yes, pls.

Well, I thought the term 'legionary engineers' would apply more to the heavy weaponry than the bolt shooters which are much smaller by comparison. Also, ptol already has a bolt shooter civ bonus.

Maybe just for stone throwers then? +10% attack and movement speed?

What about fire rate, and pack/unpack time? That could be quite nice actually. Probably 10% faster fire rate and 30% faster pack/unpack

borg- added a comment.Aug 31 2023, 8:12 PM

I find the best attack rate and movement speed for packed stone throwers/onager. I think it makes more sense historically. For pack/unpack there is already a good technology for this

Make legionary engineers a civ bonus with autoresearch.
Use new actor from @nifa

Vulcan added a comment.Sep 1 2023, 4:06 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7241/display/redirect

Vulcan added a comment.Sep 1 2023, 4:08 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8330/display/redirect

binaries/data/mods/public/simulation/templates/units/rome/siege_onager.xml
6

Watch your tabs and spaces :)

real_tabasco_sauce marked an inline comment as done.Sep 5 2023, 4:49 PM
Vulcan added a comment.Sep 5 2023, 4:49 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7248/display/redirect

Vulcan added a comment.Sep 5 2023, 4:52 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8337/display/redirect

Freagarach added inline comments.Sep 7 2023, 8:16 AM
binaries/data/mods/public/simulation/data/technologies/civbonuses/rome_siege.json
7

Is this any needed?

Fix tooltip and let rome/siege_onager_packed.xml inherit the correct parent.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7267/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8356/display/redirect

remove duplicate preferences class list defined in units/rome/siege_onager_packed.xml

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7275/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8364/display/redirect

update with packed actor by @nifa, fix packed onager not moving.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7279/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8368/display/redirect

simplify requirements line for rome civ bonus

real_tabasco_sauce marked an inline comment as done.Sep 12 2023, 4:34 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7281/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8370/display/redirect

Build is unstable, some tests have failed - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/8952/display/redirect

fix error in requirements for roman_siege.json
fix tooltip warnings.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7313/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8402/display/redirect

Looks cool. I like the differentiation you're attempting. Perhaps in the future we can make it look like it's hurling multiple red-hot stones at once or something to make it clear it has a splash damage (thinking AOE2's onagers here), but that can come later. Accepted.

This revision is now accepted and ready to land.Sep 27 2023, 9:00 AM
real_tabasco_sauce added a comment.EditedSep 27 2023, 5:17 PM

Looks cool. I like the differentiation you're attempting. Perhaps in the future we can make it look like it's hurling multiple red-hot stones at once or something to make it clear it has a splash damage (thinking AOE2's onagers here), but that can come later. Accepted.

Yeah, I thought a little about how to do that myself, but couldn't come up with anything. I think it would need to be a new projectile type.

Also, since this patch requires the marian reforms patch, be sure not to commit it until the other patch is ready for commit.

Looks cool. I like the differentiation you're attempting. Perhaps in the future we can make it look like it's hurling multiple red-hot stones at once or something to make it clear it has a splash damage (thinking AOE2's onagers here), but that can come later. Accepted.

Yeah, I thought a little about how to do that myself, but couldn't come up with anything. I think it would need to be a new projectile type.

Right, a <Volley> element in the Attack component or something @Freagarach . Possible? A ranged attack type that shoots a group of projectiles per repeat time. I imagine would be very helpful for multiple units and buildings.

Also, since this patch requires the marian reforms patch, be sure not to commit it until the other patch is ready for commit.

Will do. I have accepted both patches now. Waiting for one or more others to Accept first in case I've missed a glaring bug.

give onager correct loot.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7393/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8482/display/redirect

borg- accepted this revision.EditedOct 20 2023, 2:19 PM

The patch idea is on the right way. Everything is working correctly. Several adjustments were made over the days to make it easier for new players to understand. The patch is mature now. Although the icon for the long-range legionary unit is missing, we may add this in the future (before the a27 comes out), so this patch is ok with me. Thank you for your efforts on this patch @real_tabasco_sauce

This revision was landed with ongoing or failed builds.Oct 27 2023, 7:01 PM
This revision was automatically updated to reflect the committed changes.
Owners added subscribers: Restricted Owners Package, Restricted Owners Package.Oct 27 2023, 7:01 PM