rP22518 failed somehow. Try again as a diff.
Based on a diff by @vladislavbelov
Differential D2101
Re-D2013 - Fix incorrect use of setlocale() in cppformat CStr tests wraitii on Jul 20 2019, 3:26 PM. Authored by
Details
rP22518 failed somehow. Try again as a diff. Based on a diff by @vladislavbelov Run CI.
Diff Detail
Event TimelineComment Actions Build failure - The Moirai have given mortals hearts that can endure. Link to build: https://jenkins.wildfiregames.com/job/docker-differential/145/display/redirect Comment Actions Build failure - The Moirai have given mortals hearts that can endure. Link to build: https://jenkins.wildfiregames.com/job/docker-differential/146/display/redirect Comment Actions Build failure - The Moirai have given mortals hearts that can endure. Link to build: https://jenkins.wildfiregames.com/job/docker-differential/170/display/redirect
Comment Actions Well it ought to be a common locale, and it makes as much sense as fr_FR given the numeric parsing we do. However jenkins still doesn't appear to have it, so I'll wait until @Itms returns. Comment Actions fr_FR is useful here because "," is the radix point instead of "." test_parse is intended to verify that changing the locale won't break parsing, should our implementation change. The only thing it wouldn't catch is if the user's locale is already fr_FR, so I would support adding two blocks or two test functions, one for en_US.UTF-8 and one for fr_FR.UTF-8, specifically to handle both cases. Comment Actions Needs to be rebased after rP23562 see comments there for what I believe to be the same bug. |