Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Remove more duplication.

Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

Rebase

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Fix some comments

In D1190#98997, @Imarok wrote:

Quickly tested the patch. Looks like a really nice behaviour. ?
But here are some things I noticed:

• I think elexis mentioned it already: There is no way to get rid of the ghosts of dead towers.

Quickly tested the patch. Looks like a really nice behaviour. ?
But here are some things I noticed:

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

More elaborate tooltip.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

• Improved text on option?
• Reverted to old entity removal from groups.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Remove warning,
Make green turrets disappear when cancelling build

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Rebased.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Typo.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Combined a check in updatePanelEntityBars in session.js.

Thanks for the fix in rP23070

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

jes i really encourage that code. peace of a op peace.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Added check for file attribute.

Concur that the try catch here is out of place and that it should happen in those functions whose execution depend on it to continue.

It seems "orange" is the "highlight" color of the theme? Could be refactored some day.

Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

The leak comes from rP9.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Rebase. Fix a few comments.

Now a measurement of the diplomacy panel update function before and after the patch (which I couldnt really do due to new folders and moved files):

Thanks for bringing the issue to my attention and going the extra mile to writing a proposal too.
Issue fixed in rP23065.
If you want to improve the presentation of the button feel free to create an independent proposal or pick this up.

Added classes:

DiplomacyButton
DiplomacyDialog
DiplomacyDialogCeasefireCounter
DiplomacyDialogColorsButton
DiplomacyDialogPlayerControl
DiplomacyDialogPlayerControlManager
Minimap
MiniMapDiplomacyColorsButton
MiniMapIdleWorkerButton
MiniMapPanel
AttackRequestButton
DiplomacyPlayerText
SpyRequestButton
StanceButtonManager
StanceButton
TributeButtonManager
TributeButton

On performance, it should not matter too much for this patch, since none of the classes do reoccurring updates on their own, and the only way they are called reoccurringly is through updateGUIObjects() which only calls g_DiplomacyDialog.update();, g_MiniMapPanel.update();.
The first call is early-returning if the dialog is closed, so doesnt affect unless the dialog is opened. If the dialog is opened, then the other dialogs are closed. It's few more function calls if it is opened which sounds negligible.
On the other side there is also less code performed in the update functions, since some of the attributes are only set once on init that previously were done each update call.

(And when speaking in general about this tribute button, there should be a way to abort the tribute. I remember a suggestion on irc at the time of that commit about making that a confirmation box, which has advantages (cancelability) and disadvantages (more user interaction if only wanting to send few amounts).
Also the amounts to be sent should be displayed on the buttons, right now theres only the tooltip which is shown for one of the resources to be tributed.)

Ah, I see indeed. Never mind then :)

Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

Some try at cannotattackfromthisangle. Note that it does not yet work as intended.

In D1191#98826, @Freagarach wrote:

If I see it correcty, rP17820 changed it so that only one resource was sent at a time?)

I don't see a behavior change in that commit, there are all resource types sent prior and afterwards, and prior and afterwards all of them are 0 or multiplier * 100.
Notice that sending resources this way still isnt ideal in D2365, as it sends one command per resource type in that case (which could be changed by storing the amounts in the manager instead of the button if one wanted to).

The code supports it.

The PostNetworkCommand sends amounts not amount, which would, for me, point strongly towards: "Hey, lets make sure we can tribute more than one resource in one go!" (Okay, that was probably because GetNeededResources needs an object.)
(If I see it correcty, rP17820 changed it so that only one resource was sent at a time?) While I agree it remains elusive whether or not it was ever intentional.

Successful build - Chance fights ever on the side of the prudent.

I think this is the intended behaviour of the author. It lets one tribute more than one resource at a time (what the function already supports).

Build failure - The Moirai have given mortals hearts that can endure.