queued or pushorderfront
Sun, Nov 17
Fix discard order
Use classic for instead for of, because speed
rebased, something was kicked out from diff
I ll update this but no idea when
Needs rebase, not sure it is worth to do at this state of reviews. Ping me if you want to review this I ll rebase.
Looks like will not get into code anyway so backlog.
I might rewrite it in way it can be set as option before starting of match so one can choose if wants classic or new behaviour of vision.
add support for modifiers
Sat, Nov 16
try to reupload
Fri, Nov 15
Thu, Nov 14
use setStringTags instead coloredText refering D2151
fix phrasing, use red colour so it is easier recognised as something wrong by player
@Imarok like this ?
Wed, Nov 13
I checked gui, mostly tooltips and summary screen. It looks fine.
while here it would be worth to check if added actually exists because event can be caused when unit leaves range
add sound entry for slave
If this.idle is false in LosRangeUpdate, simply call FindNewTargets, but because there can be multiple events while this.idle is false on LosRangeUpdate, there need to be some boolean which would ensure we call FindNewTargets just once and then we are safe to fall back to default behaviour
Tue, Nov 12
sorry, i missed cpp changes
yeah needs more files to change xD
Female citizen has it, I ll add that one for slave.
Mon, Nov 11
putting on hold, see discussion on irc: http://irclogs.wildfiregames.com/2019-11/2019-11-10-QuakeNet-%230ad-dev.log
fixing mostly rP23124, athen_thureophoros remaining
Sun, Nov 10
add Cheering order for nearby units so they cheer together if not in combat
Fri, Nov 8
Sun, Nov 3
I think it is good to know what is going on just by reading that line e.g. CancelTimer, StartTimer. One is not forced to guess what would be outcome of given call and is not needed to find body of that function. Next advantage is that one is sure he is not going to start or cancel timer by calling given functions even multiple times or by accident if timer is at state one wants to have it.
Sat, Nov 2
Thu, Oct 31
variable let target is super redundant in that code, not just introducing one more not needed declaration of variable also one more assignment back to this.repairTarge which can be avoided
Sorry it took so long.
Tests failed with this patch applied while they pass without it.
L3930 parameter looks redundant
Should it not be handled same way in COMBAT.APPROACHING and COMBAT.CHASING ?
Wed, Oct 30
Mon, Oct 21
Oct 14 2019
Oct 10 2019
Oct 9 2019
Oct 8 2019
Oct 3 2019
Sep 28 2019
Sep 26 2019
Sep 23 2019
Sep 22 2019
try to use members as implementation classes
Fixed in rP22965
jenkins silently builded the changed code here:
ERROR: CCacheLoader failed to find archived or source file for: "gui/hotkey.xml"
Sep 20 2019
There are at least two m_ItemsYPositions and maybe more variables for COListSingle
one from COList
second from CListSingle
Sep 19 2019
something is wrong with olistsingle, olistmultiple