Page MenuHomeWildfire Games
Feed Advanced Search

Today

Angen updated the diff for D2104: Unify usage of mouse buttons for preselected action and hotkey modifications.
Mon, Jul 22, 2:39 PM
Angen updated the diff for D2106: Move hardcoded gain per garrisoned trader on ship to template.

use early returns

Mon, Jul 22, 1:55 PM
Angen updated the diff for D2106: Move hardcoded gain per garrisoned trader on ship to template.

lets keep it this way, I dont know if I want to start balancing changes

Mon, Jul 22, 1:32 PM
Angen added inline comments to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..
Mon, Jul 22, 1:15 PM
Angen added inline comments to rP22425: UnitMotion - Explicit handling of movement errors (such as target death) in….
Mon, Jul 22, 1:01 PM
Angen raised a concern with rP22425: UnitMotion - Explicit handling of movement errors (such as target death) in….
Mon, Jul 22, 12:49 PM
Angen added inline comments to D2105: UnitMotion - Send messages to UnitAI when the path was obstructed, to allow stopping early when walking and avoiding pathfinding lag.
Mon, Jul 22, 12:28 PM
Angen added a comment to D2109: Move duplicated "Attack.js" schema code to helper..

trample should be mass vs mass, if something is bigger enough than you, you get trampled.

Mon, Jul 22, 10:37 AM

Yesterday

Angen updated the diff for D2107: Clean var values from Trader.js.

++, space, also removes not needed else branching because if before use return, and inlines one variable

Sun, Jul 21, 8:07 PM
Angen added a comment to D2107: Clean var values from Trader.js.

var is global declaration of variable
if you do var once in some function, that variable exists outside the scope
you can do multiple var with the same name and variable gets redeclared

Sun, Jul 21, 4:37 PM
Angen updated the summary of D2107: Clean var values from Trader.js.
Sun, Jul 21, 3:45 PM
Angen created D2107: Clean var values from Trader.js.
Sun, Jul 21, 3:44 PM
Angen added a comment to D2106: Move hardcoded gain per garrisoned trader on ship to template.

@Nescio But you can achieve the same effect with current state of the patch giving the numbers to ships. Current approach could be considered not fully satisfying if one could capture trader or merchant ship, what currently as I know can not. If it would be decided as better solution I would move it to another patch anyway as not everyone could agree with that change.

Sun, Jul 21, 3:24 PM
Angen added a comment to D2106: Move hardcoded gain per garrisoned trader on ship to template.

As jenkins is kind of broken, tests passed:

Sun, Jul 21, 3:11 PM
Angen added a comment to D2106: Move hardcoded gain per garrisoned trader on ship to template.

It looks like gameplay change so I cannot decide

Sun, Jul 21, 3:07 PM
Angen updated the summary of D2106: Move hardcoded gain per garrisoned trader on ship to template.
Sun, Jul 21, 2:56 PM
Angen updated subscribers of D2106: Move hardcoded gain per garrisoned trader on ship to template.
Sun, Jul 21, 2:52 PM
Angen updated the diff for D2106: Move hardcoded gain per garrisoned trader on ship to template.

fix typo

Sun, Jul 21, 2:46 PM
Angen updated the diff for D2106: Move hardcoded gain per garrisoned trader on ship to template.

tab to spaces and revert var -> let

Sun, Jul 21, 2:44 PM
Angen created D2106: Move hardcoded gain per garrisoned trader on ship to template.
Sun, Jul 21, 2:11 PM
Angen added inline comments to rP22314: Fix a crash on some system when Alt-tabbing during game setup..
Sun, Jul 21, 1:32 PM
Angen accepted D2029: Alt+tab fix for rP22314 - call IdleTask in Atlas and swap buffers only once.

I cannot agree on that we swapped buffers when we did not render
As you can see here https://code.wildfiregames.com/D1495?vs=on&id=7570#toc
If we were minimised we would not swap buffers, but other than that I have no strong opinion on that

Sun, Jul 21, 1:14 PM
Angen created D2104: Unify usage of mouse buttons for preselected action and hotkey modifications.
Sun, Jul 21, 11:17 AM

Fri, Jul 19

Angen added a comment to D2053: Round value of capture attack.

Here is current list of places in gui section where roof, ceil or round are used, filtered out not relevant results and splitted as I am
not sure about some cases

common\tooltips.js:177:         "current": Math.round(entState.hitpoints),
common\tooltips.js:178:         "max": Math.round(entState.maxHitpoints)
common\tooltips.js:210:         "percentage": (100 - Math.round(Math.pow(0.9, level) * 100))
common\tooltips.js:283:         let minRange = Math.round(template.attack[type].minRange);
common\tooltips.js:284:         let maxRange = Math.round(template.attack[type].maxRange);
common\tooltips.js:286:         let relativeRange = realRange ? Math.round(realRange - maxRange) : 0;
common\tooltips.js:350:                         "value": Math.round(template.garrisonHolder.buffHeal),
common\tooltips.js:367:                 Math.round(template.buildingAI.garrisonArrowMultiplier *
common\tooltips.js:401:                 Math.round(entState.repairable.buildTime.timeRemaining - entState.repairable.buildTime.timeRemainingNew)),
common\tooltips.js:403:                 "second": Math.round(entState.repairable.buildTime.timeRemaining - entState.repairable.buildTime.timeRemainingNew)
common\tooltips.js:408:                 Math.round(entState.repairable.buildTime.timeRemainingNew)),
common\tooltips.js:410:                 "second": Math.round(entState.repairable.buildTime.timeRemainingNew)
common\tooltips.js:423:                 Math.round(entState.foundation.buildTime.timeRemaining - entState.foundation.buildTime.timeRemainingNew)),
common\tooltips.js:425:                 "second": Math.round(entState.foundation.buildTime.timeRemaining - entState.foundation.buildTime.timeRemainingNew)
common\tooltips.js:430:                 Math.round(entState.foundation.buildTime.timeRemainingNew)),
common\tooltips.js:432:                 "second": Math.round(entState.foundation.buildTime.timeRemainingNew)
common\tooltips.js:444:                 totalCosts[r] = Math.floor(template.cost[r] * trainNum);
common\tooltips.js:456:         totalCosts.time = Math.ceil(template.cost.time * (entity ? Engine.GuiInterfaceCall("GetBatchTime", {
Fri, Jul 19, 3:45 PM
Angen added a comment to D2053: Round value of capture attack.
D:\A.0.Development\binaries\data\mods\public\gui>findstr /s /n "Math.round" *
common\color.js:156:    return [r, g, b].map(n => Math.round(n * 255));
common\colorFades.js:201:               rgb.g += Math.round(g_FadeAttackUnit.gbcolorChangeRate * Math.sqrt(data.tickCounter - g_FadeAttackUnit.blinkingTicks));
common\tooltips.js:177:         "current": Math.round(entState.hitpoints),
common\tooltips.js:178:         "max": Math.round(entState.maxHitpoints)
common\tooltips.js:210:         "percentage": (100 - Math.round(Math.pow(0.9, level) * 100))
common\tooltips.js:283:         let minRange = Math.round(template.attack[type].minRange);
common\tooltips.js:284:         let maxRange = Math.round(template.attack[type].maxRange);
common\tooltips.js:286:         let relativeRange = realRange ? Math.round(realRange - maxRange) : 0;
common\tooltips.js:350:                         "value": Math.round(template.garrisonHolder.buffHeal),
common\tooltips.js:367:                 Math.round(template.buildingAI.garrisonArrowMultiplier *
common\tooltips.js:401:                 Math.round(entState.repairable.buildTime.timeRemaining - entState.repairable.buildTime.timeRemainingNew)),
common\tooltips.js:403:                 "second": Math.round(entState.repairable.buildTime.timeRemaining - entState.repairable.buildTime.timeRemainingNew)
common\tooltips.js:408:                 Math.round(entState.repairable.buildTime.timeRemainingNew)),
common\tooltips.js:410:                 "second": Math.round(entState.repairable.buildTime.timeRemainingNew)
common\tooltips.js:423:                 Math.round(entState.foundation.buildTime.timeRemaining - entState.foundation.buildTime.timeRemainingNew)),
common\tooltips.js:425:                 "second": Math.round(entState.foundation.buildTime.timeRemaining - entState.foundation.buildTime.timeRemainingNew)
common\tooltips.js:430:                 Math.round(entState.foundation.buildTime.timeRemainingNew)),
common\tooltips.js:432:                 "second": Math.round(entState.foundation.buildTime.timeRemainingNew)
loading\loading.js:86:  let increment = Math.round(progress * middleLength / 100);
lobby\lobby.js:1017:                            Math.round(playerRatings.reduce((sum, current) => sum + current) / playerRatings.length) :
session\input.js:175:                           var averageRange = Math.round(Engine.GuiInterfaceCall("GetAverageRangeForBuildings", cmd) - cmd.range);
session\input.js:176:                           var range = Math.round(cmd.range);
session\input.js:1363:  return Math.max(Math.round(g_BatchSize), 1);
session\menu.js:847:    barterAmount.Buy.caption = "+" + Math.round(prices.sell[g_BarterSell] / prices.buy[resourceCode] * amountToSell);
session\selection_panels.js:602:                size.top = size.left + Math.round(queuedItem.progress * (size.right - size.left));
session\selection_panels.js:1124:                       size.top = size.left + Math.round(progress * (size.right - size.left));
session\selection_panels_helpers.js:48: return "color:255 0 0 " + Math.min(125, Math.round(+totalCost / 10) + 50);
session\session.js:1167:                                Math.round(playerStates[player].resourceCounts[resource]),
session\session.js:1169:                                Math.round(playerStates[player].resourceCounts[resource])
session\session.js:1281:                size.top = size.left + Math.round(researchStarted[tech].progress * (size.right - size.left));
session\session.js:1655:                playerStatistics.militaryScore += Math.round((player.sequences.enemyUnitsKilledValue[maxIndex] +
session\session.js:1657:                playerStatistics.totalScore += (total + Math.round((player.sequences.enemyUnitsKilledValue[maxIndex] +
summary\counters.js:130:        return Math.round(total / 10);
summary\counters.js:135:        return Math.round((playerState.sequences.enemyUnitsKilledValue[index] +
Fri, Jul 19, 3:25 PM
Angen added inline comments to rP22475: Fix IDLE-related infinite loops by moving stateful calls to IDLE.timer..
Fri, Jul 19, 3:17 PM
Angen added a comment to D2094: Fix unreported memory leaks, remove unused code and use c++ style casts in the glooxwrapper following rP19703.

builds windows vs2015 release and debug

Fri, Jul 19, 2:18 PM
Angen added inline comments to D1868: Add call-to-arms button..
Fri, Jul 19, 2:15 PM
Angen added inline comments to D1868: Add call-to-arms button..
Fri, Jul 19, 2:15 PM
Angen awarded D2094: Fix unreported memory leaks, remove unused code and use c++ style casts in the glooxwrapper following rP19703 a Like token.
Fri, Jul 19, 12:50 PM
Angen added a comment to D2100: Make cart team bonus actually be +10% instead + 0.1.

sure it would :) hardcoded number is bad number :) wanna do patch ?

Fri, Jul 19, 11:22 AM
Angen added a comment to D2100: Make cart team bonus actually be +10% instead + 0.1.

yes it is, see Trader.js

Fri, Jul 19, 11:07 AM
Angen added a comment to D1868: Add call-to-arms button..

I just tested it and does not work. They do not even move to that location / unit I order them to attack with this command.

Fri, Jul 19, 11:03 AM
Angen abandoned D2100: Make cart team bonus actually be +10% instead + 0.1.

yes, you are correct, my bad, internationbonus is used as multiplier

Fri, Jul 19, 10:51 AM
Angen added a reviewer for D2100: Make cart team bonus actually be +10% instead + 0.1: Restricted Owners Package.
Fri, Jul 19, 9:34 AM
Angen created D2100: Make cart team bonus actually be +10% instead + 0.1.
Fri, Jul 19, 9:12 AM

Thu, Jul 18

Angen added a comment to D1768: Formations: GetClosestMember passes wrong entity to filter function.
In D1768#71234, @elexis wrote:

The last time someone has worked on formations, it was @temple.

Thu, Jul 18, 1:25 PM
Angen added a comment to D2008: Fix formation-related unitAI infinite loop.

Formation units where not allowed to be in individual idle before, not sure who made it possible
https://code.wildfiregames.com/rP14581

Thu, Jul 18, 12:05 PM

Wed, Jul 17

Angen awarded rP22496: Fix walk-to-target and other movements with max-range "0" for target entities a Like token.
Wed, Jul 17, 9:36 PM
Angen updated the diff for D2030: Update wxWidgets readme [VS2013 -> VS2015].

revert wxw sln version

Wed, Jul 17, 7:03 PM
Angen added a comment to D2030: Update wxWidgets readme [VS2013 -> VS2015].

@Itms whit which version did you build wxWidgets 3.0.4 ?

Wed, Jul 17, 6:38 PM

Tue, Jul 16

Angen added a comment to D2030: Update wxWidgets readme [VS2013 -> VS2015].

@historic_bruno see https://code.wildfiregames.com/D1909 line 42

Tue, Jul 16, 9:05 PM
Angen updated the diff for D2030: Update wxWidgets readme [VS2013 -> VS2015].

at least

Tue, Jul 16, 1:50 PM
Angen awarded D368: Gameplay Scripting: Entity and Actor coding for Secondary Attacks a Love token.
Tue, Jul 16, 1:41 PM

Mon, Jul 15

Angen updated the Trac tickets for D2054: Apply modifications to template values based on entity owner instead watching player.
Mon, Jul 15, 12:29 PM

Sun, Jul 14

Angen updated the diff for D1817: Remove unused variable and fail to register component if it has no constructor [ComponentManager].

inline

Sun, Jul 14, 1:26 PM
Angen accepted D2074: Fix UB following rP22456.

builds, saves, loads without error or crash

Sun, Jul 14, 11:09 AM
Angen updated the test plan for D1817: Remove unused variable and fail to register component if it has no constructor [ComponentManager].
Sun, Jul 14, 10:27 AM
Angen added a comment to D1907: Unit Motion - improve PathResult/Obstructed move handling.

Here is source of crash reported by gameboy on forum reproducible with vs2013 build https://wildfiregames.com/forum/index.php?/topic/26498-game-crash/

Sun, Jul 14, 10:16 AM
Angen updated the diff for D1817: Remove unused variable and fail to register component if it has no constructor [ComponentManager].
Sun, Jul 14, 9:36 AM
Angen added inline comments to D1817: Remove unused variable and fail to register component if it has no constructor [ComponentManager].
Sun, Jul 14, 8:33 AM

Thu, Jul 11

Angen added inline comments to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..
Thu, Jul 11, 8:18 PM
Angen added inline comments to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..
Thu, Jul 11, 7:26 PM
Angen added inline comments to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..
Thu, Jul 11, 6:55 PM
Angen planned changes to D1977: Change Cheering.

after unitai is stable

Thu, Jul 11, 5:59 PM
Angen awarded D2061: Unify EdgeTile count in ICmpRangeManager, CCmpPathfinder, MapGenerator a Like token.
Thu, Jul 11, 7:05 AM

Wed, Jul 10

Angen added inline comments to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..
Wed, Jul 10, 1:41 PM
Angen added a comment to D2053: Round value of capture attack.

Adding one more argument why have toFixed(1) and no toFixed(2) for example

Wed, Jul 10, 11:02 AM
Angen added a comment to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..

GetCodes always return array, so you need to check length not existance of return

Wed, Jul 10, 10:10 AM
Angen added a comment to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..

Then I would advise just early returns in that cases because disabling whole ai component could potentially cause more problems to do it and handle at all places.

Wed, Jul 10, 8:37 AM
Angen added a comment to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..

I would not see a problem with petra as looping through 0 resources takes 0 time

Wed, Jul 10, 8:28 AM

Tue, Jul 9

Angen added inline comments to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..
Tue, Jul 9, 10:29 PM
Angen accepted D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..

ok, I did not see that. I guess is too late for me now :) Anyway. Pointed problems have been resolved.

Tue, Jul 9, 9:44 PM
Angen added a comment to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..

nice, but still issue if food is not bartable

Tue, Jul 9, 9:28 PM
Angen added inline comments to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..
Tue, Jul 9, 9:01 PM
Angen updated the diff for D2054: Apply modifications to template values based on entity owner instead watching player.

@Nescio fixed, thank you for report

Tue, Jul 9, 8:59 PM
Angen planned changes to D2054: Apply modifications to template values based on entity owner instead watching player.

uhg, ok thnx

Tue, Jul 9, 8:50 PM
Angen added a comment to D2054: Apply modifications to template values based on entity owner instead watching player.

@Nescio
do you have mods with edited files in this patch? I cannot reproduce it.

Tue, Jul 9, 8:33 PM
Angen added a comment to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..

a bit more digging

Tue, Jul 9, 8:24 PM
Angen added inline comments to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..
Tue, Jul 9, 8:01 PM
Angen requested changes to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..

to not have this accepted as has a flaw

Tue, Jul 9, 7:35 PM
Angen added inline comments to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..
Tue, Jul 9, 7:34 PM
Angen added inline comments to D2056: Support for more garrisoned slots per entity..
Tue, Jul 9, 5:51 PM
Angen added inline comments to D2056: Support for more garrisoned slots per entity..
Tue, Jul 9, 5:14 PM
Angen added a comment to D2053: Round value of capture attack.

IRC discussion (http://irclogs.wildfiregames.com/2019-07/2019-07-09-QuakeNet-%230ad-dev.log)

Tue, Jul 9, 5:09 PM
Angen updated the summary of D2053: Round value of capture attack.
Tue, Jul 9, 1:23 PM
Angen added a comment to D2044: Allow immunity to certain damage types..

i ll check another things later

Tue, Jul 9, 7:49 AM

Mon, Jul 8

Angen added a comment to D2044: Allow immunity to certain damage types..
In D2044#85379, @FeXoR wrote:
In D2044#85377, @Nescio wrote:

Increased mod support?

That can be said about any functional code. If we would add all that we basically would have to add all mods in the first place for other mods might use parts of it.

Also, currently in 0 A.D. siege engines have a pierce armour of 50 (i.e. 1-0.9^50, which is over 99%), so they're practically invulnerable already; to me that seems to be a workaround. This patch would allow making them completely invulnerable, so e.g. archers won't waste their arrows on attacking rams, but instead attack other enemy units around.

And to me it shows that our current damage system already can handle that. (The unitAI is a different story)

Mon, Jul 8, 6:40 AM

Sun, Jul 7

Angen added inline comments to D2044: Allow immunity to certain damage types..
Sun, Jul 7, 9:57 PM
Angen added a comment to D2044: Allow immunity to certain damage types..

for start, then you should basicly grep .attack and think if that can be problem

Sun, Jul 7, 9:51 PM
Angen added a comment to D2044: Allow immunity to certain damage types..

yes that would be better place :)

Sun, Jul 7, 7:42 PM
Angen updated the diff for D2054: Apply modifications to template values based on entity owner instead watching player.

[complete]
Added buildings.
Technologies are handled differently so they does not have this issue.

Sun, Jul 7, 5:35 PM
Angen added a comment to D2054: Apply modifications to template values based on entity owner instead watching player.

I added it only for training, I should and will add it for research and building to be complete. Only stats not displayed with updates could be when you right click to icon. Anything else should be taken from entity state, which has current values.

Sun, Jul 7, 4:59 PM
Angen retitled D2054: Apply modifications to template values based on entity owner instead watching player from Apply modifications to template values based of entity owner instead watching player to Apply modifications to template values based on entity owner instead watching player.
Sun, Jul 7, 4:09 PM
Angen created D2054: Apply modifications to template values based on entity owner instead watching player.
Sun, Jul 7, 4:00 PM
Angen added a comment to D2051: Display wonders alongside heroes and relics.

I thought that if someone builds/captures wonder message is broadcasted that player has one and countdown starts.

Sun, Jul 7, 3:12 PM
Angen added a comment to D2044: Allow immunity to certain damage types..

You would need to write one at extendedentity.js in petra directory. I suggest to not call canAttack from cmpAttack but rather to check attack types and armour using functions petra has (attackStrengths,armourStrenghts), because that would use only template values and will be faster as petra would call canAttack very often.

Sun, Jul 7, 2:45 PM
Angen created D2053: Round value of capture attack.
Sun, Jul 7, 2:38 PM
Angen added a comment to D2044: Allow immunity to certain damage types..

Would be nice to add test against infinite armour

Sun, Jul 7, 9:33 AM

Sat, Jul 6

Angen added inline comments to D2044: Allow immunity to certain damage types..
Sat, Jul 6, 5:17 PM
Angen added inline comments to D2044: Allow immunity to certain damage types..
Sat, Jul 6, 5:17 PM

Fri, Jul 5

Angen added inline comments to D2044: Allow immunity to certain damage types..
Fri, Jul 5, 11:33 PM
Angen added inline comments to D2046: Fix GetTerritoryPercentage when changing number of players.
Fri, Jul 5, 9:05 PM
Angen created D2046: Fix GetTerritoryPercentage when changing number of players.
Fri, Jul 5, 9:02 PM
Angen added a comment to D2044: Allow immunity to certain damage types..

Checks for infinit armour should be in getbestattackagainst too
and you need to edit AttackPlan.js in Petra AI function "update" as well

Fri, Jul 5, 8:13 PM
Angen added a comment to D2019: [ATLASUI] Main Thread Checker: UI API called on a background thread: -[NSView initWithFrame:].

Windows 10:
menu visible with and without patch
no warnings with and without patch

Fri, Jul 5, 8:07 PM
Angen resigned from D1965: Allow instant-kill for attacks. (And use it for "Slaughter"-attack.).

requested changes are not more valid because split

Fri, Jul 5, 7:17 PM
Angen added a comment to D2042: Atlas variation submenu.

It builds for me on windows but not with jenkins, he has linux

Fri, Jul 5, 6:57 PM
Angen added inline comments to D2042: Atlas variation submenu.
Fri, Jul 5, 6:54 PM
Angen added a comment to D2042: Atlas variation submenu.

please remove not needed braces for one command after if condition, will test once it builds

Fri, Jul 5, 6:40 PM