Page MenuHomeWildfire Games
Feed Advanced Search

Yesterday

Angen awarded D2412: Lobby class implementation a Love token.
Mon, Nov 18, 5:59 PM

Sun, Nov 17

Angen planned changes to D1977: Change Cheering.

queued or pushorderfront

Sun, Nov 17, 9:30 PM
nani awarded D1977: Change Cheering a Like token.
Sun, Nov 17, 8:24 PM
Angen updated the diff for D1977: Change Cheering.
Sun, Nov 17, 8:02 PM
Angen planned changes to D1977: Change Cheering.

how do i have cmpVision there 🗡

Sun, Nov 17, 7:21 PM
Angen updated the diff for D1977: Change Cheering.

Fix discard order
Change comment
Use classic for instead for of, because speed

Sun, Nov 17, 6:56 PM
Angen updated the diff for D1940: UnitAI cleanup [GATHER].

rebased, something was kicked out from diff

Sun, Nov 17, 6:41 PM
Angen abandoned D1670: Singleton g_Game and g_SoundManager.
Sun, Nov 17, 6:24 PM
Angen planned changes to D1346: List multiselection.

I ll update this but no idea when

Sun, Nov 17, 6:18 PM
Angen planned changes to D1462: Enforce formation required member count.

Needs rebase, not sure it is worth to do at this state of reviews. Ping me if you want to review this I ll rebase.

Sun, Nov 17, 6:02 PM
Angen abandoned D1673: Update NULL to nullptr.

Looks like will not get into code anyway so backlog.

Sun, Nov 17, 5:57 PM
Angen planned changes to D1905: Vision Blocking by Terrain while exploring.

I might rewrite it in way it can be set as option before starting of match so one can choose if wants classic or new behaviour of vision.

Sun, Nov 17, 5:54 PM
Angen removed a reviewer for D2053: Round value of capture attack: Restricted Owners Package.
Sun, Nov 17, 5:51 PM
Angen added a reviewer for D2415: Refactor ColorActivateFastImpl function: Restricted Owners Package.
Sun, Nov 17, 5:50 PM
Angen added a reviewer for D2416: Simplify conditions in SetAnimation: Restricted Owners Package.
Sun, Nov 17, 5:49 PM
Angen planned changes to D1977: Change Cheering.

forgot to discard order

Sun, Nov 17, 5:46 PM
Angen updated the diff for D2054: Apply modifications to template values based on entity owner instead watching player.

rebase

Sun, Nov 17, 1:40 PM
Angen updated the diff for D2106: Move hardcoded gain per garrisoned trader on ship to template.

fix schema
shorter name
add support for modifiers
remove bracket

Sun, Nov 17, 12:19 PM
Angen planned changes to D2106: Move hardcoded gain per garrisoned trader on ship to template.

fix schema

Sun, Nov 17, 9:48 AM

Sat, Nov 16

Angen added inline comments to D2106: Move hardcoded gain per garrisoned trader on ship to template.
Sat, Nov 16, 6:53 PM
Angen updated the diff for D2106: Move hardcoded gain per garrisoned trader on ship to template.

try to reupload

Sat, Nov 16, 6:20 PM

Fri, Nov 15

Angen updated the summary of D1943: UnitAI fix return value on "enter" according to FSM logic.
Fri, Nov 15, 9:40 PM
Angen raised a concern with rP14115: Move ship to shoreline when tasking units to garrison inside, fixes #1391.
Fri, Nov 15, 9:38 PM
Angen raised a concern with rP18779: Patrol units. Patch by Imarok, based on patch by svott, reviewed by….
Fri, Nov 15, 9:28 PM
Angen updated the diff for D1943: UnitAI fix return value on "enter" according to FSM logic.

update

Fri, Nov 15, 9:23 PM
Angen updated the diff for D2117: Do not enable rated game if game is singleplayer or has not exactly 2 players.
Fri, Nov 15, 8:17 PM
Angen planned changes to D2117: Do not enable rated game if game is singleplayer or has not exactly 2 players.
Fri, Nov 15, 4:28 PM
Angen added a reviewer for D2285: Inform player that second market is too close to setup trade route: elexis.
Fri, Nov 15, 3:47 PM
Angen added a reviewer for D2276: Add build order to unit commands to play different sounds for build and repair: Restricted Owners Package.
Fri, Nov 15, 5:23 AM

Thu, Nov 14

Angen updated the diff for D2285: Inform player that second market is too close to setup trade route.

use setStringTags instead coloredText refering D2151

Thu, Nov 14, 10:03 PM
Angen updated the diff for D2285: Inform player that second market is too close to setup trade route.

fix phrasing, use red colour so it is easier recognised as something wrong by player

Thu, Nov 14, 9:39 PM
Angen planned changes to D2285: Inform player that second market is too close to setup trade route.

@Imarok like this ?

Thu, Nov 14, 9:22 PM

Wed, Nov 13

Angen added a comment to D2421: Update sprintf.js library.

I checked gui, mostly tooltips and summary screen. It looks fine.

Wed, Nov 13, 8:15 PM
Angen created D2423: Do not use GPUSkinning without glsl [Crash fix].
Wed, Nov 13, 7:35 PM
Angen added a comment to D2422: Fix idle unit not attacking nearest unit..

while here it would be worth to check if added actually exists because event can be caused when unit leaves range

Wed, Nov 13, 6:15 PM
Angen updated the diff for D2276: Add build order to unit commands to play different sounds for build and repair.

add sound entry for slave

Wed, Nov 13, 6:13 PM
Angen added a comment to rP22475: Fix IDLE-related infinite loops by moving stateful calls to IDLE.timer..

If this.idle is false in LosRangeUpdate, simply call FindNewTargets, but because there can be multiple events while this.idle is false on LosRangeUpdate, there need to be some boolean which would ensure we call FindNewTargets just once and then we are safe to fall back to default behaviour

Wed, Nov 13, 10:45 AM

Tue, Nov 12

Angen resigned from rP23151: Rename CProgressBar numeric "caption" setting to "progress" to distinguish it….

sorry, i missed cpp changes

Tue, Nov 12, 7:18 PM
Angen raised a concern with rP23151: Rename CProgressBar numeric "caption" setting to "progress" to distinguish it….
Tue, Nov 12, 7:10 PM
Angen requested review of D1946: Windows Differential testing.
Tue, Nov 12, 6:55 PM
Angen updated the diff for D1959: Show helmets when doing citizen duty.
Tue, Nov 12, 6:18 PM
Angen awarded D2420: Fix OS hardware detection on windows. a Yellow Medal token.
Tue, Nov 12, 5:45 PM
Angen awarded D2420: Fix OS hardware detection on windows. a Orange Medal token.
Tue, Nov 12, 5:45 PM
Angen planned changes to D1959: Show helmets when doing citizen duty.

yeah needs more files to change xD

Tue, Nov 12, 1:49 PM
Angen reclaimed D1959: Show helmets when doing citizen duty.

so take it back

Tue, Nov 12, 1:46 PM
Angen abandoned D1959: Show helmets when doing citizen duty.
Tue, Nov 12, 12:39 PM
Angen planned changes to D2276: Add build order to unit commands to play different sounds for build and repair.

Female citizen has it, I ll add that one for slave.

Tue, Nov 12, 12:38 PM
Angen added inline comments to rP9631: Stances draft, refs #865.
Tue, Nov 12, 8:08 AM

Mon, Nov 11

Angen retitled D2414: Do not send Screen height, width to shader if not needed [On Hold] from Do not send Screen height, width to shader if not needed to Do not send Screen height, width to shader if not needed [On Hold].
Mon, Nov 11, 6:45 PM
Angen added a comment to D2414: Do not send Screen height, width to shader if not needed [On Hold].

putting on hold, see discussion on irc: http://irclogs.wildfiregames.com/2019-11/2019-11-10-QuakeNet-%230ad-dev.log

Mon, Nov 11, 6:45 PM
Angen added a comment to rP23141: New animations for Slingers and Archers..

fixing mostly rP23124, athen_thureophoros remaining

Mon, Nov 11, 6:30 PM
Angen created D2416: Simplify conditions in SetAnimation.
Mon, Nov 11, 6:03 PM
Angen created D2415: Refactor ColorActivateFastImpl function.
Mon, Nov 11, 5:52 PM
Angen added inline comments to rP3764: # refactoring.
Mon, Nov 11, 3:31 PM
Angen added inline comments to rP7609: # Unit animation improvements..
Mon, Nov 11, 3:16 PM
Angen added inline comments to rP7609: # Unit animation improvements..
Mon, Nov 11, 2:53 PM
Angen added a comment to D2343: [WIP] - Combine "EntityCommand" and "AllyEntityCommand"..

Mon, Nov 11, 1:30 PM

Sun, Nov 10

Angen updated the diff for D2413: Remove duplication of code from WaterManager.

static cast

Sun, Nov 10, 3:23 PM
Angen created D2414: Do not send Screen height, width to shader if not needed [On Hold].
Sun, Nov 10, 3:18 PM
Angen created D2413: Remove duplication of code from WaterManager.
Sun, Nov 10, 2:02 PM
Angen updated the diff for D1977: Change Cheering.

add Cheering order for nearby units so they cheer together if not in combat

Sun, Nov 10, 1:36 PM
Angen updated the diff for D1977: Change Cheering.

rebase

Sun, Nov 10, 1:07 PM
Angen raised a concern with rP23124: Standarize Capes for make them easier to handle..

Wrong animation for capes + capes keep projectile as prop

Sun, Nov 10, 12:58 PM

Fri, Nov 8

Angen added inline comments to D2411: Allow to limit unit count per match..
Fri, Nov 8, 9:28 AM

Sun, Nov 3

Angen added a comment to D2400: Optimize Resource Trickle by not running timers when not necessary.

I think it is good to know what is going on just by reading that line e.g. CancelTimer, StartTimer. One is not forced to guess what would be outcome of given call and is not needed to find body of that function. Next advantage is that one is sure he is not going to start or cancel timer by calling given functions even multiple times or by accident if timer is at state one wants to have it.

Sun, Nov 3, 12:18 PM

Sat, Nov 2

Angen added inline comments to D2400: Optimize Resource Trickle by not running timers when not necessary.
Sat, Nov 2, 9:35 AM
Angen added inline comments to D2400: Optimize Resource Trickle by not running timers when not necessary.
Sat, Nov 2, 9:34 AM

Thu, Oct 31

Angen added a comment to D2360: Fix entities not retaining repair order after target transforms..

variable let target is super redundant in that code, not just introducing one more not needed declaration of variable also one more assignment back to this.repairTarge which can be avoided

Thu, Oct 31, 7:35 PM
Angen requested changes to D1411: Add commandline flag to set source and execution charsets to utf-8.

Sorry it took so long.
Tests failed with this patch applied while they pass without it.

Thu, Oct 31, 6:11 PM
Angen added inline comments to D2397: Do not hardcode "delete" and "focus-rally" in whether a command button is active..
Thu, Oct 31, 5:55 PM
Angen added a comment to D2129: Let entity react on target death directly..

L3930 parameter looks redundant
Should it not be handled same way in COMBAT.APPROACHING and COMBAT.CHASING ?

Thu, Oct 31, 7:59 AM

Wed, Oct 30

Angen added inline comments to D2343: [WIP] - Combine "EntityCommand" and "AllyEntityCommand"..
Wed, Oct 30, 9:55 PM
Angen added inline comments to D2367: Move "GarrisonVisibly" to a seperate function and create its counterpart..
Wed, Oct 30, 10:53 AM
Angen added inline comments to D2343: [WIP] - Combine "EntityCommand" and "AllyEntityCommand"..
Wed, Oct 30, 10:48 AM

Mon, Oct 21

Angen awarded D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes a Love token.
Mon, Oct 21, 8:13 AM

Oct 14 2019

Angen awarded D2372: [WIP] - Support for mining. a Love token.
Oct 14 2019, 2:07 PM

Oct 10 2019

Angen added inline comments to D2364: Add an option to display ranges when pressing the showstatusbars hotkey.
Oct 10 2019, 8:07 AM

Oct 9 2019

Angen added inline comments to D1958: Turrets and/or sub-units..
Oct 9 2019, 9:26 AM

Oct 8 2019

Angen added inline comments to D1958: Turrets and/or sub-units..
Oct 8 2019, 2:24 PM

Oct 3 2019

Angen added inline comments to rP23031: Splits Camera control from CGameView to separate file..
Oct 3 2019, 12:56 PM
Angen added inline comments to rP23031: Splits Camera control from CGameView to separate file..
Oct 3 2019, 12:55 PM
Angen added inline comments to rP23031: Splits Camera control from CGameView to separate file..
Oct 3 2019, 8:36 AM
Angen awarded rP23024: New idle relax animations for the hoplite. a Like token.
Oct 3 2019, 8:28 AM
Angen awarded rP23030: More lifelike idle animations and some new sword attacking animations for… a Love token.
Oct 3 2019, 8:26 AM

Sep 28 2019

Angen added inline comments to D1958: Turrets and/or sub-units..
Sep 28 2019, 1:02 PM

Sep 26 2019

Angen abandoned D1604: Make capturing optional.
Sep 26 2019, 5:45 PM

Sep 23 2019

Angen awarded rP22987: Fix blood sometimes appearing below cattle, because of a variant having a… a Evil Spooky Haunted Tree token.
Sep 23 2019, 4:52 PM

Sep 22 2019

Angen updated the diff for D1346: List multiselection.

try to use members as implementation classes

Sep 22 2019, 8:41 PM
Angen accepted rP22963: Improve js glue code in D1839/rP22909 (hotkey state fix) and deal with rebase….

Fixed in rP22965

Sep 22 2019, 12:19 PM
Angen added a comment to rP22963: Improve js glue code in D1839/rP22909 (hotkey state fix) and deal with rebase….

jenkins silently builded the changed code here:
https://jenkins.wildfiregames.com/blue/organizations/jenkins/vs2015-differential/detail/vs2015-differential/277/pipeline

Sep 22 2019, 11:53 AM
Angen raised a concern with rP22963: Improve js glue code in D1839/rP22909 (hotkey state fix) and deal with rebase….

ERROR: CCacheLoader failed to find archived or source file for: "gui/hotkey.xml"

Sep 22 2019, 10:09 AM

Sep 20 2019

Angen added a comment to rP22942: Fix latest issues of the old helmets files merge..

#5600

Sep 20 2019, 6:11 PM
Angen added inline comments to D2308: Extend the visible garrisoning schema to allow specific units on specific turrets..
Sep 20 2019, 4:53 PM
Angen added inline comments to D2308: Extend the visible garrisoning schema to allow specific units on specific turrets..
Sep 20 2019, 4:27 PM
Angen updated the diff for D1346: List multiselection.

working version

Sep 20 2019, 10:21 AM
Angen added a comment to D1346: List multiselection.

There are at least two m_ItemsYPositions and maybe more variables for COListSingle
one from COList
second from CListSingle

Sep 20 2019, 9:30 AM
Angen planned changes to D1346: List multiselection.
Sep 20 2019, 7:41 AM

Sep 19 2019

Angen updated the diff for D1346: List multiselection.

something is wrong with olistsingle, olistmultiple

Sep 19 2019, 10:22 PM
Angen planned changes to D1346: List multiselection.
Sep 19 2019, 7:11 PM
Angen updated the diff for D1346: List multiselection.

Single, Multiple class design
Not synchronised with js
OList is Single for now

Sep 19 2019, 7:10 PM