In rP23040#38695, @elexis wrote:

If you commit something, please check what Jenkins says (https://jenkins.wildfiregames.com/)'public/art/actors/props/units/capes/rider/elephant_driver_asian.xml',

In D1958#97980, @Freagarach wrote:

• Increased spread when moving?
• (De)serialising.
• Do not show visible garrisoned units in the garrison panel (left)?

From @bb's patch (thanks again):

• Tooltips.
• Riding stances.
• CanAttackFromAngle with an MaxAttackAngle.
• Uses turrets also for ordinary horseriders, but don't let them turn. What is the purpose of a turret then? (Only be able to shoot when moving straight towards the target.)

Can this add a "visual" modifier were the unit assets are changed? IE: Shields, Weapons, Helmets. This option for have an "upgradable" weapon-like system for assault rifles like upgrading to Scopes or Handgrips or even magazines.

One point to consider if possible:

I've teted with chicken gathering quickly:

• The helmet of the unit is visible during the slaughter animation
• Helmet / Hat invisible during gathering and return resource

I suppose its not a big issue, we can create a trac backlog ticket if you have things to do, I reported it as it was reported to me and technically its a valid report.

In rP22839#37377, @Freagarach wrote:

units/pers_champion_infantry...
ERROR: Could not load animation 'art/animation/biped/infantry/spearman/run_ready_shield_shieldsmall.dae'
ERROR: CSkeletonAnimManager::GetAnimation(art/animation/biped/infantry/spearman/run_ready_shield_shieldsmall.dae): Failed loading, marked file as bad

In rP22775#36798, @Nescio wrote:

Did a grep in the simulation folder, found templates/units/samnite_swordsman.xml

In rP22775#36795, @Freagarach wrote:

ERROR: CCacheLoader failed to find archived or source file for: "art/actors/units/carthaginians/infantry_swordsman_2_b.xml"
ERROR: CObjectManager::FindObjectBase(): Cannot find object 'units/carthaginians/infantry_swordsman_2_b.xml'

In rP22723#36472, @elexis wrote:

Why it would mark this as bad while others cavalry_javelinist_x_m use the same variant textures? in any case i copied from cavalry_javelinist_a to _b and see if it fixes it.

Check the attached logfile, it's marked for many files

In rP22723#36469, @elexis wrote:

Also unrelated to this commit, but the XML validation script spams 1 error and 1 warning for many files, in case someone reading this wants to do a mass change:

Error in "/path/to/trunk/binaries/data/mods/public/art/actors/units/persians/cavalry_javelinist_b_m.xml": actor does not contain required texture "baseTex" from "basic_trans_parallax_spec.xml"

In rP22673#36250, @elexis wrote:

It might also be that the servers are timing out, not client(you). Unless you have someone already taking care of it, you might want to try to commit smaller batches of modified files if that is possible.
Thanks for taking care of this issue Alexandermb!

This commit is supposed to have another wich adds the new re-exported animations and another with the deletions of the bugged ones. But i have a connection issue with the forrum/server since the first blackout of my country so im unnable of commit larger files. I told other art development contributors to commit the files if possible. I'll do the rest of the cleaning after everything is commited

In rP22645#36034, @elexis wrote:

rP22594 introduced the issue, or whether both were bugged.

In rP22645#36029, @elexis wrote:

rP21038 introduced units/horse/sele_crest.xml correctly

In D2033#84727, @Nescio wrote:

Separatedly, someone with more knowledge and experience of the art/ files should correct the following:

• "akin" [sic] into "akinakes"
• "gladus" [sic] into "gladius"
• "pillum" [sic] into "pilum"
• "tessalian" [sic] into "thessalian"

(involves file moves etc.).