Ah yes that's retarded thanks for the fix.

Maybe you could chase the wall instead ? Like stop at vision range of the wall ?

The advantage of the C++ cmp is it can be used by the engine while if it's only js you can't :) Usually though it only requires a small subset of the code so it can be fine with a little subset of functions like it is the case here. I think the other function in the interface is not even needed.

I think i encountered the latter when playing with turrets.

Sorry I meant it could be done and it was actually done before. One could also change a unit into another one.

The template stats are different :)

You could but currently we just delete the entity and create a new one for promotion. Usually you want to change the template as well

You can already do so :) you need to Query the IID_Visual component :)

In D1955#81558, @Freagarach wrote:

In D1955#81537, @Stan wrote:

Fair enough :) But he will have to fix all the voices as well ?

Or will he have to add a get phentotype function that does the same thing as get gender until this is sorted out ?

It would seem logical to me to add a "phenotype"-function now and prepare the C-file for a "phenotype".
< Kindly ignoring the gender being imposed on me. >

In D1958#81457, @Angen wrote:

attack animation does not play and sometimes will not attack ( if player commands )

Fair enough :) But he will have to fix all the voices as well ?

I meant if gender was to be replaced by phenotype.

Gender is used in every template... That should be renamed in another patch

Small cleanup

again.

add missing lines at end of files.

Re add missing files.

Damn it deleted all the files...

I probably should have asked that before, but wasn't std::thread broken/missing features on windows ? https://stackoverflow.com/questions/13134186/c11-stdthreads-vs-posix-threads

Use every instead of some.

Working version, animation is weird.

Last version I made (probably needs rebase)

First rebase by me.

Third version by Sanderd17, will fail as well.

Second version( will fail)

First version by Sanderd17 (will fail)

Do not display bonuses equal to 1

• Fix the remaining comments.

Now works with bonuses changed via tech following rP22346

You need to remove that cpp file and update workspaces :)

Yes that's what I mean :) It's okay we all have to learn sometimes :)

Is it common to reference numbers as letters ?

Indeed that also works.

You should only have to define the interface in C++ not the whole class.

Sure !

Does it make sense to create functions

Angen could just have requested review :)

In D1928#80957, @Polakrity wrote:

Why not just use Singleton pattern instead using prototypes if only one instance?

Would be nice to have a testing map for this / unit tests to check whether the states switch fine.

In D1950#80886, @Freagarach wrote:

In D1950#80879, @Stan wrote:

Did you use tabs or spaces ?

Yes.
Ah, my students hate it when I do that xD I used spaces, because:

In D1950#80830, @Stan wrote:

Yes two spaces for indentation.

In rP22310#33789, @aeonios wrote:

In rP22310#33575, @Angen wrote:

actually it is water refraction effect causing it so now I am not sure if it exactly the same thing but it is red

Well, red water problems are a longstanding issue. It occurs when it tries to draw areas outside of the water during refraction, and appears at certain angles for reasons that aren't easy to explain but probably have to do with the hack used to produce refraction.

I noticed that red water issues got a lot worse after wraitii introduced a patch which interpolates between the base water image and a blurred version based on water depth. The way he did that really didn't make very good sense to begin with (should have just used a downscaled image rather than blurring in the shader), it's slow, and it causes other issues.

To be fair water has always been a pain to work with, as I know all too well.

Did you use tabs or spaces ?

Yes two spaces for indentation. Any good editor will do it for you.

I don't have access to D1945

Identation seems to be incorrect on the template files.

@Angen since you were the original reporter do you still experience the bug ? :)

• Use else if,
• Reverse condition members

In rP22219 there was

You can create a trac ticket if you want :) but it's okay to have long discussions here as well.
IMHO Capture should be a special type of attack with an affects property that says whether it's IID_Health or IID_something that gets affected ;)

Can you write a test for this ? :) Dunno how hard it is.

Hey @Teiresias, long time no see.
Some style comments. I guess you can ignore the static_cast though it's part of our coding conventions.

I mean finding out which file use it so you can make it external :)

Why would it be not consistent with the syntax in the rest of templates? I think it would make it *more* consistent. (E.g. a unit costs "Resources", what resources? "food" and "wood"; a unit does "Damage", what damage? "crush" and "pierce".)

But then it would not be consistent with the syntax in the rest of the templates, which would lead to utter confusion I guess. Also yeah I think that's out of the scope :)

The example here https://en.cppreference.com/w/cpp/container/map/find gave me the idea for the check.

Here is my version of the script. Builds debug and release and the tests