Careful if you make a new file, you need to tell Transifex to pull it.

Only because you await it no? If you didn't it would not block therefore the method itself is async? Or am I missing something

If you return a promise then it is ?

How about PushGuiPageAsync ? Else popguipage but not sure that works.

By the way, do not forget to test translations.

Looks like Windows CI does not like it.

Ah makes sense.

Any reason the renderer and the postproc manager would have different sizes ?

related https://github.com/0ad/0ad/pull/44

Probably related https://github.com/0ad/0ad/pull/44

Related ? https://trac.wildfiregames.com/ticket/5989

Dunno, could be a glitchy UI in some cases, the menu being available in SP while it shouldn't (or showing the wrong text) or for observers / defeated players which would be weird or could cause side effects

Well, can you break it? (Corrupted savegames, forged ones, spamming buttons, accessing it from somewhere you shouldn't) ? Possible bugs with AIs, rejoin check etc

Well I would assume this changes the generated assembly which could be for the worst compared to macros. But I suppose it could / should be profiled.

Dumb question, but doesn't that make the code slower?

Just curious, why bother with cmake? Wouldn't a posix shell script do the same?

Did the API break?

@phosit is there a convention for floats : 1.0f, 1.f, 1f ?

So what happens here exactly when it cannot find the shader file?

A better solution indeed would be to profile :)

Found it. https://irclogs.wildfiregames.com/%230ad-dev/2020-07-29-QuakeNet-%230ad-dev.log

The issue is that so far we don't have a reliable way to detect Vulkan support, as the detection itself can crash the game on some AMD GPUs. :)

That's my point. We don't have graceful stuff here and as long as it's not 60% stable we can't force users to use it :)

Maybe. Although errors do that, CTDs not really. The last five times I ran SVN it crashed because of Vulkan + Mod combo so I eventually gave up and went back to GL. Also worth noting Atlas doesn't support Vulkan and I guess @trompetin17 will not finish his patch to get rid of Atlas any time soon.

@sera if you do that you can't run the dev build without building shaders first... Which is really a pain

If you haven't already, I would read this wiki page https://trac.wildfiregames.com/wiki/Coding_Conventions This will save some time for the review by @vladislavbelov Unfortunately we don't have Clang format or an equivalent, so we have to enforce the coding style manually. Obvious things I see from a quick glance are braces that aren't on new lines, nested ifs instead of early returns etc.

Kib probably needs an include.

In D5214#222984, @marder wrote:

This doesn't catch _all_ the cases where var (or let) could be replaced, but at least I'm reasonably sure that it doesn't break anything as is.

So if no one disagrees, I would push this during the next weeks.

How about using ProjectionType from source/graphics
/Camera.h ?

Other than having proper tests for it and the notes don't think so.

That's fair. :)

Do you need it to be rectangular ?

Would be funny to shoot all targets, but with a ratio of arrows depending on preference. Probably needs some good UI.

Oh right my bad. So it's picking a list of like 20 targets, shoots as many arrows as possible on the favourite one until it goes missing (could be dead or out of range) then moves on to the next one.

In D4964#222612, @real_tabasco_sauce wrote:

actually hold on:

Case 4:

If you miss 12 and 45. at the end of the loop you do

targetIndex === 1;
targets.splice(0, targetIndex + 1); returns [12, 24] 12 is removed 24 is removed too but 45 is not (bad)

This is an impossible scenario tho. The only way 45 could be missed is if 24 was missed, since we are shooting them in order.
so splice(0, targetIndex) is fine after all.

I suppose the left part could go away, and the right be used since it's the same flipped and longer. Maybe we can cram other things in that texture?

If this is accepted, don't forget to delete the other files on the way out :)

Also I don't like pushing elements in a loop. In your case i'd do something like this:

Cleaned workspaces so macos build can run. It was broken after spidermonkey patch.

They are not matching naming conventions though should be _0X

Just to clarify @Lopess made the statue :) If it needs to be optimized that's another issue. I just made the pedestals for the CC and added the prop points.

Concerns there are fixed, new concerns are on the fix ^^

Concern fixed by reverting the commit.

Fixed as well.

Should be fixed now :)

You forgot to change https://trac.wildfiregames.com/browser/ps/trunk/libraries/source/fcollada/build.sh

The problem is that buildings don't have animations.

Hey, don't forget to upload patches with context and to set the repository, else the autobuild will never be triggered.

In case that helps recipient is also a word you can use.

In C# those would be 'sinks' there would be two file logger sinks with different levels of filter TRACE DEBUG INFO WARN ERROR FATAL and each sink would be responsible for how and what they should print.

Related D4979

Should test exceptions in Atlas (which are already buggy) possibly some flags like -dumpSchema and archiveBuilder to make sure everything is still logged.

I just created an account for them. For most pipelines, clicking the jenkins link that appears when the build fails or succeeds gives you access the pipeline.

There are some options https://milkv.io/ but I don't know which one was used.