Page MenuHomeWildfire Games
Feed Advanced Search

Today

Stan added inline comments to D4323: Display a tooltip for the health and capture points and fix the civ tooltip style..
Sun, Nov 27, 11:38 AM

Yesterday

Stan added a comment to D4830: Adds attachment load and store operations.

Not his fault something is wrong with premake

Sat, Nov 26, 3:30 PM

Thu, Nov 24

Stan added a comment to D4830: Adds attachment load and store operations.

Tested on GLES.
Can't test ARB (causes assertion)
Can't test high quality water (wrong qualifiers)
Normal water looks okay
Silhouettes seemed to work
MSAA FXAA and stuff don't seem to do anything there.

Thu, Nov 24, 9:54 PM
Stan added a comment to rP27244: Garrison Domestic Animals into the Corral to get a <ResourceTrickle> of Food..

Wiki Alpha26 => Gameplay.

Thu, Nov 24, 11:28 AM
Stan added a comment to D4738: Allow other root XML than `entity`..

Maybe cause you ran it without a template with a different root than entity?
Also not sure what happen if you run 0 A.D. with -dumpSchema which allows to validate templates ?
There a few template validator that rely on the relaxng file generated by that?

Thu, Nov 24, 11:26 AM
Stan added a comment to rP27241: Don't (mis)use technologies to differentiate elephants..

Maybe because of the order of templates?

Thu, Nov 24, 9:01 AM

Wed, Nov 23

Stan added inline comments to D4813: Additional default colors after D4811.
Wed, Nov 23, 4:48 PM
Stan added a comment to D3211: Add a script to download compile and install wxwidgets.

Oh, yeah indeed, nowadays I use another way. Could be fixed indeed.

Wed, Nov 23, 2:17 PM
Stan added a comment to D3211: Add a script to download compile and install wxwidgets.

Problem is in my case I have many VS versions, so I need to be specific.

Wed, Nov 23, 9:05 AM

Tue, Nov 22

Stan added inline comments to D4813: Additional default colors after D4811.
Tue, Nov 22, 9:16 PM
Stan added a comment to D4738: Allow other root XML than `entity`..

Probably have to teach checkrefs about it.

Tue, Nov 22, 8:28 PM
Stan added inline comments to D4813: Additional default colors after D4811.
Tue, Nov 22, 8:06 PM
Stan added a comment to D4813: Additional default colors after D4811.

Well that's my point it doesn't have to. The only constraint should be playerdefaults >= gaia + max num of players we can put an ensure for that would that allow me to commit it ?

Tue, Nov 22, 1:09 PM
Stan added a comment to D4813: Additional default colors after D4811.

Can you be more specific ? I can't think of case where it happens. max player count should always be 8 + gaia in all cases

Tue, Nov 22, 9:28 AM

Mon, Nov 21

Stan accepted D4813: Additional default colors after D4811.

Looks good to me might be split in two commits.

Mon, Nov 21, 11:15 PM
Stan added a comment to D4738: Allow other root XML than `entity`..

C# uses .First() or .FirstOrDefault() (former throws an exception if element is not found)

Mon, Nov 21, 5:08 PM
Stan updated the diff for D4753: Fix VS2022 build.

Correct patch, still will fail on VS2017

Mon, Nov 21, 1:31 PM
Stan added a comment to D4623: Fix quicksave not appearing in the menu.

Indeed failure is not linked to you. Touching glad usually breaks the CI sadly.

Mon, Nov 21, 11:38 AM

Sun, Nov 20

Stan added a comment to D4830: Adds attachment load and store operations.

Yeah that's what I meant :)

Sun, Nov 20, 7:01 PM
Stan added a comment to D4830: Adds attachment load and store operations.

May be nice to update glad headers with 2.02 to reduce diff size i think glad unused was added in there. No strong feeling

Sun, Nov 20, 6:40 PM

Tue, Nov 15

Stan added inline comments to D4827: Moves post processing out of scene rendering to avoid framebuffer pass duplicate.
Tue, Nov 15, 6:19 PM

Mon, Nov 14

Stan committed rP27227: Make infantry_spearman_b.xml consistent with other han spearmen..
Make infantry_spearman_b.xml consistent with other han spearmen.
Mon, Nov 14, 12:54 PM
Stan updated subscribers of D4730: Type-erased SharedState.

@Mercury thoughts on this?

Mon, Nov 14, 11:25 AM
Stan added a comment to D4802: Allow Music tracks to be ordered. .

Hey, sorry for the very delayed answer I was on holidays.

Mon, Nov 14, 11:23 AM

Sun, Nov 6

Stan added a comment to D4813: Additional default colors after D4811.

Could have an ENSURE that checks that player defaults contains at least 9 (8 + gaia) players.

Sun, Nov 6, 1:36 AM
Stan added a comment to D4813: Additional default colors after D4811.

I don't see how iterating from 1 to 8 like it's done everywhere in the code means a 6 months FF?

Sun, Nov 6, 1:01 AM
Stan added a comment to D4813: Additional default colors after D4811.

We could just use an extra check there or iterate players instead in another patch?
Just like the atlas preview it just reveals a bug that's been there for a while.

Sun, Nov 6, 12:34 AM
Stan added a comment to D4813: Additional default colors after D4811.

The patch allows to select "Player 9" and place an entity in Atlas which triggers an error.

You can already do that (just use numpad). Not linked to this. Would be worrysome if you could add up to 16 players. Which is not the case.

Sun, Nov 6, 12:11 AM
Stan added a comment to D4821: Allow to read groups from external file.

It is hard because animation variants contain tools props. You could restrict mesh and textures nodes but then you can't have bloodied corpses. Which you should override I suppose.

Sun, Nov 6, 12:08 AM

Sat, Nov 5

Stan added a comment to D4821: Allow to read groups from external file.

Indeed but we have checkrefs for that case :)

Sat, Nov 5, 11:14 PM
Stan added a comment to D4821: Allow to read groups from external file.

Well yeah kinda the point, you group things to update at the same time.

Sat, Nov 5, 9:48 PM
Stan added a comment to D4821: Allow to read groups from external file.

How does this make it easier to add more variation? If anything it reduces duplication and makes it easier to ensure consistency in actors. Also makes diff easier to review since less files get touched

Sat, Nov 5, 8:46 PM
Stan updated subscribers of D4821: Allow to read groups from external file.

That's an interesting patch. Don't forget the XML headers in the group files.

Sat, Nov 5, 6:30 PM

Oct 27 2022

Stan added a comment to D4758: Rearrange GC scheduling for reduced lag.

@Mercur, @wraitii maybe you should find a time to discuss this live, on irc, matriw discord or whatever. It seems that it might be more productive. What do you think

Oct 27 2022, 3:36 PM

Oct 24 2022

Stan added inline comments to D4803: Replace SharedStateResult with std::optional.
Oct 24 2022, 8:52 PM
Stan added a comment to D4803: Replace SharedStateResult with std::optional.

This looks clean, but I'm not sure if it has performance implications or anything thereof ? Does it change anything? Or are you just fixing my code now that we can presumably use std::optional because we upgraded Xcode since I wrote my code

Oct 24 2022, 7:05 PM
Stan committed rP27172: Allow to have more than 8 colors in the drop down..
Allow to have more than 8 colors in the drop down.
Oct 24 2022, 2:44 PM
Stan closed D4811: Allow players to choose from a bigger color list.
Oct 24 2022, 2:43 PM
Stan added a reviewer for D4812: Disallow conversion in Future return.: wraitii.
Oct 24 2022, 1:52 PM
Stan added a comment to D4775: Prevent echoing simulation commands back to their source client..

Seems to be the case indeed.

Oct 24 2022, 9:05 AM

Oct 23 2022

Stan added a comment to D4428: SM91 upgrade.

Patch.sh fix

Oct 23 2022, 9:00 PM
Stan committed rP27170: Remove redundant references to deleted .dtd files.
Remove redundant references to deleted .dtd files
Oct 23 2022, 7:07 PM
Stan closed D4748: Remove redundant references to deleted .dtd files.
Oct 23 2022, 7:07 PM
Stan reclaimed D4748: Remove redundant references to deleted .dtd files.
Oct 23 2022, 7:05 PM
Stan commandeered D4748: Remove redundant references to deleted .dtd files.
Oct 23 2022, 7:05 PM
Stan committed rP27169: Civ backgrounds for minimap.
Civ backgrounds for minimap
Oct 23 2022, 6:50 PM
Stan closed D4271: Civ backgrounds for minimap..
Oct 23 2022, 6:50 PM
Stan requested review of D4811: Allow players to choose from a bigger color list.
Oct 23 2022, 6:22 PM
Stan added a comment to D4802: Allow Music tracks to be ordered. .
In D4802#204816, @lyv wrote:

Is there any advantage of having an index attribute rather than relying on the order of definition? I guess it would allow having similarly named tracks grouped while not having them played like that, but is that worth the tradeoff? An attribute also makes it abundantly clear to someone not familiar with this code.

All indexes seem to follow the array index anyway, except one which I presume is a test case.

Oct 23 2022, 6:10 PM
Stan added inline comments to D4809: Moves Backend enum to backends.
Oct 23 2022, 4:07 PM
Stan updated subscribers of D4775: Prevent echoing simulation commands back to their source client..

Maybe you could fabricate a replay and use @mbusy network's savegame feature? Or just tweak the c++ code to do it for you. Wonder if it can be done through the RL interface.

Oct 23 2022, 12:56 AM

Oct 22 2022

Stan committed rP27163: Fix incorrect paths in LICENSE.txt and improve wording slightly..
Fix incorrect paths in LICENSE.txt and improve wording slightly.
Oct 22 2022, 8:29 PM
Stan closed D1664: Small LICENSE.txt cleanup.
Oct 22 2022, 8:29 PM
Stan updated subscribers of D1663: Display lobby bots differently in the lobby.

@lyv @Dunedan @user1 @defc0n this pretty nice what do you think?

Oct 22 2022, 8:15 PM
Stan edited reviewers for D1630: Add perlin noise generator., added: Restricted Owners Package; removed: FeXoR, Silier.
Oct 22 2022, 8:10 PM
Stan edited reviewers for D1635: Add DunePainter., added: Restricted Owners Package; removed: FeXoR.
Oct 22 2022, 8:08 PM
Stan requested changes to D4802: Allow Music tracks to be ordered. .

I think we should be a bit smarter than this. What your patch does is break the randomness because tracks are only shuffled once.

Oct 22 2022, 8:05 PM
Stan added a comment to D4808: Find a texture.

Ah right I didn't think about std::max for list. I suppose we have to parse the whole list anyway whether it's to sort it to be fast after, or to determine which element is the max. It would be nice to be able to stop after the first 3 has been detected though.

Oct 22 2022, 6:40 PM
Stan committed rP27161: Fix the issues with entvalidate.py.
Fix the issues with entvalidate.py
Oct 22 2022, 6:25 PM
Stan closed D4698: Fix entvalidate.py.
Oct 22 2022, 6:25 PM
Stan added a comment to D4802: Allow Music tracks to be ordered. .

Can you fix the lint warnings as well?

Oct 22 2022, 5:38 PM
Stan added a comment to D4808: Find a texture.

Maybe we could use a function where we pass CTexture::** to reduce duplication?

Oct 22 2022, 4:11 PM
Stan updated subscribers of D4775: Prevent echoing simulation commands back to their source client..

IIRC there are some broken network tests that have been disabled maybe you could use them to test after fixing them. Since you are on Linux you could also open two instances of the game to test what @elexis said.

Oct 22 2022, 10:10 AM

Oct 21 2022

Stan added a comment to D4775: Prevent echoing simulation commands back to their source client..

Missed a rebase maybe?

Oct 21 2022, 11:53 PM
Stan added a comment to D4758: Rearrange GC scheduling for reduced lag.

Still one step too low

Oct 21 2022, 11:50 PM
Stan added a comment to D4758: Rearrange GC scheduling for reduced lag.

Your patch was generated in source instead of root :)

Oct 21 2022, 9:01 AM

Oct 20 2022

Stan added a comment to D4053: Random Maps: Echo Valley & Echo Shores.

It's supposed to look artificial to be "balanced"

Oct 20 2022, 5:35 PM

Oct 19 2022

Stan added a comment to D4053: Random Maps: Echo Valley & Echo Shores.

@marder @lyv, up

Oct 19 2022, 9:13 AM

Oct 18 2022

Stan added a comment to D4805: Update PageStack on demand.

BTW looks like you broke the tests.
Is #5614 related to this?

Oct 18 2022, 11:35 AM

Oct 17 2022

Stan added inline comments to D4805: Update PageStack on demand.
Oct 17 2022, 11:25 PM
Stan added inline comments to D4764: vector of locale in L10n.
Oct 17 2022, 5:47 PM
Stan added inline comments to D4764: vector of locale in L10n.
Oct 17 2022, 4:59 PM
Stan committed rP27158: Fix 16-bit texture introduced in Phab:rP27155.
Fix 16-bit texture introduced in Phab:rP27155
Oct 17 2022, 2:47 PM
Stan accepted rP27114: [Alpha 27][Art][Textures][Portraits] Move unit portraits to civ-specific….
Oct 17 2022, 2:35 PM
Stan accepted rP27120: [Alpha 27][Atlas] New Obstructor objects for Atlas..
Oct 17 2022, 2:35 PM
Stan added inline comments to D4425: Use the threadpool for texture conversion.
Oct 17 2022, 2:30 PM

Oct 16 2022

Stan requested changes to D4428: SM91 upgrade.

Doesn't build for me.

Oct 16 2022, 7:22 PM
Stan added a comment to D4804: Fix invisible text in Atlas with dark theme.

Hey thanks for the patch. Any idea why it was there in the first place? Maybe it prevents the background from being the same color as the rest aka gray?

Oct 16 2022, 5:18 PM
Stan added a comment to D3877: ThreadPool extension -> Timer for recurrent task & adapt netClient..

Might notice it on the very slow hardware running the game.

Oct 16 2022, 12:31 PM

Oct 15 2022

Stan added inline comments to D4798: Rewrite shore wave vertex creation.
Oct 15 2022, 11:12 AM
Stan added a member for Contributors: Neinea.
Oct 15 2022, 10:13 AM
Stan added a reviewer for D4802: Allow Music tracks to be ordered. : Stan.
Oct 15 2022, 10:12 AM
Stan updated subscribers of D4802: Allow Music tracks to be ordered. .

Hey thanks for the patch. @Samulis might have info about the actual order we need but it can be done at a later date.

Oct 15 2022, 9:59 AM

Oct 14 2022

Stan added a comment to D4801: Fix NVTT build on MCST Elbrus 2000 (e2k).

Can you ask Fatton how he'd like to be credited ?

Oct 14 2022, 10:14 AM
Stan added reviewers for D4798: Rewrite shore wave vertex creation: vladislavbelov, wraitii.
Oct 14 2022, 2:16 AM

Oct 13 2022

Stan added inline comments to D4271: Civ backgrounds for minimap..
Oct 13 2022, 8:50 AM
Stan added inline comments to D4271: Civ backgrounds for minimap..
Oct 13 2022, 7:52 AM
Stan added inline comments to D4271: Civ backgrounds for minimap..
Oct 13 2022, 7:26 AM

Oct 11 2022

Stan updated subscribers of D4271: Civ backgrounds for minimap..

@marder @Freagarach thoughts on this?

Oct 11 2022, 6:26 PM
Stan added a comment to D4791: remove the remnants of the rice resource.

Not sure why you need to remove the variant from the actors but not the actual variant?

Oct 11 2022, 10:09 AM

Oct 8 2022

Stan added inline comments to D4796: Reduces uniform size for Canvas2D shader.
Oct 8 2022, 2:20 PM
Stan added inline comments to D4796: Reduces uniform size for Canvas2D shader.
Oct 8 2022, 1:59 PM
Stan added a comment to D4796: Reduces uniform size for Canvas2D shader.

Shouldn't the description be use vec4 + vec2 instead of mat2?

Oct 8 2022, 1:39 PM

Oct 7 2022

Stan added inline comments to D4739: Return terrain reference from CWorld.
Oct 7 2022, 4:42 PM
Stan committed rP27129: Fix notes in rP27128.
Fix notes in rP27128
Oct 7 2022, 2:39 PM
Stan committed rP27128: Update ifdef condition for MCST-LCC compiler (E2K).
Update ifdef condition for MCST-LCC compiler (E2K)
Oct 7 2022, 9:45 AM
Stan closed D4795: source/lib/sysdep/compiler.h: Updated ifdef condition for MCST-LCC compiler.
Oct 7 2022, 9:45 AM
Stan accepted D4795: source/lib/sysdep/compiler.h: Updated ifdef condition for MCST-LCC compiler.
Oct 7 2022, 9:42 AM

Oct 5 2022

Stan updated the diff for D4271: Civ backgrounds for minimap..

Simplify patch. Fix background.

Oct 5 2022, 12:51 PM
Stan reclaimed D4329: Copy/Open button for file path in replay window.
Oct 5 2022, 12:01 PM