Page MenuHomeWildfire Games
Feed Advanced Search

Yesterday

nani awarded D1707: Hard-counter tooltips a Evil Spooky Haunted Tree token.
Mon, Jul 15, 2:39 PM

Mon, Jul 1

Stan added inline comments to D2013: Fix incorrect use of setlocale() in cppformat CStr tests.
Mon, Jul 1, 10:42 PM
Stan added inline comments to D1992: UnitMotion - more explicit handling of target death in Combat.Approaching.
Mon, Jul 1, 7:45 PM
Stan added inline comments to D1992: UnitMotion - more explicit handling of target death in Combat.Approaching.
Mon, Jul 1, 7:42 PM
Stan added a comment to D2026: Make Promotion.js use the common Transform helper.

Would be nice to have a test maybe ?

Mon, Jul 1, 1:24 PM
Stan added inline comments to D1396: Remove not needed checks and code for VS2015 [VS2013 -> VS2015].
Mon, Jul 1, 9:54 AM
Stan added inline comments to D1396: Remove not needed checks and code for VS2015 [VS2013 -> VS2015].
Mon, Jul 1, 9:35 AM

Sun, Jun 30

Stan added inline comments to D2029: Fix for rP22314 - call IdleTask in Atlas and swap buffers only once.
Sun, Jun 30, 7:39 PM
Stan added a comment to D1337: Formation animation refactor.

Still missing the XML headers in variants.

Sun, Jun 30, 7:29 PM
Stan added inline comments to D2028: Check for "cmpHealth" in the "TakeDamage" function in "Armour.js"..
Sun, Jun 30, 11:27 AM
Stan added inline comments to D2014: Remove "delta" from "UnitAI's" "FaceTowardsTarget"..
Sun, Jun 30, 11:24 AM
Stan added a comment to D1955: Support "phenotype"-tag in VisualActor..

You might want to look at Vulkan's warnings as well. I wish he would write inlines but that might be messy.

Sun, Jun 30, 10:36 AM
Stan added inline comments to D2028: Check for "cmpHealth" in the "TakeDamage" function in "Armour.js"..
Sun, Jun 30, 10:22 AM

Sat, Jun 29

Stan updated subscribers of rP22096: Improve and fix checkrefs.pl, add a readme for usage, add mod support, add….

I wanted to write something to detect which maps where using textures but I don't know how to parse the pmp binary with python to figure out

  1. Which texture is used the most
  2. How to replace it
Sat, Jun 29, 11:20 PM
Stan added a comment to rP22314: Fix a crash on some system when Alt-tabbing during game setup..

Was anybody else able to reproduce ?

Sat, Jun 29, 5:16 PM
Stan accepted rP22348: Delete old redistributables for VS 2010, and add new ones for VS 2015. Refs….

Now fixed :)

Sat, Jun 29, 5:13 PM
Stan added a comment to D2024: Avoid VertexPathfinder pointer in rP22253.

Might be interesting : https://stackoverflow.com/questions/49475680/c-conventions-regarding-passing-objects-pointer-vs-reference
https://stackoverflow.com/questions/22146094/why-should-i-use-a-pointer-rather-than-the-object-itself

Sat, Jun 29, 3:04 PM
Stan awarded D2021: Fix AtlasUI.dll windows autobuild a Like token.
Sat, Jun 29, 12:41 PM
Stan added inline comments to D1938: Easier introduction of new damage types..
Sat, Jun 29, 12:04 PM
Stan added inline comments to D1973: Enable support for friendly fire for normal ranged attacks..
Sat, Jun 29, 11:35 AM

Thu, Jun 27

Stan added inline comments to D2019: [ATLASUI] Main Thread Checker: UI API called on a background thread: -[NSView initWithFrame:].
Thu, Jun 27, 7:45 PM
Stan planned changes to D1718: Decay/regenerate option for resources when not being gathered from.

Well given the current state of things and the impact it has on me, I guess this won't happen soonish. Maybe I'll get to do it for A24 but I'm not sure anymore. 47th revision (192 comments)

Thu, Jun 27, 2:48 PM
Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.

Means rewriting the whole patch, but okay I guess...

Thu, Jun 27, 12:24 PM
Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.
In D1718#84092, @Nescio wrote:

Alive and dead is equal to not having them at all.

Isn't that confusing?

Thu, Jun 27, 11:59 AM
Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.
In D1718#84090, @Nescio wrote:

Alive + Dead + Notbeinggathered only works when not being gathered.

Why? Surely something can't be alive and dead simultaneously? (No Schrödinger's cat in 0 A.D.)

Thu, Jun 27, 11:33 AM
Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.
In D1718#84088, @Nescio wrote:

Thanks, that's helpful.
Alive and Dead are clear for fauna (fatten when living, decay when killed), but not really for gaia templates (is a tree considered alive or dead?).

Thu, Jun 27, 11:17 AM
Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.

Well it might change again before it's committed but currently you can do something like

Thu, Jun 27, 11:02 AM
Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.

@Stan I haven't really looked deep into your patch, so perhaps, yes. I don't consider what I've said above a review.

Thu, Jun 27, 10:37 AM
Stan added a comment to D1718: Decay/regenerate option for resources when not being gathered from.

@wraitii Anything else you want me to change aside from the warning in Jenkins console ?

Thu, Jun 27, 10:24 AM
Stan added a comment to D2018: Fix IsInjured call to mirages.

Well in tests you could check that Mirages have all the health keys that are functions ?

Thu, Jun 27, 8:50 AM

Wed, Jun 26

Stan added a comment to D2012: Refactors Camera projections.

Test passed on windows :)

Wed, Jun 26, 8:11 PM
Stan added a comment to D2011: Removes unused LightingModel.

Just tested, seems to work as expected on windows (vs2015)

Wed, Jun 26, 8:03 PM
Stan added a comment to D2012: Refactors Camera projections.

Tested it on windows. Noticed no apparent glitches, nor errors, rotated camera zoomed in and out, and did both at the same time. Parallax look the same.

Wed, Jun 26, 8:00 PM
Stan added a comment to D1971: Support attack-ground for ranged units..
  • Reverted FaceTowardsTarget change. (In favour of D2014.)
  • Allow 0 radius in bombard-area.
Wed, Jun 26, 11:43 AM
elexis awarded rP22383: New bushes, trees (Oaks, firs, Birch) by Big Tiger, as well as new cliffs, and… a Like token.
Wed, Jun 26, 3:26 AM

Tue, Jun 25

Stan requested verification of rP22386: 3 New temperate maps by BigTiger..
Tue, Jun 25, 11:08 PM
Stan committed rP22400: Add the new keyword for BigTiger's maps..
Add the new keyword for BigTiger's maps.
Tue, Jun 25, 11:08 PM
Stan accepted D1935: Anatolian → Lydian; correct Persian specific names.

I will commit it when I have some time. Likely after fixing the the two concerns raised on my commits, and or maybe the unit fix.

Tue, Jun 25, 8:22 PM
Stan added a comment to rP21026: Cleanup TileClass prototype and use vector arguments for countInRadius….

Let's do better than this: D2010.

Tue, Jun 25, 6:10 PM
Stan created D2010: Replace an incorrect math.max() by math.min() in tileclass.
Tue, Jun 25, 6:09 PM
Stan added inline comments to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..
Tue, Jun 25, 5:01 PM
Stan added a comment to D1995: Fix missing "Damage"-node in examples..

Can I submit this myself? If so, would the action "Close Revision" do that?

Tue, Jun 25, 4:50 PM
Stan added inline comments to rP22346: Allow techs to affect unit counters stats..
Tue, Jun 25, 4:40 PM
Stan added a comment to rP22346: Allow techs to affect unit counters stats..
In rP22346#34393, @Stan wrote:

Shall I make another diff then ?

We can't know that without knowing the answer to the question when the TODO case can be triggered.

Tue, Jun 25, 4:19 PM
Stan added a comment to D1932: Update to premake Alpha 14.

It would seem they added support for Microsoft Visual Studio 2019.
As of today, still haven't updated the CHANGES.txt file.

Tue, Jun 25, 4:18 PM
Stan added inline comments to D1935: Anatolian → Lydian; correct Persian specific names.
Tue, Jun 25, 4:14 PM
Stan added a comment to rP22346: Allow techs to affect unit counters stats..

Shall I make another diff then ?

Tue, Jun 25, 4:04 PM
Stan updated subscribers of rP22397: #5445.

Usually one can write Fixes #5445 to automatically close tickets.
@Itms, we now need a AtlasUI autobuild for windows, not sure that's automatic yet.

Tue, Jun 25, 8:56 AM
Stan added a comment to rP22314: Fix a crash on some system when Alt-tabbing during game setup..

Sorry, should have been more specific.

Tue, Jun 25, 8:52 AM
Stan added a comment to rP22386: 3 New temperate maps by BigTiger..

Yeah I was waiting for something like D2009 which I would have done myself if someone hadn't come to the rescue. Will add the keyword soon.

Tue, Jun 25, 8:50 AM
Stan added a comment to rP22323: Further cleanup of MikkTSpace.

Pass pointers instead of arrays

How are arrays passed?

Tue, Jun 25, 8:49 AM

Mon, Jun 24

Stan added a comment to D1971: Support attack-ground for ranged units..

If you have some time, maybe it would be nice to have a small video on youtube demonstrating the feature. Nothing fancy.

Mon, Jun 24, 8:57 PM
Stan added a comment to D1337: Formation animation refactor.

Rebased - needs some cleaning, like the anti-cavalry formation no longer has a walk animation which is annoying - I guess I should group the animations better. The limit of one variant per file is quite annoying because it means one must change a lot of files every time -_-
Still would work with D1901

Mon, Jun 24, 8:00 PM
Stan added inline comments to D1969: Adapt unitMotion to edge-edge distance checks.
Mon, Jun 24, 6:28 PM
Stan added inline comments to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..
Mon, Jun 24, 5:56 PM
Stan added a comment to D1971: Support attack-ground for ranged units..

Well it's up to wraitii to review those, so I guess up to him then.

Mon, Jun 24, 5:39 PM
Stan added a comment to rP22295: Target build version explicitly for Xcode.

Reviewed By: Wraitii

Reviewed By is reserved for people other than the author.
Comments By: Itms can be added when people influenced the patch without having accepting it.

Mon, Jun 24, 4:33 PM
Stan added a comment to rP22266: moves territory_pull.xml from other/ to special/ and updates the only file in….

No notes.
That these templates shall not appear in the list of placeable templates may be true, but there are also the generic templates that should not appear in that list.
Also that a template shall not appear to be placeable doesn't mean that it is impossible to place it if it would appear in the list.
Hence unplaceable/ would also be imperfect.
Another possibility would be hidden/, but that also is ambiguous. Everything is ambiguous.
Perhaps unplaceable/ and a README.txt defining unplaceable/ as not appearing in the Atlas list of entities would be the solution that satisfies all problems (including the clarification that a template that may technically be placed may be contained in that folder).

Mon, Jun 24, 4:30 PM

Sun, Jun 23

Stan added a comment to rP22266: moves territory_pull.xml from other/ to special/ and updates the only file in….

@elexis did you get the notes ? :)

Sun, Jun 23, 9:27 PM
Stan added inline comments to D1971: Support attack-ground for ranged units..
Sun, Jun 23, 8:31 PM
Stan updated the diff for D825: Atlas: Allow map to recenter during resize.

Try to fix the build on Linux

Sun, Jun 23, 6:01 PM
Stan added inline comments to D1971: Support attack-ground for ranged units..
Sun, Jun 23, 5:31 PM
Stan added inline comments to rP22241: Add a map to be able to test which foundation fits best an actor..
Sun, Jun 23, 2:44 PM
Stan added a comment to rP22151: New berry bushes by BigTiger.

Maybe ?

Sun, Jun 23, 12:46 PM
Stan added a comment to rP22151: New berry bushes by BigTiger.

The hue is slightly different.

Sun, Jun 23, 10:48 AM

Sat, Jun 22

Stan requested verification of rP22151: New berry bushes by BigTiger.
Sat, Jun 22, 11:26 PM
Stan committed rP22394: Remove two duplicate textures and models. They were incorrectly added in….
Remove two duplicate textures and models. They were incorrectly added in…
Sat, Jun 22, 10:54 PM
Stan updated the diff for D825: Atlas: Allow map to recenter during resize.
  • Whitespace
  • Static_cast
  • spaces to tabs
  • rebase
Sat, Jun 22, 2:40 PM
Stan commandeered D825: Atlas: Allow map to recenter during resize.

Commandeering to rebase @Clockwork-Muse feel free to commandeer back if you want to continue working on it.

Sat, Jun 22, 2:40 PM
Stan added inline comments to D1971: Support attack-ground for ranged units..
Sat, Jun 22, 12:06 PM

Fri, Jun 21

Stan added a comment to D1971: Support attack-ground for ranged units..

That sounds good and maybe actually better than being that precise though the shape should differ depending on the type of attacker. However I beleive that the spread parameter is made for that. One could use that to compute the circle.

Fri, Jun 21, 6:49 PM
elexis awarded rP21965: New Persian Farsi voices by dMZeroCold & dMAthena. a Like token.
Fri, Jun 21, 1:39 PM

Thu, Jun 20

Stan added a comment to D1971: Support attack-ground for ranged units..
Thu, Jun 20, 10:32 PM
Stan added inline comments to D1971: Support attack-ground for ranged units..
Thu, Jun 20, 9:12 PM
Stan added inline comments to D1971: Support attack-ground for ranged units..
Thu, Jun 20, 5:59 PM
Stan added a comment to D1954: Do not send Reflection and Refraction matrices to shader when not needed.

@wraitii Thoughts on this ?

Thu, Jun 20, 3:45 PM
Stan added a reviewer for D1943: UnitAI fix return value on "enter" according to FSM logic: wraitii.
Thu, Jun 20, 3:44 PM
Stan added a reviewer for D1396: Remove not needed checks and code for VS2015 [VS2013 -> VS2015]: vladislavbelov.
Thu, Jun 20, 3:43 PM
D1670: Remove references to globals now requires review to proceed.

I think it would be nice to have this.

Thu, Jun 20, 3:42 PM
Stan added a reviewer for D1604: Make capturing optional: Restricted Owners Package.

@wraitii @Freagarach.

Thu, Jun 20, 3:40 PM
Stan added a comment to D1483: Use Homebrew to fetch OSX libraries instead of compiling them all.

Well maybe you guys could try to use my conan patch ? You will need to change the copy to osx instead of win32 and likely edit premake libs.

Thu, Jun 20, 8:55 AM
Stan abandoned D1691: Remove boost "system" from Mac OS build system..

I'm abandoning this :) It probably can be reopened when we actually remove these references.

Thu, Jun 20, 8:52 AM
Stan raised a concern with rP22352: Unit Motion - wrap target state into a struct.

Raising concern for a warning reported by @Krinkle. No biggie but the entity parameter isn't used anymore.

Thu, Jun 20, 8:50 AM
Stan added a comment to D1691: Remove boost "system" from Mac OS build system..

Yeah I don't think that will work ever. I'm not sure where @fabio saw that it could be removed.

Thu, Jun 20, 8:28 AM
Stan added a comment to D1993: petra: Fix all ESLint and JSHint warnings.

Maybe you can fix the last two warning (trailing dots)

Thu, Jun 20, 12:06 AM

Wed, Jun 19

Stan added a comment to D1993: petra: Fix all ESLint and JSHint warnings.

The auto fix failed I guess.

Wed, Jun 19, 11:18 PM
Stan added inline comments to D1971: Support attack-ground for ranged units..
Wed, Jun 19, 9:44 PM
Stan updated subscribers of D1993: petra: Fix all ESLint and JSHint warnings.
In D1993#83293, @Stan wrote:

Before this get committed you might as well want to fix the warnings that appeared in the Vulkan console.

The only remaining one should be for curly. Due to there being almost 50/50 adherence to that, I wasn't sure whether it is a style we still want to follow consistently or whether it might be something we want to disable and allow developer to choose on case-by-case basis whether curly braces are useful.

Wed, Jun 19, 9:38 PM
Stan added a comment to D1993: petra: Fix all ESLint and JSHint warnings.

Hoping to see this land relatively soon to avoid merge conflicts, after that I'll move on to the next area to lint :)

Wed, Jun 19, 6:20 PM
Stan added inline comments to D1971: Support attack-ground for ranged units..
Wed, Jun 19, 5:31 PM
Stan added a comment to D1950: Create "Damage"-container for damage types in templates..
In D1950#83214, @Nescio wrote:

Ideally different projectiles would also be able to have different damage, therefore what is eventually desirable is support for multiple ranged attacks, e.g. a fortress able to fire both arrows (long range, low damage) and javelins (shorter range, higher damage).

Wed, Jun 19, 11:34 AM
Stan added inline comments to D1971: Support attack-ground for ranged units..
Wed, Jun 19, 10:21 AM
Stan added a comment to D2000: aura style corrections.

Most of the time Anything between {} is part of an object. anything between [] is part of an array

Wed, Jun 19, 12:23 AM

Tue, Jun 18

Stan added inline comments to D2001: [AI] Small cleanup in defenseManager.
Tue, Jun 18, 10:03 PM
Stan added inline comments to D1938: Easier introduction of new damage types..
Tue, Jun 18, 10:00 PM
Stan added a comment to D1938: Easier introduction of new damage types..

Well if you can fix the ai that's nice.

Tue, Jun 18, 7:14 PM
Stan added inline comments to D1938: Easier introduction of new damage types..
Tue, Jun 18, 6:35 PM
Stan added inline comments to D1938: Easier introduction of new damage types..
Tue, Jun 18, 3:14 PM
Stan added inline comments to D2000: aura style corrections.
Tue, Jun 18, 3:12 PM
Stan committed rP22389: Fix a little glitch on the Athenian storehouse..
Fix a little glitch on the Athenian storehouse.
Tue, Jun 18, 2:15 PM