Build failure - The Moirai have given mortals hearts that can endure.
Active Repositories
- 12 Commits
- ·
- Restricted Project
- May 21 2019, 9:38 PM
- Git
Recent Activity
Today
Successful build - Chance fights ever on the side of the prudent.
In D5256#223941, @Vantha wrote:Elexis advises, "the (binaries/data/mods/public/simulation/data/settings/player_defaults.json) file might contain a name that is also shared by the civ json file, then it would bug. So it should only look for the names in slot 0 to i - 1, not all slots."
What do you mean with this?
Yesterday
Build failure - The Moirai have given mortals hearts that can endure.
Build failure - The Moirai have given mortals hearts that can endure.
Build is unstable, some tests have failed - The Moirai have given mortals hearts that can endure.
Rename back to PushGuiPage
include precompiled.h
In D3807#223896, @phosit wrote:RunGuiPage isn't the best name.
- elexis recomended to stay with PushGuiPage.
Careful if you make a new file, you need to tell Transifex to pull it.
Store extracted messages from gamesettings in a new output file, public-gamesettings.pot.
Wed, Apr 24
Build failure - The Moirai have given mortals hearts that can endure.
Successful build - Chance fights ever on the side of the prudent.
I addressed most of the suggestions.
In D5256#223912, @Vantha wrote:Ok, updated the diff. Is this how you wanted the comments?
Build failure - The Moirai have given mortals hearts that can endure.
Successful build - Chance fights ever on the side of the prudent.
Ok, updated the diff. Is this how you wanted the comments?
When you await (asyncronously wait) for the promise to settle you essentially enqueue the rest of the async function as a continuation. The function (with or without the await) doesn't block (untill the child page finishes) the engine or the thread or...
Only because you await it no? If you didn't it would not block therefore the method itself is async? Or am I missing something
Tue, Apr 23
By asyncronous i mean it doesn't block untill the child page is closed.
It blocks untill the child page is pushed. So that part is syncrosous.
If you return a promise then it is ?
That looks good indeen. I'll have to test.