Home

Can't find any atlas bugs atm since I'm always running into #4657.

[Windows] Automated build.

Executing section Default...
Executing section Source...
Executing section JS...

<elexis> Stan`: I think your color patch is ready if you do the update only on init and ownership change
<elexis> iirc I had posted a question there
<elexis> (the question must have been whether there were any other wrong-color bugs other than changing the civ in atlas)

Done.

If a building is captured or destroyed, ejected units will try to find a new building to garrison inside.

That may not be a good thing. I often will set a rally point for a building before it's destroyed, so that the units inside will run away to the desired location when the building is destroyed.

Just quickly tested one thing:
garrison some dudes in a tower, then later raised alert and ended it again: my dudes also were ungarrisoned.
I don't think this is a good behaviour, because when I put my soldiers into a tower and let's say 20 mins later raise and end an alert, I want them stay in the tower.

(should come after D403 ideally)

In D636#26922, @echotangoecho wrote:

Seems to work well on linux, but can't test on windows atm, as my windows install is currently broken...

patch is good, and testing on a naval ai game, it gives the same hash value.

Petra: use moveToRange() instead of move() in some cases

Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...

(Also there is an unused CTerritoryManager member var (another non-existent class) in CWorld with a corresponding getter, a relic of the old simulation (before the big rewrite that replaced it with simulation2).)

iconv: not sure where that is used

By tinygettext and possibly by icu itself.

Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...

Executing section Default...
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (no-undef-init):
|    | It's not necessary to initialize 'g_GameStanzaTimer' to undefined.
|----|    | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/gamesetup/gamesetup.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/gamesetup/gamesetup.js
| 318| 318| /**
| 319| 319|  * Index of the GUI timer.
| 320| 320|  */
| 321|    |-var g_GameStanzaTimer = undefined;
|    | 321|+var g_GameStanzaTimer;
| 322| 322| 
| 323| 323| /**
| 324| 324|  * Only send a lobby update if something actually changed.
|    | [NORMAL] ESLintBear (no-undef-init):
|    | It's not necessary to initialize 'yPos' to undefined.
|----|    | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/gamesetup/gamesetup.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/gamesetup/gamesetup.js
|1144|1144| 
|1145|1145| function verticallyDistributeGUIObjects(parent, objectHeight, ignore)
|1146|1146| {
|1147|    |-	let yPos = undefined;
|    |1147|+	let yPos;
|1148|1148| 
|1149|1149| 	let parentObject = Engine.GetGUIObjectByName(parent);
|1150|1150| 	for (let child of parentObject.children)

Executing section Default...
Executing section Source...
Executing section JS...

Properly apply texture to the last quad of an overlay textured line. Reviewed…

Remove a useless value cap in Foundation code. Reviewed by wraitii.

Active Repositories

Recent Activity

Today

Yesterday