Today

elexis committed rP21356: Change createPassage function from rP20410 to optionally consume a Constraint….
Change createPassage function from rP20410 to optionally consume a Constraint…
Sat, Feb 24, 5:01 PM
Angen added a comment to D1291: Put diplomacy colors in options.

Save button is popping error.

Sat, Feb 24, 4:21 PM
Grugnas updated the diff for D988: Tweak melee cavalry and infantry max range.

athen_infantry_spearman_b.xml now correctly inherit max range from template_unit_infantry_melee_spearman.xml instead of having own MaxRange entry.

Sat, Feb 24, 3:53 PM
Angen accepted D1327: Remove SelectAnimation from MoveStarted and MoveCompleted.
Sat, Feb 24, 3:38 PM
mimo added a comment to rP21348: Decrease a bit the clearance of fishing ships (from 4 to 3)..

I agree the square does not fit for ships, and having only one class for both fishing ships and merchant ships does not help.
But both kind of ships needs to go back very often to the docks, and with the maps we have, there are frequent jams near the docks. This change should help in that aspect, and the visual effect still looks acceptable to me.

Sat, Feb 24, 3:36 PM
Grugnas added a comment to D988: Tweak melee cavalry and infantry max range.
In D988#54458, @Nescio wrote:

Out of curiosity, how have you chosen these specific ranges? E.g. why 3.5 and not 3 or 4?

Sat, Feb 24, 3:28 PM
mimo added a comment to D1331: Improve selection performance by adding a GetBasicEntityState function.

Before going back to such a separation (which improved performance, but revealed itself hard to maintain in the long term), it would be good to know exactly where is the real gain: is it because we have less info to transfer? or because we have less info to compute?
If the latter is dominant, it may be more efficient to cache all these attack/armour infos instead of recomputing them every turn (applyValuesModifications is not specially fast) as is done for example in ResourceGatherer for the rates inside OnValueModification (note that this could be done better in ResourceGatherer as everything is recomputed with any change). Doing it that way could also help when fighting as also the simulation would not have to recompute all quantities each time.

Sat, Feb 24, 3:27 PM
Grugnas planned changes to D988: Tweak melee cavalry and infantry max range.
In D988#54449, @temple wrote:

Can you update the patch to just the range changes?
Did you test with large armies? Did the battles have different outcomes (i.e. do we need to rebalance attack stats too)?

Sat, Feb 24, 3:23 PM
Nescio added a comment to D988: Tweak melee cavalry and infantry max range.

Out of curiosity, how have you chosen these specific ranges? E.g. why 3.5 and not 3 or 4?

Sat, Feb 24, 3:21 PM
Nescio added a comment to D989: template organization: treasures, ruins, and the plane (1/5).

If you have more template rename patches, tell us which files should be renamed, so that we don't have to trust or proofread the changes.

Sat, Feb 24, 3:19 PM
elexis awarded D988: Tweak melee cavalry and infantry max range a Like token.
Sat, Feb 24, 3:18 PM
Angen added a comment to D1327: Remove SelectAnimation from MoveStarted and MoveCompleted.

Looks like formations like phalanx and syntagma are missing walking animations even without this patch, so currently it does not looks like this patch breaks something.

Sat, Feb 24, 3:16 PM
Grugnas updated the diff for D988: Tweak melee cavalry and infantry max range.
Sat, Feb 24, 3:15 PM
temple committed rP21355: Double negate state.garrisonHolder.
Double negate state.garrisonHolder
Sat, Feb 24, 3:13 PM
temple closed D1326: Double negate state.garrisonHolder.
Sat, Feb 24, 3:13 PM
temple added a comment to D988: Tweak melee cavalry and infantry max range.

Can you update the patch to just the range changes?
Did you test with large armies? Did the battles have different outcomes (i.e. do we need to rebalance attack stats too)?

Sat, Feb 24, 3:09 PM
elexis added a comment to rP21348: Decrease a bit the clearance of fishing ships (from 4 to 3)..

(We have many screenshots about these side effects in D253 and also the whale obstruction removal patch and agreed to favor gameplay over the visual aspect. Also chariots still overlap much more.)

Sat, Feb 24, 3:06 PM
temple added a comment to D1303: Fix UnitAI Handling of Formation idle animations.
In D1303#54353, @Stan wrote:

Should I close it then ?

Sat, Feb 24, 3:04 PM
temple added a comment to rP21348: Decrease a bit the clearance of fishing ships (from 4 to 3)..
binaries/data/mods/public/simulation/templates$ grep ship-small * -R
gaia/fauna_shark.xml:    <PassabilityClass>ship-small</PassabilityClass>
template_unit_fauna_hunt_whale.xml:    <PassabilityClass>ship-small</PassabilityClass>
template_unit_mechanical_ship_fire.xml:    <PassabilityClass>ship-small</PassabilityClass>
template_unit_mechanical_ship_fishing.xml:    <PassabilityClass>ship-small</PassabilityClass>
template_unit_mechanical_ship_merchant.xml:    <PassabilityClass>ship-small</PassabilityClass>

Old:


New:

Problem is ships are long and obstructions are square, so without huge changes to the pathfinder, what can you do? So, meh.

Sat, Feb 24, 3:03 PM
echotangoecho created D1331: Improve selection performance by adding a GetBasicEntityState function.
Sat, Feb 24, 2:27 PM
Angen added a comment to D1307: Reset formation animations after leaving walking state.

Ok, seams to be fixed.

Sat, Feb 24, 2:25 PM
elexis added a comment to rP21338: Use a macro for creating checkboxes in the Atlas map panel (other panels code….

Also, the nomad checkbox seems absent.

Sat, Feb 24, 2:22 PM
elexis committed rP21354: Elephantine map description by Sundiata, refs #5040..
Elephantine map description by Sundiata, refs #5040.
Sat, Feb 24, 1:56 PM
elexis committed rP21353: Maximize civ selection dropdown size in the gamesetup, i.e increase the size by….
Maximize civ selection dropdown size in the gamesetup, i.e increase the size by…
Sat, Feb 24, 1:20 PM
Vulcan added a comment to D1330: decrease a bit the clearance of fishing ships..

Successful build - Chance fights ever on the side of the prudent.

Sat, Feb 24, 1:16 PM
Vulcan added a comment to D1329: small floating debris should not block ship movement.

Successful build - Chance fights ever on the side of the prudent.

Sat, Feb 24, 1:13 PM
Stan committed rP21352: Add a snow particles for mapmakers.
Add a snow particles for mapmakers
Sat, Feb 24, 12:50 PM
mimo accepted D1326: Double negate state.garrisonHolder.

Thanks for the fix

Sat, Feb 24, 12:03 PM
Stan committed rP21351: Fix Iber champ not using fire javelins anymore.
Fix Iber champ not using fire javelins anymore
Sat, Feb 24, 12:03 PM
Stan committed rP21350: Fix Ptol, Cart, and Pers traders not having animations..
Fix Ptol, Cart, and Pers traders not having animations.
Sat, Feb 24, 12:00 PM
mimo committed rP21349: Small floating debris should not block ship movement..
Small floating debris should not block ship movement.
Sat, Feb 24, 11:52 AM
mimo closed D1329: small floating debris should not block ship movement.
Sat, Feb 24, 11:52 AM
mimo committed rP21348: Decrease a bit the clearance of fishing ships (from 4 to 3)..
Decrease a bit the clearance of fishing ships (from 4 to 3).
Sat, Feb 24, 11:49 AM
mimo closed D1330: decrease a bit the clearance of fishing ships..
Sat, Feb 24, 11:48 AM
Stan committed rP21347: Fix some templates errors introduced by the recent camel renaming..
Fix some templates errors introduced by the recent camel renaming.
Sat, Feb 24, 11:48 AM
mimo added a comment to D1329: small floating debris should not block ship movement.
In D1329#54403, @elexis wrote:

Those are only 3 barrels, very small, so overlapping of the models isn't really noticeable.

Sat, Feb 24, 11:46 AM
mimo committed rP21346: petra: fix oversight in rP21299.
petra: fix oversight in rP21299
Sat, Feb 24, 11:42 AM
elexis accepted D1330: decrease a bit the clearance of fishing ships..

Sure.
It should have been addressed in rP19365.
Should be complete now as all pathfinder.xml clearances were touched or left alone consciously.

Sat, Feb 24, 11:41 AM
mimo created D1330: decrease a bit the clearance of fishing ships..
Sat, Feb 24, 11:38 AM
elexis accepted D1329: small floating debris should not block ship movement.

Those are only 3 barrels, very small, so overlapping of the models isn't really noticeable.

Sat, Feb 24, 11:36 AM