After reading the comments, I don't really understand what I should do next, if anything. Sounds like you want to fix this with another method, and need to discuss the best approach? I know it's low priority but just thought I'd touch base in case there's anything else I could do with it at the present time.

The configuration entry and the options UI entry proposed were meant to be used for players that play with the vanilla 0ad code.

I tested this patch and added my results to the ticket.

Some things I found out after searching around https://curl.haxx.se/libcurl/c/ .
I'm not sure I understood it correctly or not. So, inline comments maybe wrong.
But if they are true, an alternative (maybe hacky) solution would be to send a status check request before the actual request.

In D1608#64376, @elexis wrote:

To test if D1600 actually works, I was wondering if we can't catch the CURL error code. It might also be slightly more helpful than the nothing-received test.
Vladislav mentioned that different versions might have different error codes, but I assume we can pass on the CURL error string.
https://curl.haxx.se/libcurl/c/libcurl-errors.html

Posted some input on the Trac ticket, but I am not reviewing this code :)

Build failure - The Moirai have given mortals hearts that can endure.

Some little comments.

One can obtain a CURL error string using https://curl.haxx.se/libcurl/c/CURLOPT_ERRORBUFFER.html but I didn't know what @vladislavbelov meant to say about that function.

Build failure - The Moirai have given mortals hearts that can endure.

To test if D1600 actually works, I was wondering if we can't catch the CURL error code. It might also be slightly more helpful than the nothing-received test.
Vladislav mentioned that different versions might have different error codes, but I assume we can pass on the CURL error string.
https://curl.haxx.se/libcurl/c/libcurl-errors.html

In D1601#64362, @elexis wrote:

Hold on,

bb wrote a patch to add a terms UI that works for all 3 current online services. This way this patch doesnt have to introduce a new file.

All current active revision proposals with regards to GDPR are currently in https://github.com/bb-bb/0ad/tree/terms (except D1590, but that will come later)

(D1602)

Hold on,

On it!

I agree that it's good practice to not use functions that have to be maintained and might break with every new untested platform.
I also agree that relying on platform-dependent maintenance where there is a feasible platform-independent alternative can be considered a defect.

In rP21759#31110, @smiley wrote:

a link (as in a button) to both documents

Since the legal aspect was never reviewed as far as I recall:
I suppose this diff is GPL compliant because the API to the proprietary code is not running in the same binary, that those are two separate programs thus the backend doesn't have to be licensed under GPL (for the same reason the Steam WebAPI would also be compliant with our GPL licensed code afaics) (https://www.gnu.org/licenses/gpl-faq.en.html#MereAggregation)

Actually because the terms-acceptance is reloaded if the username is edited, there is no regression here. (Underlying problem stills lies down under there, per-user and per-mod configs are probably cleaner).

In D1606#64342, @elexis wrote:

You mean unsupported unescaped strings (such as [color="foo"][font="foo"]text[/color][/font])?

Nope, do we escape strings, not characters? I mean to prevent things like "\ ", when the escaped character does nothing.

Both approaches have pros and cons.

Probably we need to report unsupported escaped symbols.

IMO, it would be better to use the escapeText function on https://trac.wildfiregames.com/browser/ps/trunk/binaries/data/mods/public/gui/manual/manual.js#L5
Because that text file could be read as a text file from elsewhere. Also this is a GUI error when displaying and needs to be fixed there. However, this file is usually read in-game, so there is that too. Maybe someone else can suggest the better of the two.

Successful build - Chance fights ever on the side of the prudent.