Thanks a lot for the quick review!

Not all rotation is done in unitMotion, only on the first turn, when m_TurnTime is enabled

I was wondering whether the turn rate needs to be in cmpPosition at all when we would do all rotation in cmpUnitMotion?

Tested, worked as advertised. It looks kinda strange to have all trees look exactly the same, but that is the point of this patch ;)
Textuals look good.

• Works as advertised.
• Code looks clean (nitpick can be ignored when desired).
• Event-based is a good step here.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

comments

Address Freagarach's comments.

Some more testing reveals that in _some_ cases 2 also has the same limitation

Any idea why? It's a bit annoying the minimum vision range is apparently 4.

• make it 4, per @Freagarach

Some more testing reveals that in _some_ cases 2 also has the same limitation as 1. You can make it 3 (probably always correct) or 4 (seems logical with the tilesize).

The code change is correct and, apparently, works under SM45 and SM52.

The correct solution to the issue you highlighted would be reverting rP22802 or at least removing the <ProductionQueue disable=""/> line from the brit_wonder.xml template. However, that's strictly outside the scope of this patch, and ought to be done regardless whether or not this one is committed.

Yes, but any civ except Britons can get the +10 (albeit in a different form) by upgrading that tech. Though I do get your point. I just wanted to note this to whomever will review/commit it.

Yo Stan, I don't see the need for MesonBuild support, I would recommend creating a Trac ticket with "If Time Permits" urgency, a link to this diff in the Patch field, and then abandon this diff for the time being.

Situation prior to this patch:
Any civ build a wonder, get +10 pop cap.
Situation after this patch:
Any civ build a wonder.

But after this patch the Britons don't get the first aura anymore.

Hi @wraitii! I will need this to perform the SM 52->60 migration (see #1389510 on Bugzilla). The ideal route would be to include this under SM52, but if SM60 adds nice code to handle proxy privates, I am fine with doing this as part of the 52->60 code fixes.

I disagree. It's a waste of resources to log data you won't read. If you have a replay it's better than having a bunch of random logs.

Successful build - Chance fights ever on the side of the prudent.

In D2951#133562, @Freagarach wrote:

I mean that the Britons don't get structures/wonder_pop_1-aura when they constructed their wonder.

Actually they did; they just can't research the “Glorious Expansion” technology, which is problematic, but a problem introduced by rP22802, not by this patch.

• make it 2, per @Freagarach

(the advantage of this patch is one needs to change only the number in a single file)

Actually it does matter. The whole point of logs is logging things. Even if they're hidden in game, the errors and warnings still ought to be sent to the logs.

Thx for the review :) Will make other patches if I find more.

Which is why it's on by default . But as reported recently in the forums some people just don't want to see them at all. Keeping them in the file could be am option. But since those are overwritten anyway it doesnt matter.