Page MenuHomeWildfire Games

Recent Activity

Today

Harbormaster failed to build B9855: rP23087: Refactor session lobby bot client code to use object orientation, refs #5387. for rP23087: Refactor session lobby bot client code to use object orientation, refs #5387.!
Mon, Oct 21, 5:16 PM
elexis committed rP23087: Refactor session lobby bot client code to use object orientation, refs #5387..
Refactor session lobby bot client code to use object orientation, refs #5387.
Mon, Oct 21, 5:01 PM
elexis closed D2385: Refactor session lobby bot client code to use object orientation and remove duplication and hardcoding.
Mon, Oct 21, 5:01 PM
elexis added a comment to D2385: Refactor session lobby bot client code to use object orientation and remove duplication and hardcoding.

Verification of the patch:

Mon, Oct 21, 4:55 PM
Stan added inline comments to D2385: Refactor session lobby bot client code to use object orientation and remove duplication and hardcoding.
Mon, Oct 21, 4:41 PM
elexis updated the Trac tickets for D2385: Refactor session lobby bot client code to use object orientation and remove duplication and hardcoding.
Mon, Oct 21, 4:28 PM
elexis added inline comments to rP14752: Reformat the database to accept the additional summary counters as well as….
Mon, Oct 21, 3:20 PM
Harbormaster failed to build B9854: rP23086: Remove hardcoding and quadruplication of the StatisticsTracker unit and… for rP23086: Remove hardcoding and quadruplication of the StatisticsTracker unit and…!
Mon, Oct 21, 11:12 AM
elexis committed rP23086: Remove hardcoding and quadruplication of the StatisticsTracker unit and….
Remove hardcoding and quadruplication of the StatisticsTracker unit and…
Mon, Oct 21, 10:48 AM
elexis closed D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.
Mon, Oct 21, 10:48 AM
elexis added a comment to D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.

For rP14703 there was also the debate whether to unify buildings and structures. Not now.

Mon, Oct 21, 10:35 AM
elexis added inline comments to rP21250: Small StatisticsTracker test.
Mon, Oct 21, 10:28 AM
elexis added a comment to D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.

After this patch, the following Identity classes remain:

Mon, Oct 21, 10:07 AM
elexis added a comment to D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.

For default serialization:
Serialization of these properties could be left out, but since there is only one of these per components per player, it has no significant performance or memory footprint impact. Implementing a custom serialization function that copies all owned properties except these two means that the reader will have to read through the entire component code in order to determine / verify whether the list is complete.

Mon, Oct 21, 9:36 AM
Harbormaster failed to build B9853: rP23085: New Elm trees. for rP23085: New Elm trees.!
Mon, Oct 21, 9:04 AM
Stan committed rP23085: New Elm trees..
New Elm trees.
Mon, Oct 21, 8:37 AM
Angen awarded D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes a Love token.
Mon, Oct 21, 8:13 AM

Yesterday

Harbormaster failed to build B9852: rP23084: New lavender actors. for rP23084: New lavender actors. !
Sun, Oct 20, 10:58 PM
Stan committed rP23084: New lavender actors. .
New lavender actors.
Sun, Oct 20, 10:53 PM
Vulcan added a comment to D2385: Refactor session lobby bot client code to use object orientation and remove duplication and hardcoding.

Successful build - Chance fights ever on the side of the prudent.

Sun, Oct 20, 7:50 PM
Harbormaster failed remote builds in B9851: Diff 10188 for D2385: Refactor session lobby bot client code to use object orientation and remove duplication and hardcoding!
Sun, Oct 20, 7:49 PM
Vulcan added a comment to D2385: Refactor session lobby bot client code to use object orientation and remove duplication and hardcoding.

Build failure - The Moirai have given mortals hearts that can endure.

Sun, Oct 20, 7:49 PM
elexis updated the diff for D2385: Refactor session lobby bot client code to use object orientation and remove duplication and hardcoding.

Remove ceasefire and thus Time.js and extendedSimState argument for InsertValues.

Sun, Oct 20, 7:49 PM
elexis added inline comments to D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.
Sun, Oct 20, 7:46 PM
Vulcan added a comment to D2385: Refactor session lobby bot client code to use object orientation and remove duplication and hardcoding.

Successful build - Chance fights ever on the side of the prudent.

Sun, Oct 20, 7:42 PM
Freagarach added inline comments to D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.
Sun, Oct 20, 7:41 PM
Vulcan added a comment to D2385: Refactor session lobby bot client code to use object orientation and remove duplication and hardcoding.

Build failure - The Moirai have given mortals hearts that can endure.

Sun, Oct 20, 7:41 PM
Harbormaster failed remote builds in B9850: Diff 10187 for D2385: Refactor session lobby bot client code to use object orientation and remove duplication and hardcoding!
Sun, Oct 20, 7:41 PM
elexis created D2385: Refactor session lobby bot client code to use object orientation and remove duplication and hardcoding.
Sun, Oct 20, 7:41 PM
elexis added a comment to D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.

Mostly wondering whether there would be a reason to deem this patch bad, trying to identify a reason why this should not be in the templates but should be in the code.
I fail to find such a reason and it's actually bad to hardcode values in the code. Perhaps one could argue that while the purpose of templates is store values for components, the superseding purpose of templates is to remain moddable while these values are not freely moddable, because the summary screen and lobby bot require some of these values to be present. But I would counter to that that the JS arrays and objects in the summary screen code also look quite modifiable, both in the StatisticsTracker and reportGame in session.js and equally appear like a manual selection of nice classes like here in the template.
So if someone was to hold that point, consequentially the summary screen would have to be changed to work without hardcoded classes, without making any expectations as to what is in the playerState. Then this patch is still correct and not adding a regression, but its the summary screen hardcoding that would be broken. Hence must commit, no?

Sun, Oct 20, 7:29 PM
Freagarach added inline comments to D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.
Sun, Oct 20, 7:17 PM
elexis added inline comments to rP14703: Better summary screen. Fixes #686. Patch by Bajter and Kabzerek.
Sun, Oct 20, 7:05 PM
Vulcan added a comment to D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.

Successful build - Chance fights ever on the side of the prudent.

Sun, Oct 20, 5:55 PM
elexis added inline comments to D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.
Sun, Oct 20, 5:53 PM
Vulcan added a comment to D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.

Successful build - Chance fights ever on the side of the prudent.

Sun, Oct 20, 5:52 PM
elexis updated the diff for D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.

Fix tests.

Sun, Oct 20, 5:51 PM
Harbormaster failed remote builds in B9848: Diff 10185 for D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes!
Sun, Oct 20, 5:36 PM
Vulcan added a comment to D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.

Build failure - The Moirai have given mortals hearts that can endure.

Sun, Oct 20, 5:36 PM
Vulcan added a comment to D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.

Build failure - The Moirai have given mortals hearts that can endure.

Sun, Oct 20, 5:36 PM
elexis created D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.
Sun, Oct 20, 5:35 PM