Today

elexis added a comment to D623: Rallypoints should be rendered in player colors.

Can't find any atlas bugs atm since I'm always running into #4657.

Tue, Jun 27, 11:24 AM
autobuild committed rP19835: [Windows] Automated build..
[Windows] Automated build.
Tue, Jun 27, 7:25 AM
Vulcan added a comment to D623: Rallypoints should be rendered in player colors.

Build is green

Tue, Jun 27, 12:24 AM

Yesterday

Vulcan added a comment to D682: Always display RatedGame boolean.

Build is green

Mon, Jun 26, 11:36 PM
Vulcan added a comment to D682: Always display RatedGame boolean.
Executing section Default...
Executing section Source...
Executing section JS...
Mon, Jun 26, 10:47 PM
Stan updated the diff for D623: Rallypoints should be rendered in player colors.
<elexis> Stan`: I think your color patch is ready if you do the update only on init and ownership change
<elexis> iirc I had posted a question there
<elexis> (the question must have been whether there were any other wrong-color bugs other than changing the civ in atlas)

Done.

Mon, Jun 26, 10:42 PM
Vulcan added a comment to D680: Fix undefined macro usage in cppformat..

Build is green

Mon, Jun 26, 10:36 PM
elexis created D682: Always display RatedGame boolean.
Mon, Jun 26, 10:26 PM
causative added a comment to D681: Town bell (alert) fixes and improvements.

If a building is captured or destroyed, ejected units will try to find a new building to garrison inside.

That may not be a good thing. I often will set a rally point for a building before it's destroyed, so that the units inside will run away to the desired location when the building is destroyed.

Mon, Jun 26, 10:21 PM
Imarok added a comment to D681: Town bell (alert) fixes and improvements.

Just quickly tested one thing:
garrison some dudes in a tower, then later raised alert and ended it again: my dudes also were ungarrisoned.
I don't think this is a good behaviour, because when I put my soldiers into a tower and let's say 20 mins later raise and end an alert, I want them stay in the tower.

Mon, Jun 26, 9:47 PM
fatherbushido added a comment to D681: Town bell (alert) fixes and improvements.

(should come after D403 ideally)

Mon, Jun 26, 9:43 PM
Itms added a comment to D636: Stop using WMI for detecting the sound card.

Seems to work well on linux, but can't test on windows atm, as my windows install is currently broken...

Mon, Jun 26, 9:38 PM
temple created D681: Town bell (alert) fixes and improvements.
Mon, Jun 26, 9:22 PM
Vulcan added a comment to D679: Update OSX libraries.

Build is green

Mon, Jun 26, 8:57 PM
mimo accepted D387: Don't use the Category in BuildRestrictions to check the hardcoded Dock special constraint..

patch is good, and testing on a naval ai game, it gives the same hash value.

Mon, Jun 26, 8:43 PM
mimo committed rP19834: Petra: use moveToRange() instead of move() in some cases.
Petra: use moveToRange() instead of move() in some cases
Mon, Jun 26, 8:25 PM
mimo closed D676: Petra: use moveToRange() instead of move() in some cases by committing rP19834: Petra: use moveToRange() instead of move() in some cases.
Mon, Jun 26, 8:25 PM
Vulcan added a comment to D680: Fix undefined macro usage in cppformat..
Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...
Mon, Jun 26, 8:09 PM
Vulcan added a comment to D678: Autocomplete playernames first.

Build is green

Mon, Jun 26, 8:08 PM
mimo accepted D676: Petra: use moveToRange() instead of move() in some cases.
Mon, Jun 26, 8:07 PM
leper created D680: Fix undefined macro usage in cppformat..
Mon, Jun 26, 8:00 PM
Sandarac added a comment to D642: Remove remnants of the old, deleted trigger system.

(Also there is an unused CTerritoryManager member var (another non-existent class) in CWorld with a corresponding getter, a relic of the old simulation (before the big rewrite that replaced it with simulation2).)

Mon, Jun 26, 7:38 PM
leper added reviewers for D679: Update OSX libraries: Itms, wraitii.

iconv: not sure where that is used

By tinygettext and possibly by icu itself.

Mon, Jun 26, 7:35 PM
Vulcan added a comment to D679: Update OSX libraries.
Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...
Mon, Jun 26, 7:19 PM
Vulcan added a comment to D677: Prevent a tribute exploit.

Build is green

Mon, Jun 26, 7:18 PM
Vulcan added a comment to D678: Autocomplete playernames first.
Executing section Default...
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (no-undef-init):
|    | It's not necessary to initialize 'g_GameStanzaTimer' to undefined.
|----|    | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/gamesetup/gamesetup.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/gamesetup/gamesetup.js
| 318| 318| /**
| 319| 319|  * Index of the GUI timer.
| 320| 320|  */
| 321|    |-var g_GameStanzaTimer = undefined;
|    | 321|+var g_GameStanzaTimer;
| 322| 322| 
| 323| 323| /**
| 324| 324|  * Only send a lobby update if something actually changed.
|    | [NORMAL] ESLintBear (no-undef-init):
|    | It's not necessary to initialize 'yPos' to undefined.
|----|    | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/gamesetup/gamesetup.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/gamesetup/gamesetup.js
|1144|1144| 
|1145|1145| function verticallyDistributeGUIObjects(parent, objectHeight, ignore)
|1146|1146| {
|1147|    |-	let yPos = undefined;
|    |1147|+	let yPos;
|1148|1148| 
|1149|1149| 	let parentObject = Engine.GetGUIObjectByName(parent);
|1150|1150| 	for (let child of parentObject.children)
Mon, Jun 26, 6:21 PM
Harbormaster failed to build B2409: Diff 2697 for D381: Prevent a Barter exploit..
Mon, Jun 26, 6:20 PM
Vulcan added a comment to D381: Prevent a Barter exploit..

Build has FAILED

Mon, Jun 26, 6:20 PM
Vulcan added a comment to D677: Prevent a tribute exploit.
Executing section Default...
Executing section Source...
Executing section JS...
Mon, Jun 26, 5:30 PM
Vulcan added a comment to D665: Make ship pickup nicer.

Build is green

Mon, Jun 26, 5:29 PM
elexis created D679: Update OSX libraries.
Mon, Jun 26, 4:58 PM
elexis created D678: Autocomplete playernames first.
Mon, Jun 26, 4:41 PM
elexis created D677: Prevent a tribute exploit.
Mon, Jun 26, 4:12 PM
Vulcan added a comment to D665: Make ship pickup nicer.

Build is green

Mon, Jun 26, 3:40 PM
Grugnas accepted rP19345: Capture The Relic gamemode..
Mon, Jun 26, 3:13 PM
fatherbushido committed rP19833: Properly apply texture to the last quad of an overlay textured line. Reviewed….
Properly apply texture to the last quad of an overlay textured line. Reviewed…
Mon, Jun 26, 3:04 PM
fatherbushido closed D663: Properly apply the texture to the last quad of an overlay textured line by committing rP19833: Properly apply texture to the last quad of an overlay textured line. Reviewed….
Mon, Jun 26, 3:04 PM
fatherbushido committed rP19832: Remove a useless value cap in Foundation code. Reviewed by wraitii..
Remove a useless value cap in Foundation code. Reviewed by wraitii.
Mon, Jun 26, 2:48 PM
fatherbushido closed D550: Remove a useless min value when building a structure by committing rP19832: Remove a useless value cap in Foundation code. Reviewed by wraitii..
Mon, Jun 26, 2:48 PM
elexis changed the visibility for D42: Fix Atlas under OSX Sierra.
Mon, Jun 26, 2:26 PM