Page MenuHomeWildfire Games

Recent Activity

Today

Itms committed rP24114: Make PlayerHasMarket event-based..
Make PlayerHasMarket event-based.
Thu, Oct 29, 10:23 AM
Itms closed D2919: Make PlayerHasMarket event-based.
Thu, Oct 29, 10:22 AM
Itms added a comment to D2919: Make PlayerHasMarket event-based.

Thanks a lot for the quick review!

Thu, Oct 29, 10:12 AM
bb added a comment to D2837: Stop dodging arrows by spamclicking or patrol: Waste time turning.

Not all rotation is done in unitMotion, only on the first turn, when m_TurnTime is enabled

Thu, Oct 29, 9:35 AM
Freagarach added a comment to D2837: Stop dodging arrows by spamclicking or patrol: Waste time turning.

I was wondering whether the turn rate needs to be in cmpPosition at all when we would do all rotation in cmpUnitMotion?

Thu, Oct 29, 8:31 AM
Freagarach accepted D3035: optionally unrandomize entity appearance.

Tested, worked as advertised. It looks kinda strange to have all trees look exactly the same, but that is the point of this patch ;)
Textuals look good.

Thu, Oct 29, 8:05 AM
Freagarach accepted D2919: Make PlayerHasMarket event-based.
  • Works as advertised.
  • Code looks clean (nitpick can be ignored when desired).
  • Event-based is a good step here.
Thu, Oct 29, 7:39 AM
Freagarach added inline comments to D2948: Move PopulationBonus to new component Population.
Thu, Oct 29, 7:28 AM

Yesterday

Vulcan added a comment to D2995: Properly internationalize attack names/Generlize to arbitrary names in the GUI.

Successful build - Chance fights ever on the side of the prudent.

Wed, Oct 28, 10:47 PM
bb added inline comments to D2837: Stop dodging arrows by spamclicking or patrol: Waste time turning.
Wed, Oct 28, 10:43 PM
bb updated the diff for D2995: Properly internationalize attack names/Generlize to arbitrary names in the GUI.
Wed, Oct 28, 10:40 PM
Vulcan added a comment to D3035: optionally unrandomize entity appearance.

Successful build - Chance fights ever on the side of the prudent.

Wed, Oct 28, 10:40 PM
bb added inline comments to D2995: Properly internationalize attack names/Generlize to arbitrary names in the GUI.
Wed, Oct 28, 10:40 PM
bb updated the diff for D3035: optionally unrandomize entity appearance.

comments

Wed, Oct 28, 10:34 PM
bb added inline comments to D3035: optionally unrandomize entity appearance.
Wed, Oct 28, 10:31 PM
Itms updated the diff for D2919: Make PlayerHasMarket event-based.

Address Freagarach's comments.

Wed, Oct 28, 9:41 PM
Nescio added a comment to D3036: clean up structure vision.

Some more testing reveals that in _some_ cases 2 also has the same limitation

Any idea why? It's a bit annoying the minimum vision range is apparently 4.

Wed, Oct 28, 8:07 PM
Nescio updated the diff for D3036: clean up structure vision.
Wed, Oct 28, 8:06 PM
Freagarach added a comment to D3036: clean up structure vision.

Some more testing reveals that in _some_ cases 2 also has the same limitation as 1. You can make it 3 (probably always correct) or 4 (seems logical with the tilesize).

Wed, Oct 28, 7:40 PM
Itms accepted D2922: Fix a compartment mismatch in XmppClient / Possibly fix semi-random lobby / in game JS crash.

The code change is correct and, apparently, works under SM45 and SM52.

Wed, Oct 28, 6:55 PM
Nescio added a comment to D2951: [gameplay] merge wonder population auras.

The correct solution to the issue you highlighted would be reverting rP22802 or at least removing the <ProductionQueue disable=""/> line from the brit_wonder.xml template. However, that's strictly outside the scope of this patch, and ought to be done regardless whether or not this one is committed.

Wed, Oct 28, 6:44 PM
Freagarach added a comment to D2951: [gameplay] merge wonder population auras.

Yes, but any civ except Britons can get the +10 (albeit in a different form) by upgrading that tech. Though I do get your point. I just wanted to note this to whomever will review/commit it.

Wed, Oct 28, 6:29 PM
Itms added a comment to D2743: [WP] MesonBuild support.

Yo Stan, I don't see the need for MesonBuild support, I would recommend creating a Trac ticket with "If Time Permits" urgency, a link to this diff in the Patch field, and then abandon this diff for the time being.

Wed, Oct 28, 6:25 PM
Angen added inline comments to D3049: Allow disabling error messages.
Wed, Oct 28, 6:13 PM
Nescio added inline comments to D3029: add num pad hotkey equivalents.
Wed, Oct 28, 6:07 PM
Nescio added a comment to D2951: [gameplay] merge wonder population auras.

Situation prior to this patch:
Any civ build a wonder, get +10 pop cap.
Situation after this patch:
Any civ build a wonder.

Wed, Oct 28, 6:05 PM
Freagarach added inline comments to D3029: add num pad hotkey equivalents.
Wed, Oct 28, 5:21 PM
Freagarach added a comment to D2951: [gameplay] merge wonder population auras.

But after this patch the Britons don't get the first aura anymore.

Wed, Oct 28, 5:17 PM
Itms added a comment to D2768: Switch JS GUI Objects to a Proxy class, cleaning custom function definition..

Hi @wraitii! I will need this to perform the SM 52->60 migration (see #1389510 on Bugzilla). The ideal route would be to include this under SM52, but if SM60 adds nice code to handle proxy privates, I am fine with doing this as part of the 52->60 code fixes.

Wed, Oct 28, 3:30 PM
Stan added a comment to D3049: Allow disabling error messages.

I disagree. It's a waste of resources to log data you won't read. If you have a replay it's better than having a bunch of random logs.

Wed, Oct 28, 11:13 AM
Vulcan added a comment to D3036: clean up structure vision.

Successful build - Chance fights ever on the side of the prudent.

Wed, Oct 28, 9:39 AM
Nescio added a comment to D2951: [gameplay] merge wonder population auras.

I mean that the Britons don't get structures/wonder_pop_1-aura when they constructed their wonder.

Actually they did; they just can't research the “Glorious Expansion” technology, which is problematic, but a problem introduced by rP22802, not by this patch.

Wed, Oct 28, 9:35 AM
Nescio updated the diff for D3036: clean up structure vision.

(the advantage of this patch is one needs to change only the number in a single file)

Wed, Oct 28, 9:31 AM
Nescio added inline comments to D3029: add num pad hotkey equivalents.
Wed, Oct 28, 9:25 AM
Nescio added a comment to D3049: Allow disabling error messages.

Actually it does matter. The whole point of logs is logging things. Even if they're hidden in game, the errors and warnings still ought to be sent to the logs.

Wed, Oct 28, 9:23 AM
autobuild committed rP24113: [Windows] Automated build..
[Windows] Automated build.
Wed, Oct 28, 7:47 AM

Tue, Oct 27

Stan committed rP24112: Remove useless SDL debug message introduced in rP15785..
Remove useless SDL debug message introduced in rP15785.
Tue, Oct 27, 10:23 PM
Stan closed D3050: Remove useless SDL debug message.
Tue, Oct 27, 10:23 PM
Stan added a comment to D3050: Remove useless SDL debug message.

Thx for the review :) Will make other patches if I find more.

Tue, Oct 27, 10:19 PM
Stan added a comment to D3049: Allow disabling error messages.

Which is why it's on by default . But as reported recently in the forums some people just don't want to see them at all. Keeping them in the file could be am option. But since those are overwritten anyway it doesnt matter.

Tue, Oct 27, 8:56 PM