Page MenuHomeWildfire Games

Recent Activity
View All

Today

wowgetoffyourcellphone committed rP28164: [Art] Make metal mine sparkles more noticeable. .
[Art] Make metal mine sparkles more noticeable.
Sat, Jul 27, 1:42 AM

Yesterday

Stan added a comment to D4189: Additional loading screen tips.

Did you check the images by the way

Fri, Jul 26, 10:05 PM
real_tabasco_sauce added a comment to D5282: flexible precision sorting for low-precision rangefinding.

roughSortMinimal.diff90 KBDownload

@phosit this diff has all the P values removed so that the only change is the roughSort function. It is basically the same for me compared to the patch as written and vanilla. If it is a lot better for you maybe we have a lead.
Alternatively, you could also just revert the line that calls compareLengthRough() (L272 in CCmpRangeManager.cpp) and see if performance is still bad.

Fri, Jul 26, 9:51 PM
ShadowOfHassen updated the diff for D4189: Additional loading screen tips.

How’s this?

Fri, Jul 26, 9:44 PM
real_tabasco_sauce added a comment to D5282: flexible precision sorting for low-precision rangefinding.
In D5282#226907, @phosit wrote:

No, sorry it's worse with the patch

Fri, Jul 26, 9:08 PM
real_tabasco_sauce added a comment to D5282: flexible precision sorting for low-precision rangefinding.


Ok, I profiled with AI (just my opponent was AI) and the improvement was less substantial (about 1/3 the improvement for me at least)

Fri, Jul 26, 9:07 PM
Vantha added a comment to D4189: Additional loading screen tips.

Yes. There needs to be a linebreak character at the end of the last line.

Fri, Jul 26, 9:00 PM
phosit added a comment to D5282: flexible precision sorting for low-precision rangefinding.

No, sorry it's worse with the patch

Fri, Jul 26, 8:59 PM
real_tabasco_sauce added a comment to D5282: flexible precision sorting for low-precision rangefinding.
In D5282#226873, @phosit wrote:

I think the comparison is somehow wrong now: The AI always attacks units at the "North"

The second is with the patch. It's indeed better.

You can't use the same replay to compare it. It's incompatible, since unit's behave differently.

Fri, Jul 26, 8:25 PM
Vulcan added a comment to D5314: Remove internationalization of log messages.

Build failure - The Moirai have given mortals hearts that can endure.

Fri, Jul 26, 6:46 PM
wowgetoffyourcellphone retitled D5313: [Fix] Code inconsistency in Attack.js for range accuracy from [Fix] Technologies: Advanced and Elite promotion techs did not properly improved ranged accuracy to [Fix] Code inconsistency in Attack.js for range accuracy.
Fri, Jul 26, 5:27 PM
Vulcan added a comment to D5313: [Fix] Code inconsistency in Attack.js for range accuracy.

Successful build - Chance fights ever on the side of the prudent.

Fri, Jul 26, 4:50 PM
autobuild committed rP28163: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Fri, Jul 26, 4:46 PM
wowgetoffyourcellphone updated the diff for D5313: [Fix] Code inconsistency in Attack.js for range accuracy.

Finds remaining instances of this in the techs

Fri, Jul 26, 4:45 PM
ShadowOfHassen added a comment to D4189: Additional loading screen tips.

Just re update the diff and instead of the no newline at the end of file just press return?

Fri, Jul 26, 4:13 PM
Vantha added a comment to D4189: Additional loading screen tips.

Yep. Just make sure to add a newline to the end of all the files.

Fri, Jul 26, 4:02 PM
ShadowOfHassen updated the diff for D4189: Additional loading screen tips.

This should do it I think??

Fri, Jul 26, 3:47 PM
ShadowOfHassen commandeered D4189: Additional loading screen tips.

I was wondering about that, this might allow me to commandeer this.

Fri, Jul 26, 3:47 PM
Stan added a comment to D4189: Additional loading screen tips.

You first need at the bottom to add action 'commandeer patch'

Fri, Jul 26, 3:39 PM
Vulcan added a comment to D5313: [Fix] Code inconsistency in Attack.js for range accuracy.

Successful build - Chance fights ever on the side of the prudent.

Fri, Jul 26, 3:35 PM
Vulcan added a comment to D5313: [Fix] Code inconsistency in Attack.js for range accuracy.

Successful build - Chance fights ever on the side of the prudent.

Fri, Jul 26, 3:29 PM
wowgetoffyourcellphone added a comment to D5313: [Fix] Code inconsistency in Attack.js for range accuracy.
In D5313#226790, @Stan wrote:

https://github.com/0ad/0ad/blob/master/binaries/data/mods/public/simulation/components/Attack.js#L677

Fri, Jul 26, 3:26 PM
wowgetoffyourcellphone updated the diff for D5313: [Fix] Code inconsistency in Attack.js for range accuracy.

Adds component change

Fri, Jul 26, 3:25 PM
Vantha added a comment to D4189: Additional loading screen tips.

Thanks @Stan
@ShadowOfHassen you have the necessary permissions. Just click the "Update Diff" button in the top right of the page.
I'll see if I can help with D1730 as well. Maybe we can finish both now.

Fri, Jul 26, 3:24 PM
Vulcan added a comment to D5314: Remove internationalization of log messages.

Build failure - The Moirai have given mortals hearts that can endure.

Fri, Jul 26, 3:23 PM
wowgetoffyourcellphone planned changes to D5313: [Fix] Code inconsistency in Attack.js for range accuracy.
Fri, Jul 26, 3:01 PM
Vulcan added a comment to D5314: Remove internationalization of log messages.

Successful build - Chance fights ever on the side of the prudent.

Fri, Jul 26, 2:59 PM
Vulcan added a comment to D5314: Remove internationalization of log messages.

Successful build - Chance fights ever on the side of the prudent.

Fri, Jul 26, 2:56 PM
Vulcan added a comment to D5314: Remove internationalization of log messages.

Successful build - Chance fights ever on the side of the prudent.

Fri, Jul 26, 2:53 PM
phosit added a comment to D5282: flexible precision sorting for low-precision rangefinding.

I think the comparison is somehow wrong now: The AI always attacks units at the "North"

Fri, Jul 26, 2:48 PM
dulhaghar updated dulhaghar.
Fri, Jul 26, 1:31 PM
dulhaghar updated dulhaghar.
Fri, Jul 26, 1:28 PM
Vulcan added a comment to D5314: Remove internationalization of log messages.

Successful build - Chance fights ever on the side of the prudent.

Fri, Jul 26, 1:01 PM
Dunedan updated the diff for D5314: Remove internationalization of log messages.

Back to the original diff again.

Fri, Jul 26, 12:52 PM
dhruvcontainer updated dhruvcontainer.
Fri, Jul 26, 12:00 PM
Vulcan added a comment to D5314: Remove internationalization of log messages.

Successful build - Chance fights ever on the side of the prudent.

Fri, Jul 26, 11:40 AM
Dunedan updated the diff for D5314: Remove internationalization of log messages.

Removed changes to LOGMESSAGERENDER.

Fri, Jul 26, 11:31 AM
Dunedan added a comment to D5310: Custom context for specific names.

rP28162 reverts this patch again as it had some unintended consequences. We'll try again with a different one to fix #5563.

Fri, Jul 26, 11:22 AM
Dunedan committed rP28162: Revert "Custom context for specific names".
Revert "Custom context for specific names"
Fri, Jul 26, 11:19 AM
Dunedan added a comment to D5314: Remove internationalization of log messages.
In D5314#226863, @Itms wrote:

LOGMESSAGERENDER is, contrary to LOGMESSAGE, supposed to be displayed to the user, not only in the logs. So it would probably make sense to keep translating them.

Fri, Jul 26, 10:57 AM
Wildfire Games · Phabricator