• <MaxGatherers>

• simplify fauna_shark.xml by changing parent to the very similar template_unit_fauna_hunt_whale.xml

• also include <Attack> node

This patch is outdated, incomplete, and superfluous because of the more recent D2721/rP23930.

I don't understand why this is an absolute number instead of a fraction of the max pop cap, e.g. 25% (for 200 pop baseline) or 16.6% (for 300 pop baseline)

The "add": 50 could be replaced with e.g. "multiply": 1.2 (i.e. 20%), if you think that's better. However, the effect would be exponential, i.e. with a population cap of 250 the first wonder would add 50, the second 60, the third 72, andsoforth, so I guess that's why a flat addition rather than a multification was chosen in the past. I have no strong opinion on this specifically.

I don't understand why this is an absolute number instead of a fraction of the max pop cap, e.g. 25% (for 200 pop baseline) or 16.6% (for 300 pop baseline)

• fix oversights spotted by @Freagarach

I have nothing against it either, if "stackable" is taken out, hardly anyone converts it into a wonder.

What do you mean exactly? The wonder auras are actually stackable, this patch does not change that. As are the library, theatre, and kush temple of amun auras. Or are you of the opinion structure auras shouldn't be stackable?

I like the idea of the patch, but I'm not sure about Iber / Brit / Gaul.
I think fortress and tower should be removed for iber.
PopulationBonus op="add">2, seems useless, a higher value like 5-10 is preferable.

That (i.e. iber +5, gaul +2) is basically what they have right now.
Personally I wouldn't mind removing all those <PopulationBonus> from the brit, gaul, iber structures; I didn't do it here, to limit overlap with D2841.

Interesting that I didn't encounter that when playtesting ^^' (A closer inspection suggests techs need no change.)
Any suggestion how the auras can be handled in the script? To me it seems they have to be fixed manually. (One could, of course, put the aura files also in a civ-dir ^^ )

There are not that many, just six in the public mod, so I suppose you could restore them manually. Luckily hero aura lines are unaffected, I guess because they have an additional folder step, e.g. units/heroes/athen_hero_pericles_1. However, this is something to be aware of when fixing other mods.

Palisades could go into a structures/common folder, at least until palisade models can be created on a per civ basis (if ever; largely a palisade is a palisade, not much culturally happening there, so I imagine the Palisades objects being common amonfg multiple civs for quite a while longer).

It's possible to introduce structures/gaia/ and units/gaia/ subfolders for all entities belonging to <Civ>gaia</Civ> (e.g. common, merc, other, shared, special are less suitable). For palisades, it's not impossible someone at some point decides to introduce {civ} palisade files, which are identical to and inherit from the current palisades, except that they have a different <Civ> and <SpecificName>.

Palisades could go into a structures/common folder, at least until palisade models can be created on a per civ basis (if ever; largely a palisade is a palisade, not much culturally happening there, so I imagine the Palisades objects being common amonfg multiple civs for quite a while longer).

Pinging @FeXoR over wall_builder.js.

I like the idea of the patch, but I'm not sure about Iber / Brit / Gaul.

I can agree with that. It's a bit confusing as it is now and really + 10 pop makes almost no difference. I have nothing against it either, if "stackable" is taken out, hardly anyone converts it into a wonder.

Sure, no problem.

(Also, there are just three merc* units and only one merc* structure.)

Run P225 and apply this patch on top.

To make it work I had to insert a line at the beginning:

cd binaries/data/mods/public/

and another at the end:

cd ../../../../

I suppose the test plan meant to say to run it inside the public/ folder?

The script works, is, as far as I currently know, correct and complete.

Neither technology nor aura lines in templates should be altered:

ERROR: File 'simulation/data/auras/structures/cart/super_dock_repair.json' does not exist

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Fix mapgen.

The script works, is, as far as I currently know, correct and complete.