Page MenuHomeWildfire Games

Recent Activity
View All

Today

vladislavbelov added a comment to D4361: Removes AO multipliers and normalizes AO textures.
In D4361#185795, @Stan wrote:

Maybe we should have "ignored" or something instead. 0.0 looks like a normal value to me.

Fri, Dec 3, 10:02 AM
Stan added a comment to D4361: Removes AO multipliers and normalizes AO textures.

Could have a warning too.

Fri, Dec 3, 9:48 AM
Stan added a comment to D4361: Removes AO multipliers and normalizes AO textures.

Maybe we should have "ignored" or something instead. 0.0 looks like a normal value to me.

Fri, Dec 3, 9:47 AM
vladislavbelov added a comment to D4361: Removes AO multipliers and normalizes AO textures.
In D4361#185793, @Stan wrote:

Even then, any modder opening the file will be confused.

Fri, Dec 3, 9:44 AM
Stan added a comment to D4361: Removes AO multipliers and normalizes AO textures.

Even then, any modder opening the file will be confused.

Fri, Dec 3, 9:31 AM
autobuild committed rP26028: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Fri, Dec 3, 9:15 AM
vladislavbelov added a comment to D4361: Removes AO multipliers and normalizes AO textures.
In D4361#185791, @Stan wrote:

Why do you set it to 0 instead of 1.0 even for materials with AO? It's confusing.

Fri, Dec 3, 9:08 AM
Stan added a comment to D4361: Removes AO multipliers and normalizes AO textures.

Why do you set it to 0 instead of 1.0 even for materials with AO? It's confusing.

Fri, Dec 3, 8:32 AM
Freagarach added a comment to D4361: Removes AO multipliers and normalizes AO textures.

Okay, thanks. :)

Fri, Dec 3, 8:11 AM
vladislavbelov added a comment to D4361: Removes AO multipliers and normalizes AO textures.
In D4361#185787, @Freagarach wrote:

Maybe an ignorant question, but why this patch?

Fri, Dec 3, 8:11 AM
ChinaAirline updated ChinaAirline.
Fri, Dec 3, 8:08 AM
Freagarach added a comment to D4361: Removes AO multipliers and normalizes AO textures.

Maybe an ignorant question, but why this patch?

Fri, Dec 3, 8:07 AM
vladislavbelov requested review of D4361: Removes AO multipliers and normalizes AO textures.
Fri, Dec 3, 7:51 AM
vladislavbelov created P259 Script to normalize AO textures.
Fri, Dec 3, 7:24 AM

Yesterday

Vulcan added a comment to D4354: Adds more flexible dependencies to options.

Successful build - Chance fights ever on the side of the prudent.

Thu, Dec 2, 8:27 PM
Vulcan added a comment to D4354: Adds more flexible dependencies to options.

Successful build - Chance fights ever on the side of the prudent.

Thu, Dec 2, 8:24 PM
vladislavbelov updated the diff for D4354: Adds more flexible dependencies to options.

Fixes linter.

Thu, Dec 2, 8:19 PM
Freagarach requested review of D4360: Put the formation-selection feature behind a config..
Thu, Dec 2, 6:48 PM
Stan added a comment to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

Freagarach is right, https://stackoverflow.com/questions/8044750/javascript-performance-difference-between-double-equals-and-triple-equals

Thu, Dec 2, 4:08 PM

Wed, Dec 1

Freagarach requested changes to D4356: Check for squaredRange being negative.

BuildingAI
But I'd rather have D3249.

Wed, Dec 1, 8:23 PM
Freagarach added a comment to D4343: [PetraAI] - Use enum-like variables instead of magic values. [2/n].

You'll need to rebase this after number 1, so you can wait to implement these changes.

Wed, Dec 1, 8:04 PM
Freagarach accepted D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].
  • Code looks good, greps compleat.
  • Nice change: improves readability.
  • Tested some (~5) games, neither warnings/errors, nor strange behaviour.
Wed, Dec 1, 6:45 PM
Freagarach added a comment to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].
In D4334#185734, @Silier wrote:

We don't need enums, thats correct.
But they help when changing strings/values to make change only on one place.

=== checks also for variable type and therefore is slower than == how is this helpful here?
We assign to those variables only enums, do we need to care about the type?

According to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Equality_comparisons_and_sameness with == the values are converted before checking so that might actually be slower.

Wed, Dec 1, 6:25 PM
Silier added a comment to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

We don't need enums, thats correct.
But they help when changing strings/values to make change only on one place.

Wed, Dec 1, 5:56 PM
Freagarach added a comment to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

We don't _need_ it. :) Nor do we _need_ enums.
But it is nice to have when checking enums, IMHO.

Wed, Dec 1, 5:49 PM
Silier added a comment to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

Why do we need strict checking? == is totally sufficient here.

Wed, Dec 1, 5:47 PM
Vulcan added a comment to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

Successful build - Chance fights ever on the side of the prudent.

Wed, Dec 1, 5:43 PM
Vulcan added a comment to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

Successful build - Chance fights ever on the side of the prudent.

Wed, Dec 1, 5:41 PM
Freagarach updated the diff for D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

Some minor changes.

Wed, Dec 1, 5:35 PM
Stan added a comment to D4244: Forbids using more than 64 bones for GPU skinning.
Wed, Dec 1, 2:15 PM
Vulcan added a comment to D4343: [PetraAI] - Use enum-like variables instead of magic values. [2/n].

Successful build - Chance fights ever on the side of the prudent.

Wed, Dec 1, 1:52 PM
Vulcan added a comment to D4343: [PetraAI] - Use enum-like variables instead of magic values. [2/n].

Successful build - Chance fights ever on the side of the prudent.

Wed, Dec 1, 1:49 PM
vladislavbelov added a comment to D2440: Per-Unit Discrete LOD using actor quality levels.
In D2440#185713, @asterix wrote:

@Stan @vladislavbelov do you know if anyone plans to work on this?

Wed, Dec 1, 1:45 PM
JCWasmx86 updated the diff for D4343: [PetraAI] - Use enum-like variables instead of magic values. [2/n].
Wed, Dec 1, 1:43 PM
vladislavbelov added a comment to D3475: General improvements to 0ad.desktop.
In D3475#185712, @asterix wrote:

Any decision regarding inclusion to master whether we agree and thus it is committable or disagree?

Wed, Dec 1, 1:42 PM
Vulcan added a comment to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

Successful build - Chance fights ever on the side of the prudent.

Wed, Dec 1, 1:31 PM
Vulcan added a comment to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

Successful build - Chance fights ever on the side of the prudent.

Wed, Dec 1, 1:26 PM
JCWasmx86 updated the diff for D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

Replaced the "=="/"!=" with "===" or "!==".

Wed, Dec 1, 1:19 PM
asterix added a comment to D2440: Per-Unit Discrete LOD using actor quality levels.

@Stan @vladislavbelov do you know if anyone plans to work on this?

Wed, Dec 1, 1:09 PM
asterix added a comment to D3475: General improvements to 0ad.desktop.

Any decision regarding inclusion to master whether we agree and thus it is committable or disagree?

Wed, Dec 1, 1:06 PM
Wildfire Games · Phabricator