Today

Vulcan added a comment to D606: Visual move order indicator.

Build is green

Tue, Aug 22, 2:05 AM
elexis committed rP20021: Add help button to Atlas with a link to the Manual and bugtracker..
Add help button to Atlas with a link to the Manual and bugtracker.
Tue, Aug 22, 1:32 AM
elexis closed D794: Add Help menu to Atlas by committing rP20021: Add help button to Atlas with a link to the Manual and bugtracker..
Tue, Aug 22, 1:32 AM
elexis accepted D794: Add Help menu to Atlas.

Thanks, the button with the links are really needed!

Tue, Aug 22, 1:29 AM
Stan updated the diff for D606: Visual move order indicator.

Add an anim that disappear below ground for a time so that it doesn't popup
Add global variable.

Tue, Aug 22, 1:19 AM
Clockwork-Muse created D825: Atlas: Allow map to recenter during resize.
Tue, Aug 22, 1:10 AM
Harbormaster failed to build B2870: Diff 3272 for D606: Visual move order indicator.
Tue, Aug 22, 12:56 AM
Vulcan added a comment to D606: Visual move order indicator.

Build has FAILED

Tue, Aug 22, 12:56 AM
Vulcan added a comment to D794: Add Help menu to Atlas.

Build is green

Tue, Aug 22, 12:55 AM
elexis requested changes to D606: Visual move order indicator.

Change the actor somehow to stop showing the animation after playing it once.
We either have to add support for local simulation timers or GUI timers with arguments. Both are easy and could be done in a separate patch.
Whatever timer is used can delete the animation some time after it played.

Tue, Aug 22, 12:42 AM
elexis planned changes to D595: Allow fast forwarding of games with AIs only.

Grugnas found out that the session code doesn't work as advertized.

Tue, Aug 22, 12:30 AM
Stan added a reviewer for D824: Atlas: Cleanup horizontal alignment flags (ignored): vladislavbelov.
Tue, Aug 22, 12:23 AM
elexis added a comment to D606: Visual move order indicator.

Just tested the uploaded version with the simulation timers. That indeed yields an OOS as expected. It's important to notice that the animation is not always played exactly twice, but sometimes 2.5 times, sometimes 3.5 times before the arrows disappear.
I don't expect that this can be solved with (local) simulation timers nor GUI timers, because it is tied to the renderer. Also it should be played exactly once.

Tue, Aug 22, 12:19 AM
Clockwork-Muse created D824: Atlas: Cleanup horizontal alignment flags (ignored).
Tue, Aug 22, 12:18 AM
leper added a comment to D739: Pass ScriptInterface as a const ref where possible..

With grep -Ri 'scriptInterface&' * | grep -v 'const ScriptInterface&' we can find few more candidates:

At least all those GUI init ones cannot be made const, since one of the functions they use isn't const, and cannot be made const.

Tue, Aug 22, 12:12 AM
Grugnas updated the diff for D408: Loot increased when units get promoted.

perhaps this isn't the cleaner solution.

Tue, Aug 22, 12:12 AM
Vulcan added a comment to D822: Add remember password checkbox.

Build is green

Tue, Aug 22, 12:08 AM

Yesterday

elexis accepted D739: Pass ScriptInterface as a const ref where possible..

Good patch.

Mon, Aug 21, 11:41 PM
ffffffff updated the summary of D817: Lobby Dialogged in-game and setup.
Mon, Aug 21, 11:22 PM
ffffffff added inline comments to D819: Keep lobby history.
Mon, Aug 21, 11:19 PM
leper awarded D822: Add remember password checkbox a Like token.
Mon, Aug 21, 11:18 PM
elexis added a comment to D818: Reset attack timer if repeat time has changed (Cleopatra aura bug).
In D818#32474, @temple wrote:

if ever prepare time was larger than repeat rate ... Maybe it would mess up the animation

Would, refs D258

Mon, Aug 21, 11:14 PM
Vulcan added a comment to D822: Add remember password checkbox.

Build is green

Mon, Aug 21, 11:13 PM
temple added a comment to D818: Reset attack timer if repeat time has changed (Cleopatra aura bug).

A couple other things I remembered.
The first is that there may or may not be problems if ever prepare time was larger than repeat rate. But that's actually not the case for any unit. (Maybe it would mess up the animation too, I didn't test.)
The second is that healers are probably susceptible to the same bug. However, currently Cleopatra is the only aura/tech that modifies the repeat time, and she doesn't affect healers, so it's not an issue at the moment. It's probably the same fix so I think I should include it in this patch.

Mon, Aug 21, 11:08 PM
leper added a comment to D558: Update timer missileHits in case of entity renamed.

imo the place isn't that bad, but this can probably happen with many more functions (not that I can give examples). So shouldn't we skip the functionName check and use this for every timer function with a target (or other entity related data)? (I didn't check or test whether this crashes elsewhere in code)

A more generic way might work, though I'm still not sure if that logic should be in cmpTimer.

Mon, Aug 21, 10:59 PM
elexis added a comment to D823: Give User Notify some time to sound in init phase.

So the correct feature description would be "don't ping people if their nick appears in a historic lobby chat message?".

Mon, Aug 21, 10:54 PM
leper added a comment to D760: Fix BSD build by not using the timezone variable.

(Actually would be nicer to have it listed correctly and find a way to close something, even if not accepted prior.)

Mon, Aug 21, 10:43 PM
elexis added a comment to D760: Fix BSD build by not using the timezone variable.
In D760#32449, @leper wrote:

Has anyone considered setting up a VM?

If one isn't collecting VM images and has deduced that a one-line patch must be correct,
then spending that hour or two to install and configure BSD on a VM, installing the dependencies, checking out, patching, compiling and running 0ad is moderately unproportional.

Mon, Aug 21, 10:35 PM
ffffffff created D823: Give User Notify some time to sound in init phase.
Mon, Aug 21, 10:32 PM
ffffffff added inline comments to D819: Keep lobby history.
Mon, Aug 21, 10:30 PM
leper added a comment to D739: Pass ScriptInterface as a const ref where possible..

Only question, why always const, but there are functions, which look like the changing of the script interface?

Because we can, and because it might point out some cases where we are likely to do stupid things in the future. Some functions are indeed strange as const, since they do seem to change internal state, but that is in SpiderMonkey and not the ScriptInterface, so at that point we're mostly doing it for consistency and because we can.

Mon, Aug 21, 10:20 PM
Stan added a comment to D606: Visual move order indicator.

Agree, would appear nicer.

Mon, Aug 21, 10:16 PM
Stan updated the diff for D606: Visual move order indicator.
Mon, Aug 21, 10:16 PM
ffffffff updated the diff for D819: Keep lobby history.
Mon, Aug 21, 10:09 PM
ffffffff added a comment to D819: Keep lobby history.
Mon, Aug 21, 10:08 PM
leper added a comment to D760: Fix BSD build by not using the timezone variable.

Has anyone considered setting up a VM, or even asking downstream if that works (since downstream reported that failure)?

Mon, Aug 21, 9:54 PM
leper added a comment to rP19947: Fix BSD and OSX build that don't provide the AT&T version of timezone used by….

Actually OSX does provide that, see the second comment on rP19801. They just didn't update the documentation.

Mon, Aug 21, 9:53 PM
elexis added a comment to D606: Visual move order indicator.

I don t feel myself of good advice for judging such a ui feature

Mon, Aug 21, 9:42 PM
vladislavbelov updated the diff for D794: Add Help menu to Atlas.

Added @elexis 's suggestions.

Mon, Aug 21, 9:42 PM
leper added a comment to rP20019: Remove unused Renderer function from rP13877..

Ah, I guess I didn't squash that commit into what became D739. In which case you might be interested in the unused GetScriptInterface in XmppClient.h.

Mon, Aug 21, 9:41 PM