Page MenuHomeWildfire Games

Today

LordGood committed rP22142: Palmyra Palms.
Palmyra Palms
Mon, Mar 25, 5:59 AM
ffffffff added a comment to D1786: Refactor input.js.
In D1786#73229, @elexis wrote:

I'm pointing out these things mostly because I want to inform on our coding conventions and good practices.
But I think the entire file needs to be revisioned structually, adding some syntax sugar is not the essence but part of what needs to be done IMO.
And the more stuff is added to the patch, the harder it will be to review.
Fixing 6000 lines in many logical and syntactical ways is something that can be done in a github branch and typically consumes several weeks to discover all the defects and the ideal structure. Then one can refactor that into small disjoint, atomic, patches.
(I guess the code isn't really inviting to newcomers who want to add one feature and are confronted with a piling disarrangement.)

Mon, Mar 25, 4:29 AM
LordGood committed rP22141: Doum and Nipa palms, Normal maps and specmaps for the new trees.
Doum and Nipa palms, Normal maps and specmaps for the new trees
Mon, Mar 25, 1:12 AM

Yesterday

nani planned changes to D1786: Refactor input.js.
Sun, Mar 24, 9:05 PM
nani updated the diff for D1786: Refactor input.js.

Turned the input events to a FSM from FSM.js (more o less)
Fixes #4848 and implements #2826

Sun, Mar 24, 9:04 PM
nani awarded P133 Attempt at a better UI for external links a Pirate Logo token.
Sun, Mar 24, 8:30 PM
elexis updated the test plan for D1630: Add perlin noise generator..
Sun, Mar 24, 8:20 PM
elexis changed the visibility for P133 Attempt at a better UI for external links.
Sun, Mar 24, 8:10 PM
Vulcan added a comment to D1802: centre → center.

Successful build - Chance fights ever on the side of the prudent.

Sun, Mar 24, 3:35 PM
Nescio created D1802: centre → center.
Sun, Mar 24, 3:33 PM
Nescio added inline comments to D1720: team bonus descriptions consistency.
Sun, Mar 24, 3:27 PM
Gallaecio requested changes to D1720: team bonus descriptions consistency.

I really like the change, I just have some minor feedback for specific lines.

Sun, Mar 24, 2:26 PM
Nescio added a reviewer for D1720: team bonus descriptions consistency: Gallaecio.
Sun, Mar 24, 2:12 PM
Nescio added a comment to D1801: can be brought → could be brought.

"Must be constructed in neutral territory. Has no territory radius effect. Trains all 'mercenary' units."

The military colony does have a territory radius and a different name.

Sun, Mar 24, 2:06 PM
Nescio added a comment to D1614: English review of cavalry unit references.

Perhaps you could also include some related corrections for consistency and completeness?

  • cavalry units → cavalry
  • infantry units → infantry
  • mercenary soldiers → mercenaries
Sun, Mar 24, 1:55 PM
Stan added a comment to D1801: can be brought → could be brought.

Isn't that building the military coloney ?

Sun, Mar 24, 1:41 PM
Nescio added a comment to D1801: can be brought → could be brought.

Line 103 appears to be identical to line 66, so you might want to correct that one too.
However, because neither the civ bonus nor the structure are implemented, it might be better to just purge both.

Sun, Mar 24, 1:39 PM
Stan accepted D1801: can be brought → could be brought.

Looks good to me.

Sun, Mar 24, 1:37 PM
Vulcan added a comment to D1614: English review of cavalry unit references.

Successful build - Chance fights ever on the side of the prudent.

Sun, Mar 24, 1:24 PM
Gallaecio updated the diff for D1614: English review of cavalry unit references.

In order to move things forward, I’ve simplified the diff to change only ‘cavalry soldiers → cavalry’, which was the scope of the original report.

Sun, Mar 24, 1:22 PM
Vulcan added a comment to D1801: can be brought → could be brought.

Successful build - Chance fights ever on the side of the prudent.

Sun, Mar 24, 1:20 PM
Gallaecio created D1801: can be brought → could be brought.
Sun, Mar 24, 1:16 PM
Gallaecio added a comment to D1780: legionnaire → legionary.

I agree with the word change. However, since this change affects filenames beyond the specific word change suggested, I’ll let people more familiar with unit filename conventions give their approval.

Sun, Mar 24, 12:49 PM
Stan added a comment to D1741: Fix some warning for vs2015 in Atlas.

@Itms any concerns with this patch ?

Sun, Mar 24, 12:42 PM
Stan added a reviewer for D1780: legionnaire → legionary: Gallaecio.
Sun, Mar 24, 12:41 PM
Gallaecio committed rP22140: Reword the tooltip of the Disable Treasures option.
Reword the tooltip of the Disable Treasures option
Sun, Mar 24, 12:35 PM
Gallaecio closed D1532: Reword the tooltip of the Disable Treasures option.
Sun, Mar 24, 12:34 PM

Sat, Mar 23

Angen updated the Trac tickets for D1800: Display correct ranged overlay for maximum range.
Sat, Mar 23, 10:33 PM
LordGood committed rP22139: Mangroves.
Mangroves
Sat, Mar 23, 10:17 PM
Angen added a comment to D1800: Display correct ranged overlay for maximum range.

It is recomputed just if object changes owner, is created or some modification comes. Overlay for units is not updated white moving even when they get elevation bonus. Using let now = Date.now() and logging Date.now() - now at the end of GetElevationAdaptedRange returns 0 or 1 depending on range, bigger maximum range and elevationbonus longer it gets to compute. However with 1000 loop it freezes. But it is actually such problem if range overlay is not updated on movement ? We may restrict this computation just for buildings and make TODO to solve it for units ?

Sat, Mar 23, 10:15 PM
elexis added a comment to D1800: Display correct ranged overlay for maximum range.

With the new message subscription, one could patrol on a hill with a unit that has the range displayed. Then the thing would be updated very often.

Sat, Mar 23, 7:49 PM
Stan added inline comments to D1800: Display correct ranged overlay for maximum range.
Sat, Mar 23, 7:23 PM
Vulcan added a comment to D1800: Display correct ranged overlay for maximum range.

Successful build - Chance fights ever on the side of the prudent.

Sat, Mar 23, 7:01 PM
Angen updated the diff for D1800: Display correct ranged overlay for maximum range.

added missing check for change in elevation bonus

Sat, Mar 23, 6:58 PM
Angen added a comment to D1800: Display correct ranged overlay for maximum range.

Right, elevationBonus is number based on which is added range corresponding to how high is current terrain.
It is based on GuiInterface.js lines 410 - 426 which result is used to display (+x) in toolip for range attack.

Sat, Mar 23, 6:22 PM
elexis added a comment to D1800: Display correct ranged overlay for maximum range.

Didn't we have a ticket for it? I recall receiving a report about that once.
I also seem to recall having looked into the code and having gained the impression that range bonus was already accounted for.
Actually I get it again looking into the code and wondering why the elevation code in GetRange doesn't already provide the information.
I guess ElevationBonus != GetElevationAdaptedRange, the former must just have been height of the building.
Good then.

Sat, Mar 23, 5:08 PM
Stan added inline comments to D1800: Display correct ranged overlay for maximum range.
Sat, Mar 23, 3:13 PM
Vulcan added a comment to D1800: Display correct ranged overlay for maximum range.

Successful build - Chance fights ever on the side of the prudent.

Sat, Mar 23, 1:42 PM
Angen created D1800: Display correct ranged overlay for maximum range.
Sat, Mar 23, 1:03 PM

Fri, Mar 22

OptimusShepard added a comment to D1758: Smooth new Kushite background.

Before the patch the balkon position was wrong.


Now after the patch the balkon is on the right position but stretched.

Fri, Mar 22, 8:05 PM · Contributors