Today

smiley added inline comments to D1608: Show a more helpful message upon an empty response from mod.io.
Wed, Aug 15, 12:22 PM

Yesterday

andy5995 created D1610: build-osx-libs.sh: add --without-libidn2 flag to curl region .
Tue, Aug 14, 8:30 AM

Mon, Aug 13

andy5995 added a comment to D1606: Escape the backslash within the in-game manual.

After reading the comments, I don't really understand what I should do next, if anything. Sounds like you want to fix this with another method, and need to discuss the best approach? I know it's low priority but just thought I'd touch base in case there's anything else I could do with it at the present time.

Mon, Aug 13, 2:28 PM

Sun, Aug 12

elexis added a comment to rP21520: Secure lobby authentication - prevent joins as a different player.

The configuration entry and the options UI entry proposed were meant to be used for players that play with the vanilla 0ad code.

Sun, Aug 12, 5:00 PM
andy5995 added a comment to D1582: Use pkg-config instead of sdl2-config.

I tested this patch and added my results to the ticket.

Sun, Aug 12, 4:18 PM

Sat, Aug 11

asterix added a reviewer for D1510: Update to Spidermonkey 45.0.2: Itms.
Sat, Aug 11, 8:32 PM
smiley added a comment to D1608: Show a more helpful message upon an empty response from mod.io.

Some things I found out after searching around https://curl.haxx.se/libcurl/c/ .
I'm not sure I understood it correctly or not. So, inline comments maybe wrong.
But if they are true, an alternative (maybe hacky) solution would be to send a status check request before the actual request.

Sat, Aug 11, 10:55 AM

Fri, Aug 10

vladislavbelov added a comment to D1608: Show a more helpful message upon an empty response from mod.io.
In D1608#64376, @elexis wrote:

To test if D1600 actually works, I was wondering if we can't catch the CURL error code. It might also be slightly more helpful than the nothing-received test.
Vladislav mentioned that different versions might have different error codes, but I assume we can pass on the CURL error string.
https://curl.haxx.se/libcurl/c/libcurl-errors.html

Fri, Aug 10, 11:19 PM
Itms resigned from D1500: #5046 - Unify User.cfg, Local.cfg, Mod.cfg.

Posted some input on the Trac ticket, but I am not reviewing this code :)

Fri, Aug 10, 4:12 PM
Harbormaster failed remote builds in B6331: Diff 6851 for D1609: Update OSX bundle copyright version!
Fri, Aug 10, 3:44 PM
Vulcan added a comment to D1609: Update OSX bundle copyright version.

Build failure - The Moirai have given mortals hearts that can endure.

Fri, Aug 10, 3:44 PM
Stan created D1609: Update OSX bundle copyright version.
Fri, Aug 10, 3:43 PM
Stan added reviewers for D1500: #5046 - Unify User.cfg, Local.cfg, Mod.cfg: Itms, vladislavbelov.
Fri, Aug 10, 3:42 PM
Stan added a comment to D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.

Some little comments.

Fri, Aug 10, 3:28 PM
elexis retitled D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy from 0 A.D. Empires Ascendant User Reporter Privacy Policy to 0 A.D. Empires Ascendant UserReporter Privacy Policy.
Fri, Aug 10, 3:21 PM

Thu, Aug 9

elexis updated subscribers of D1608: Show a more helpful message upon an empty response from mod.io.

One can obtain a CURL error string using https://curl.haxx.se/libcurl/c/CURLOPT_ERRORBUFFER.html but I didn't know what @vladislavbelov meant to say about that function.

Thu, Aug 9, 7:44 PM
Harbormaster failed remote builds in B6330: Diff 6850 for D1608: Show a more helpful message upon an empty response from mod.io!
Thu, Aug 9, 6:53 PM
Vulcan added a comment to D1608: Show a more helpful message upon an empty response from mod.io.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Aug 9, 6:53 PM
elexis added a comment to D1608: Show a more helpful message upon an empty response from mod.io.

To test if D1600 actually works, I was wondering if we can't catch the CURL error code. It might also be slightly more helpful than the nothing-received test.
Vladislav mentioned that different versions might have different error codes, but I assume we can pass on the CURL error string.
https://curl.haxx.se/libcurl/c/libcurl-errors.html

Thu, Aug 9, 6:50 PM
smiley created D1608: Show a more helpful message upon an empty response from mod.io.
Thu, Aug 9, 6:43 PM
Itms added a comment to D1601: Link users with mod.io's privacy policy and terms of use..
In D1601#64362, @elexis wrote:

Hold on,

bb wrote a patch to add a terms UI that works for all 3 current online services. This way this patch doesnt have to introduce a new file.

All current active revision proposals with regards to GDPR are currently in https://github.com/bb-bb/0ad/tree/terms (except D1590, but that will come later)

Thu, Aug 9, 4:35 PM
elexis added a comment to D1601: Link users with mod.io's privacy policy and terms of use..

(D1602)

Thu, Aug 9, 3:46 PM
elexis added a comment to D1601: Link users with mod.io's privacy policy and terms of use..

Hold on,

Thu, Aug 9, 3:44 PM
Itms added a reviewer for D1601: Link users with mod.io's privacy policy and terms of use.: Itms.

On it!

Thu, Aug 9, 3:41 PM
autobuild committed rP21864: [Windows] Automated build..
[Windows] Automated build.
Thu, Aug 9, 7:26 AM

Wed, Aug 8

vladislavbelov accepted rP21850: Persist the lobby Terms Of Use and Terms Of Service checkbox if the logged in….
Wed, Aug 8, 10:25 PM
elexis committed rP21863: Unify duplicate u8* to hex string functions in a new Hexify function variant….
Unify duplicate u8* to hex string functions in a new Hexify function variant…
Wed, Aug 8, 3:01 PM
elexis closed D1591: Consistently use Hexify to convert u8* to hex strings.
Wed, Aug 8, 3:01 PM
elexis requested verification of rP21850: Persist the lobby Terms Of Use and Terms Of Service checkbox if the logged in….
Wed, Aug 8, 2:59 PM
elexis added a comment to rP21850: Persist the lobby Terms Of Use and Terms Of Service checkbox if the logged in….

I agree that it's good practice to not use functions that have to be maintained and might break with every new untested platform.
I also agree that relying on platform-dependent maintenance where there is a feasible platform-independent alternative can be considered a defect.

Wed, Aug 8, 2:51 PM
elexis added a comment to rP21759: mod.io support..

a link (as in a button) to both documents

Wed, Aug 8, 12:07 PM
elexis added a comment to rP21759: mod.io support..

Since the legal aspect was never reviewed as far as I recall:
I suppose this diff is GPL compliant because the API to the proprietary code is not running in the same binary, that those are two separate programs thus the backend doesn't have to be licensed under GPL (for the same reason the Steam WebAPI would also be compliant with our GPL licensed code afaics) (https://www.gnu.org/licenses/gpl-faq.en.html#MereAggregation)

Wed, Aug 8, 12:06 PM

Tue, Aug 7

elexis added a comment to D1602: Extract the terms code from the prelobby to reuse it for other term accepters (userreport).

Actually because the terms-acceptance is reloaded if the username is edited, there is no regression here. (Underlying problem stills lies down under there, per-user and per-mod configs are probably cleaner).

Tue, Aug 7, 2:14 PM
vladislavbelov added a comment to D1606: Escape the backslash within the in-game manual.
In D1606#64342, @elexis wrote:

You mean unsupported unescaped strings (such as [color="foo"][font="foo"]text[/color][/font])?

Nope, do we escape strings, not characters? I mean to prevent things like "\ ", when the escaped character does nothing.

Tue, Aug 7, 1:59 PM
elexis added a comment to D1606: Escape the backslash within the in-game manual.

Both approaches have pros and cons.

Tue, Aug 7, 11:09 AM
vladislavbelov added a comment to D1606: Escape the backslash within the in-game manual.

Probably we need to report unsupported escaped symbols.

Tue, Aug 7, 10:44 AM
smiley added a comment to D1606: Escape the backslash within the in-game manual.

IMO, it would be better to use the escapeText function on https://trac.wildfiregames.com/browser/ps/trunk/binaries/data/mods/public/gui/manual/manual.js#L5
Because that text file could be read as a text file from elsewhere. Also this is a GUI error when displaying and needs to be fixed there. However, this file is usually read in-game, so there is that too. Maybe someone else can suggest the better of the two.

Tue, Aug 7, 3:25 AM

Mon, Aug 6

andy5995 created D1606: Escape the backslash within the in-game manual.
Mon, Aug 6, 11:57 PM
vladislavbelov accepted D1591: Consistently use Hexify to convert u8* to hex strings.
Mon, Aug 6, 10:41 PM
Vulcan added a comment to D1605: Chat notification filter.

Successful build - Chance fights ever on the side of the prudent.

Mon, Aug 6, 12:50 PM