In D3047#133479, @vladislavbelov wrote:

Does getrandom have some performance expectations? Is it similar to /dev/urandom?

I’ve tested that this patch indeed prevents the fixed renderer from spawning a window on Wayland.

Thanks!

I haven’t tested this patch, but it’s overall a much needed clean-up, so +1 for it!

Changed %u to %d for printing pid_t.

Add missing SDL_clipboard.h include for Windows.

Fix Vladislav’s comments, still mirrored at GitHub to avoid squashing the commits.

The latest changes are rebased and pushed at https://github.com/linkmauve/0ad/tree/rm-sys

• Add a comment about prehistoric kernels not supporting thread names.
• Change the order of const and char.

• Rename the sdl2_* keys to sdl_*.
• Include used CLogger.h.
• Include useless libsdl.h but that’s part of the project guidelines.
• Attempt a workaround for MSVC2015.

Fix the copyright year.

Include "pregenerated.h"

Fix HWDetect.cpp.

Move the implementation in lib/external_libraries/libsdl.cpp

Fix Vladislav’s comments.

Fix a missing #if guard for systems which don’t have a GL/glx.h header.

• Add a comment explaining the function.
• Update the copyright year.

• Mention in clipboard commit that it fixes #5537.
• Update the copyright year of touched files.

Won’t that be fixed once we don’t redefine the WGL types in wgl.h (that is, once that file gets nuked)?

Actually use SDL_GetError().

This only depends on D2499’s removal of WGL now.

• Use ARRAY_SIZE() instead of hardcoding the array size.
• Use the correct first version for WinRT and OS/2.
• Increment the reportVersion.

• Update the copyright years.
• Simplify the ogl_DebugGroup class.
• Add a fallback for when we’re not compiling in debug mode.

Fix build failure.

• Add debug groups push and pop using RAII.
• Add debug message callback with filtering.

Change how preferglsl is forced to true.

• Change include order again.
• Change copyright year.

Make magic constants less magic by binding them to a name.

Check for fopen()’s failure, thanks Angen for the suggestion!

Use syscall() directly instead of a wrapper.

Include missing unistd.h header for gettid().

• Update the copyright year.
• Replace glibc’s non-portable pthread_setname_np() with an implementation that will work on all Linux libc.

Change the year in the copyright.

• Add newline to split header sections.
• Increment the copyright year.

Fix the copyright years.

#ifdef the glObjectLabelKHR() call to avoid it being executed when not debugging.

Fix wrong introduction version for Vivante, thanks Stan` for spotting that!

• Put the include in the system section.
• Add a warning for SDL 2.0.11+ new platforms.

Fix all comments by Vladislav.

• Fix missing include on Windows.
• Fix build with SDL2 2.0.3 (used in the CI).

Update the copyright date.

That’s wrong at least on glibc, where raise() will be local to the thread.

Fix Stan`’s comments:

• Describe better the content of frequency and bpp.
• Change C-style casts into static_casts.

Include back the wcursor removal.

This now removes almost all platform-specific calls, not just cursors but also clipboards and video modes, replacing them with SDL2 calls.

The minimap looks correct atm, the entire game looks like it only needs some polish before it looks identical to the GL version, on Intel. :)

Added myself to the credits, and removed the .gitignore change as it doesn’t seem to exist on svn…