Make modmod looking nicer
Reviewed by: Itms
Differential Revision: https://code.wildfiregames.com/D1412
Description
Description
Details
Details
- Auditors
s0600204 bb - Committed
Imarok Apr 14 2018, 10:04 PM - Reviewer
- Itms
- Differential Revision
- D1412: Make modmod looking nicer
- Parents
- rP21720: Update mod_ipstamp for current ejabberd versions and update lobby setup…
- Branches
- Unknown
- Tags
- Build Status
Buildable 5864 Build 9807: Post-Commit Build Jenkins
Event Timeline
| /ps/trunk/binaries/data/mods/mod/gui/common/modern/sprites.xml | ||
|---|---|---|
| 603 | should this be ModernArrowDownRed for consistency? | |
| /ps/trunk/binaries/data/mods/mod/gui/modmod/modmod.js | ||
| 352 | disEnable -> toggle | |
| /ps/trunk/binaries/data/mods/mod/gui/modmod/modmod.xml | ||
| 171 | (I was wondering if the button was a good idea, it could open malicious URLs. Might add a message box to inform the user prior to opening.) | |
| /ps/trunk/binaries/data/mods/mod/gui/modmod/modmod.xml | ||
|---|---|---|
| 171 | As you already downloaded the mod, isn't it already too late to think about malicious code/urls? | |
| /ps/trunk/binaries/data/mods/mod/gui/modmod/modmod.js | ||
|---|---|---|
| 352 | Also the linter noticed the semicolon missing. | |
Comment Actions
Looks like I forgot to submit my comments ><
| /ps/trunk/binaries/data/mods/mod/gui/common/modern/sprites.xml | ||
|---|---|---|
| 603 | True. | |
| /ps/trunk/binaries/data/mods/mod/gui/modmod/modmod.js | ||
| 352 |
you mean just toggleButton? That sounds too unspecific. What about toggleModButton?
And multiple spaces. Will fix this asap. | |
| /ps/trunk/binaries/data/mods/mod/gui/common/modern/sprites.xml | ||
|---|---|---|
| 603 | (Eventually it ought to be ArrowDownBig, Button, TextLeft and so forth, so that one can chose a different theme without having to change every GUI object in every XML file) | |
| /ps/trunk/binaries/data/mods/mod/gui/modmod/modmod.js | ||
| 352 | As you wish, just that disEnable seems ugly | |
Comment Actions
(Translation issue, reported by Requin on the forums (link))
| /ps/trunk/binaries/data/mods/mod/gui/modmod/modmod.js | ||
|---|---|---|
| 353 | translate() calls missing, leading to untranslated user-facing text. (https://i.imgur.com/qXODleU.jpg, image by Requin) | |
