Does this change the order in which they're applied?
Technologies are permanent, auras temporary; values used to be processed as follows:

1. all xml template stats
2. all technology multiplications
3. all technology additions
4. all aura multiplications
5. all aura additions

( https://wildfiregames.com/forum/index.php?/topic/21083-how-to-modify-0-ad/page/2/&tab=comments#comment-336823 )

In rP22767#36879, @Nescio wrote:

Does this change the order in which they're applied?
Technologies are permanent, auras temporary; values used to be processed as follows:

1. all xml template stats
2. all technology multiplications
3. all technology additions
4. all aura multiplications
5. all aura additions

( https://wildfiregames.com/forum/index.php?/topic/21083-how-to-modify-0-ad/page/2/&tab=comments#comment-336823 )

Mh, actually it does because auras and technologies will now be processed as one. So if a tech was adding 5, multiplying by 2, and an aura was doing the same, it would before have done ((x * 2) + 5) * 2 + 5, whereas it now will do x * 4 + 10, which isn't quite the same.

Further techs will still be processed in semi-random order stopping at the first "replace", for example.

I've disliked that for quite some time and I wanted to fix this with "priority", which I had implemented early in the diff, but ended up scrapping as it generated much debate. I'll probably re-implement it at some point.

In rP22767#36880, @wraitii wrote:

Mh, actually it does because auras and technologies will now be processed as one. So if a tech was adding 5, multiplying by 2, and an aura was doing the same, it would before have done ((x * 2) + 5) * 2 + 5, whereas it now will do x * 4 + 10, which isn't quite the same.

Further techs will still be processed in semi-random order stopping at the first "replace", for example.

I've disliked that for quite some time and I wanted to fix this with "priority", which I had implemented early in the diff, but ended up scrapping as it generated much debate. I'll probably re-implement it at some point.

So first all multiplications, then additions, sounds logical? Or can the techs/auras be still in random order (x * t1 + t2) * t3 + t4?

So first all multiplications, then additions, sounds logical? Or can the techs/auras be still in random order (x * t1 + t2) * t3 + t4?

Well "replace" is random, but so long as there is only one replacing tech, it should still work correctly.
For the rest it's all multiplications then all additions indeed.

In rP22767#36937, @wraitii wrote:

So first all multiplications, then additions, sounds logical? Or can the techs/auras be still in random order (x * t1 + t2) * t3 + t4?

Well "replace" is random, but so long as there is only one replacing tech, it should still work correctly.
For the rest it's all multiplications then all additions indeed.

Sounds a lot easier to explain to me! (Though not entirely correct indeed.)

Well "replace" is random, but so long as there is only one replacing tech, it should still work correctly.

Shouldn't it be chronological? So if A and B both replace the same attribute, and you research B before A, then A replaces B's replacement.

In rP22767#36940, @Nescio wrote:

Well "replace" is random, but so long as there is only one replacing tech, it should still work correctly.

Shouldn't it be chronological? So if A and B both replace the same attribute, and you research B before A, then A replaces B's replacement.

I think it's chronological right now but that's not really enforced in the code, nor has it been part of the specs anytime Afaik.
I actually think all modifiers should be chronological (that's the only thing that makes sense to me) but that has its own problems (such as researching techs in a particular order might give a better bonus).

but that has its own problems (such as researching techs in a particular order might give a better bonus).

Yeah, Cossacks had that; it wasn't great.

There were some discussions about order in D274.
I didn't investigate, but perhaps deterministic order might also play a role for serialization / deserialization safety.

Added helper test: refs. D151.

I suppose the audit on the impact of effect order might be continued.

In rP22767#38351, @elexis wrote:

Prior to this commit, one would receive chat notifications when phasing up with cheats.

Not only with cheats ;) (Also missing when researching.)