Page MenuHomeWildfire Games

team bonus descriptions consistency
Needs ReviewPublic

Authored by Nescio on Sun, Dec 30, 5:46 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

The descriptions of team bonuses were sometimes incorrect and sentences were often longer than necessary. This patch corrects mistakes and implements a standard format: [player] [class] [change] [attributes]. E.g.: "Allied warships −25% construction time." instead of "Ships construct 25% faster."
It also updates the team bonus descriptions listed in the civ.json files.

Test Plan

Check for typos.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6611
Build 10904: Vulcan BuildJenkins
Build 10903: arc lint + arc unit

Event Timeline

Nescio created this revision.Sun, Dec 30, 5:46 PM
Nescio updated this revision to Diff 7149.Sun, Dec 30, 5:55 PM

BuildTime according to https://trac.wildfiregames.com/wiki/EnglishStyleGuide#Actions

  • ships and siege engines are constructed
  • structures are built
  • technologies are researched
  • units are trained
Nescio edited the summary of this revision. (Show Details)Sun, Dec 30, 5:56 PM
Vulcan added a subscriber: Vulcan.Sun, Dec 30, 5:56 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/857/

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/859/

Stan added a subscriber: Gallaecio.EditedSun, Dec 30, 6:08 PM

Sounds pretty cool. Pinging @Gallaecio, @bb, and @elexis as it's still a big enough patch :)

Stan added subscribers: bb, elexis.Sun, Dec 30, 6:09 PM
Nescio added a comment.Sat, Jan 5, 8:50 PM

Big enough? One line for each civ, two files each.