The descriptions of team bonuses were sometimes incorrect and sentences were often longer than necessary. This patch corrects mistakes and implements a standard format: [player] [class] [change] [attributes]. E.g.: "Allied warships −25% construction time." instead of "Ships construct 25% faster."
It also updates the team bonus descriptions listed in the civ.json files.
Details
- Reviewers
Gallaecio - Commits
- rP22149: Improve team bonus descriptions consistency
Check for typos.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
BuildTime according to https://trac.wildfiregames.com/wiki/EnglishStyleGuide#Actions
- ships and siege engines are constructed
- structures are built
- technologies are researched
- units are trained
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/857/
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/859/
Sounds pretty cool. Pinging @Gallaecio, @bb, and @elexis as it's still a big enough patch :)
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/1121/display/redirect
I really like the change, I just have some minor feedback for specific lines.
binaries/data/mods/public/simulation/data/auras/teambonuses/mace_player_teambonus.json | ||
---|---|---|
12 ↗ | (On Diff #7595) | Shouldn’t it be ‘Allied markets +20% sell prices.’? |
binaries/data/mods/public/simulation/data/auras/teambonuses/maur_player_teambonus.json | ||
10 ↗ | (On Diff #7595) | I would prefer this unrelated change not to be part of the patch, but if it does, I think this line should be last, assuming the new order is alphabetical. |
binaries/data/mods/public/simulation/data/auras/teambonuses/sele_player_teambonus.json | ||
12 ↗ | (On Diff #7595) | Centers |
binaries/data/mods/public/simulation/data/civs/mace.json | ||
85 ↗ | (On Diff #7595) | Same as above. |
binaries/data/mods/public/simulation/data/civs/sele.json | ||
84 ↗ | (On Diff #7595) | Same as above. |
binaries/data/mods/public/simulation/data/auras/teambonuses/mace_player_teambonus.json | ||
---|---|---|
12 ↗ | (On Diff #7595) | No, that would imply this aura modifies the market, which isn't the case; barter prices are independent from specific structures. |
binaries/data/mods/public/simulation/data/auras/teambonuses/maur_player_teambonus.json | ||
10 ↗ | (On Diff #7595) | Attributes are typically listed in alphabetical order, but resources have are listed in the way they are numbered and displayed in-game (f, w, m, s, t). It is included in this patch because it's related. To start with,the current order of modifications is inconsistent with the practice of other teambonuses (e.g. brit), auras, technologies, and templates. |
binaries/data/mods/public/simulation/data/auras/teambonuses/sele_player_teambonus.json | ||
12 ↗ | (On Diff #7595) | You're right, I'll correct this. |
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/1139/display/redirect