- remove redundant/inconsistent "Enable" in the names of some boolean options
- remove inconsistent periods in some option names
- a couple of minor clarifications for "specific"/"generic" names and "TLS encryption"
Details
Details
- Reviewers
Freagarach sera
Tested in the game.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 22333 Build 54621: Vulcan Build Jenkins Build 54620: Vulcan Build (macOS) Jenkins Build 54619: Vulcan Build (Windows) Jenkins
Event Timeline
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7282/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8371/display/redirect
| binaries/data/mods/public/gui/options/options.json | ||
|---|---|---|
| 63–64 | Before or after, neither sounds great but alas I can't think of a good one either ... | |
| binaries/data/mods/public/gui/options/options.json | ||
|---|---|---|
| 70 | I have to ask for proper quotes here. ^^ (See https://trac.wildfiregames.com/wiki/EnglishStyleGuide#Punctuationandspacing.) | |
Comment Actions
@sera: Yeah. :/ I hope the examples are enough. Thanks!
@Freagarach: Thanks too! I've changed the quotation marks, they look good in the game and I don't have to escape them. :D
I also want to align the circles of the boolean options to the left, as in other windows, so they're closer to the text and it's easier to see which circle corresponds to which option. But it will be in another patch, I have to locate the file. If I add you as reviewers, sorry in advance for the noise.
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7286/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8375/display/redirect