disable "cutoff distance" slider when "cover whole map" is on
Needs ReviewPublic
Actions

Authored by abian on Sep 27 2023, 6:03 PM.

Details

Reviewers

vladislavbelov
sera

Summary

In line with other configuration options, the "Cutoff distance" slider on the "Graphics (advanced)" tab of the game settings screen should be disabled when the "Cover whole map" configuration option is on.

Test Plan

Test in the game turning "Cover whole map" on/off.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 22411
Build 54840: Vulcan Build	Jenkins
Build 54839: Vulcan Build (macOS)	Jenkins
Build 54838: Vulcan Build (Windows)	Jenkins

Event Timeline

abian created this revision.Sep 27 2023, 6:03 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7339/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8428/display/redirect

abian updated this revision to Diff 22331.Sep 27 2023, 6:15 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7340/display/redirect

Harbormaster completed remote builds in B22403: Diff 22330.Sep 27 2023, 6:17 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8429/display/redirect

abian published this revision for review.Sep 27 2023, 6:24 PM

Harbormaster completed remote builds in B22404: Diff 22331.Sep 27 2023, 6:33 PM

vladislavbelov added a subscriber: vladislavbelov.Sep 27 2023, 6:53 PM

vladislavbelov added inline comments.

binaries/data/mods/public/gui/options/options.json
329	I think you can just write: "dependencies": ["shadows", {"config": "shadowscovermap", "value": false}],

It makes sense that dependencies on disabled should be a thing, just wonder what the spec should be. I mean we might also need something like var>=5 or var!=testing_mode and many others further down the road. So it might make sense to think a bit more about the spec. !var could also be var=false for instance.

Anyway whatever the spec, it should be document in the doxy comment for enableButtons().

Thank you both! Now the comparison is specified with "false" and the format is documented.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7346/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8435/display/redirect

Harbormaster completed remote builds in B22411: Diff 22339.Sep 30 2023, 3:47 PM

abian added reviewers: vladislavbelov, sera.Dec 12 2023, 5:03 PM