Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (no-multi-spaces):
|    | Multiple spaces found before 'state'.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels.js
| 298| 298| 		if (!g_AvailableFormations.has(unitEntStates[0].player))
| 299| 299| 			g_AvailableFormations.set(unitEntStates[0].player, Engine.GuiInterfaceCall("GetAvailableFormations", unitEntStates[0].player));
| 300| 300| 
| 301|    |-		return g_AvailableFormations.get(unitEntStates[0].player).filter(formation => unitEntStates.some(state => !!state.identity &&  state.identity.formations.indexOf(formation) != -1));
|    | 301|+		return g_AvailableFormations.get(unitEntStates[0].player).filter(formation => unitEntStates.some(state => !!state.identity && state.identity.formations.indexOf(formation) != -1));
| 302| 302| 	},
| 303| 303| 	"setupButton": function(data)
| 304| 304| 	{
|    | [NORMAL] ESLintBear (space-before-function-paren):
|    | Unexpected space before function parentheses.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels.js
| 761| 761| 				addResearchToQueue(data.item.researchFacilityId, t);
| 762| 762| 			})(tech);
| 763| 763| 
| 764|    |-			button.onPressRight = (t => function () {
|    | 764|+			button.onPressRight = (t => function() {
| 765| 765| 				showTemplateDetails(
| 766| 766| 					t,
| 767| 767| 					GetTemplateData(data.unitEntStates.find(state => state.id == data.item.researchFacilityId).template).nativeCiv);

binaries/data/mods/public/gui/session/selection_panels.js
|  50| »   »   »   switch·(data.item)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/selection_panels.js
|  61| »   »   switch·(data.item)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/selection_panels.js
| 729| »   »   »   »   »   »   switch·(entity.check)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2381/display/redirect

It is something that we obviously need at the current stage of development, 24 do not support anymore.

Well, I don't know much about the code, so I can't give a technical opinion here if is correct or not.

It seems to work well and maintain the exact proportions.

It doesn't quite look right when producing something, and further the border is cut weirdly.

I guess there's no real way to squeeze one more column though, which I'd prefer. The dominance of the middle panel looked quite nice imo.

I recall Freagarach has a diff for tabs somewhere.

Edit -> specifically

It doesn't quite look right when producing something, and further the border is cut weirdly.

Well spotted, thanks for pointing that out! Those two things are now fixed:

I guess there's no real way to squeeze one more column though, which I'd prefer. The dominance of the middle panel looked quite nice imo.

The alternative is shrinking the icon sizes instead.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2411/display/redirect

In D2806#119849, @wraitii wrote:

I recall Freagarach has a diff for tabs somewhere.

I don't think I managed to get further than a ticket (#5613) actually.

I have to say - I would much prefer to not merge this :/
I think it's somewhat uglier, and somewhat less convenient given the space it takes.
I also think people will want to fill that empty row with new buildings, and we'll end up with building creep.
I think we already have too many buildings :/ .

With regards to adding new buildings:

• Do we really need 3+ different towers? It seems to me we could remove the "intermediate" tower.

Again, the alternative is keeping the panel as is and reducing the icon size instead. I could make a patch for that, allowing you to compare the two and decide which one is the least ugly. The current limit of 24 is increasingly problematic, though, not just for the public default, but also for mods.

Do we really need 3+ different towers? It seems to me we could remove the "intermediate" tower.

Personally I think those new city phase towers shouldn't have been enabled (rP23094, rP23159, rP23160, rP23179), they're a mess, hence D2495.

In D2806#123297, @Nescio wrote:

Again, the alternative is keeping the panel as is and reducing the icon size instead.

There is of course the 3rd alternative of doing panels like Freagarach suggests.
24 buildings for an RTS seems like it should be workable enough to me, at least for the public mod. I don't mind having the capability to do more. Ideally you could just change a constant somewhere and the code would self-adjust.

I could make a patch for that, allowing you to compare the two and decide which one is the least ugly.

I think scaling down might be more scalable, if you want to give it a go.

Personally I think those new city phase towers shouldn't have been enabled (rP23094, rP23159, rP23160, rP23179), they're a mess, hence D2495.

If we were to disable those, then we wouldn't be pressed to merge this, correct? I'll give that patch a look.

If we were to disable those, then we wouldn't be pressed to merge this, correct? I'll give that patch a look.

No, currently the civ with the most structures is kush, at 24, and they didn't receive any new towers.