Page MenuHomeWildfire Games

Implement Bulk and use it in the pathfinder.
Needs ReviewPublic

Authored by phosit on Jul 6 2023, 8:45 PM.

Details

Reviewers
wraitii
Summary

In theory there are many advantages:
There is only one SharedState -> packaged dynamic allocation.
There is only one Future -> less std::mutexes; less std::condition_variable
All callables are pushed at the same time -> the std::mutex in the TaskManager is locked less often.

In practice i don't see much speed improvement.
A difference i see is that the "branches" are better distributed across the threads. Thus the worst case is faster. In the pathfinder the worst case is likely not important since thous are done between the turns.

Test Plan

Agree on the design.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

phosit requested review of this revision.Jul 6 2023, 8:45 PM
phosit created this revision.