One thing that could be objected to is the removal of translateMessage for TimeNotifications, because mods typically don't have the capability to provide translations, hence tinygettext will complain about not finding translations for these strings.
But those tinygettext messages are not visible onscreen, they're not even in mainlog.html, they also occur for any untranslated string, and at last mods can provide custom po/pot files too, and having that translateMessage argument so far has not shown any benefit (all messages except upgrade have it and upgrade forgot it). I can find many examples actually where mods provide custom game data including strings that are expected to be translatable - for instance mapname and mapdescription.
It seems if that was a design choice to provide custom strings that arent translated, we'd have to rewrite about most of the game. That may or may not be done at some time, but then again it doesn't seem necessary to do that if tinygettext messages about lack of translations are not going to be shown.

Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

Can you document the use of timeParameter somewhere?

Change 12 hour Last-Man-Standing TimeNotification timeout to Infinity.

Because it feels like infinity or is treated code-wise as infinity?

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Update.

@Polakrity sorry I never saw your answer hence why you never got one.

Patch is compleat and useful.

Build failure - The Moirai have given mortals hearts that can endure.

Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

Notice that no other "aichat" GUIinterface notifications use wrong translation parameters.

There are more than that. For example the developer overlay opening chat message, or PETRA.chatNewTradeRoute, PETRA.chatNewPhase, ...
And then theres more and more, and I got yet another 800 line patch, so yet another diff.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

There is also this in components/Player.js in Player.prototype.SubtractResourcesOrNotify:

		if (i < 1)
			warn("Amounts needed but no amounts given?");
		else if (i == 1)
			msg = markForTranslation("Insufficient resources - %(resourceAmount1)s %(resourceType1)s");
		else if (i == 2)
			msg = markForTranslation("Insufficient resources - %(resourceAmount1)s %(resourceType1)s, %(resourceAmount2)s %(resourceType2)s");
		else if (i == 3)
			msg = markForTranslation("Insufficient resources - %(resourceAmount1)s %(resourceType1)s, %(resourceAmount2)s %(resourceType2)s, %(resourceAmount3)s %(resourceType3)s");
		else if (i == 4)
			msg = markForTranslation("Insufficient resources - %(resourceAmount1)s %(resourceType1)s, %(resourceAmount2)s %(resourceType2)s, %(resourceAmount3)s %(resourceType3)s, %(resourceAmount4)s %(resourceType4)s");
		else
			warn("Localisation: Strings are not localised for more than 4 resources");

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Didn't know push returned the array size :D now I do.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

For in seems to be faster in most cases and safer.

14000000 iterations

Running the file following file

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

Combine return statement.

Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

Objectives dialog after disconnect, the caption of the button is visible but the sprite of the button is not, this must be a C++ bug, like the one subject to D148.

Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

• Allow healers to be functional on a chariot.
• Some inlines.

Successful build - Chance fights ever on the side of the prudent.