Details

Reviewers

None

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP23997: Add some missing credits

Summary

This patch updates a few of the gui/credits/texts/*.json files:

The following persons are inserted under balancing:
- @Alexandermb because of rP23285.
- @Feldfeld because of D2839/rP23840.
- @LordGood because of rP23094, rP23159, rP23160, rP23179.
- @Stan because of rP22802.
The balancing and history “heads” are merged with their lists. While they probably were important years ago, nowadays these heads are shining through their absence, and listing them separately is not reflective of the current situation. Besides, there is a special.json credits file for special thanks.

If anyone else is missing, please let me know!

Test Plan

Agree.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jul 17 2020, 11:04 AM

Owners added a subscriber: Restricted Owners Package.Jul 17 2020, 11:04 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2675/display/redirect

Stan added inline comments.Jul 17 2020, 11:12 AM

binaries/data/mods/public/gui/credits/texts/history.json

6 ↗

(On Diff #12735)

I actually didn't had his name because he told me not to:

While I would like to remain unrecognized on the actual forum, maybe you could credit the society as "The European Castalia Society" under 'Miscellaneous' ?
...
So if next Alpha goes out without my new voices, then just credit the society as "The European Castalia Society" under 'Miscellaneous ' like we spoke of some time ago;

So I do not know.

binaries/data/mods/public/gui/credits/texts/programming.json

5 ↗

(On Diff #12735)

I think removing them is kinda disrespectful...

Imarok added a subscriber: Imarok.Jul 17 2020, 11:13 AM

Imarok added inline comments.

binaries/data/mods/public/gui/credits/texts/history.json
22 ↗	(On Diff #12735)	Can't see a reason for this deletion.

Nescio added inline comments.Jul 17 2020, 11:17 AM

binaries/data/mods/public/gui/credits/texts/history.json
6 ↗	(On Diff #12735)	Thanks, that's not clear from rP23179.
6 ↗	(On Diff #12735)	rP23244
22 ↗	(On Diff #12735)	See "Anaxandridas ho Skandiates" entry (and summary).

Harbormaster completed remote builds in B12449: Diff 12735.Jul 17 2020, 11:22 AM

Don't name @Anaxandridas ho Skandiates.

Nescio added inline comments.Jul 17 2020, 11:23 AM

binaries/data/mods/public/gui/credits/texts/programming.json
5 ↗	(On Diff #12735)	See `special.json` file.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2676/display/redirect

Nescio added inline comments.Jul 17 2020, 11:38 AM

binaries/data/mods/public/gui/credits/texts/special.json
7–8 ↗	(On Diff #12739)	It would be nice to display at least a birth and death year for them.

I think the move for existing credits is somewhat debatable, I'd prefer if you only added missing credits for now @Nescio , would be easier to commit :)

binaries/data/mods/public/gui/credits/texts/special.json
44 ↗	(On Diff #12739)	I don't think Ykkrosh was ever programming manager officially, nor leper.

Harbormaster completed remote builds in B12453: Diff 12739.Jul 17 2020, 11:46 AM

keep programming managers as is

Nescio added inline comments.Jul 17 2020, 11:57 AM

binaries/data/mods/public/gui/credits/texts/programming.json
5 ↗	(On Diff #12735)	Are these people still managing programming? If not, then labelling them as such is misleading and not reflective of the current situation. It could be renamed to "Former programming managers", but then it begs the question who's currently doing it.