Start the game. Move units at long distances and short distances.

I got myself 100 British swordsmen and we walked around the "Sahel Watering Holes" map a bit, but couldn't find any unusual activity.

I did not find major flaw in the code.
Female citizens are displayed as trainable from all structures and their costs are now correct.
Units trainable from ships display all trainers.
D3341 now works without civ element hack.

No more crash after disabling the AI. Replays work, airplanes work.

I tested on pushing demo tried to add obstacles on giant maps. Tried quicksave and quickload. Save and load work on Combat huge. All fine.

Breaks gates, not sure why.

It's not missing it but it's indeed too big

The icon is missing the bottom gray border. This creates the feeling that the icon is different in size from others.

Could add some tests?

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Fallback for linear DeathDamage.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Other way of putting things.

Looks alright, does it work? :P

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Indentation, add choice while at it.

@vladislavbelov thoughts? It looks okayish now

Tested by @gameboy: https://wildfiregames.com/forum/topic/38131-tutorial-bug/.

Not sure what I did with ffm_visiblity but I got this

In D2967#166312, @Stan wrote:

Well each time you'll reach the limit you'll get kicked out of the game have to press continue until it happens again.

Well each time you'll reach the limit you'll get kicked out of the game have to press continue until it happens again.

(Since it has been reverted.)

Can you check PCH ? According to Vladislav it's still broken in svn nad I see potential missing includes in that patch :)

In D3842#166293, @Stan wrote:

What's the gain? Shorter code?

It's safer, because if one changes things one cannot forgot to call delete somewhere with this version.

Reverted in rP25246.

What's the gain? Shorter code?

To reproduce: start Acropolis Bay skirmish map with an AI.

Beginning with this changeset I get a segmentation fault, when starting a match.

In rP25229#50711, @vladislavbelov wrote:

In rP25229#50703, @Langbart wrote:

I have noticed some difficulties with the minimap buttons.

Please, try a newer revision, at least rP25241.

fixed with rP25245

Fixed in rP25245

In rP25229#50703, @Langbart wrote:

I have noticed some difficulties with the minimap buttons.

Please, try a newer revision, at least rP25241.

I get many errors when loading the "Units demo" scenario map with this changeset.

I have noticed some difficulties with the minimap buttons.

Build is unstable, some tests have failed - The Moirai have given mortals hearts that can endure.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

I think hashable weak_ptr is better but it looks like we won't get that until C++23, so for now I'll go with this.

It seems like you'd better use the new features introduced by @wraitii for this.

I'm not sure what this does? It also seems to not work right, I can't see the "random" option?

@wraitii

In rP25241#50693, @Freagarach wrote:

CMiniMap.cpp
../../../source/gui/ObjectTypes/CMiniMap.cpp: In function ‘void {anonymous}::CropPointsByCircle(const std::array<CVector3D, 4>&, const CVector3D&, float, std::vector<CVector3D>*)’:
../../../source/gui/ObjectTypes/CMiniMap.cpp:78:14: warning: unused variable ‘radiusSquared’ [-Wunused-variable]
  const float radiusSquared = radius * radius;
              ^~~~~~~~~~~~~

I'll fix it, thx.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Reduce duplication in return resource order.