Page MenuHomeWildfire Games
Feed All Stories

Wed, May 11

Vulcan added a comment to D4626: add parentheses overlooked in rP26520.

Successful build - Chance fights ever on the side of the prudent.

Wed, May 11, 1:29 PM
Vulcan added a comment to D4626: add parentheses overlooked in rP26520.

Successful build - Chance fights ever on the side of the prudent.

Wed, May 11, 1:26 PM
marder updated the diff for D4626: add parentheses overlooked in rP26520.

style

Wed, May 11, 1:16 PM
smiley added inline comments to D4644: Remove own generate_uniform_real implementation from boost.
Wed, May 11, 11:24 AM
Freagarach added a comment to D4642: Add EGL support for Wayland.

X11 functions, including screenshots. :)

Wed, May 11, 9:23 AM
vladislavbelov added inline comments to D4644: Remove own generate_uniform_real implementation from boost.
Wed, May 11, 8:31 AM
Freagarach committed rP26872: Fix maps after r26298 / rP26298..
Fix maps after r26298 / rP26298.
Wed, May 11, 8:04 AM
Freagarach closed D4486: Fix maps after rP26298..
Wed, May 11, 8:04 AM
Freagarach added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

@Stan Have any instructions for Linux?

git diff --no-prefix -U9999 according to The Internet.
Also, please set the repository correctly when manually uploading the patch. That way our linter can tell you part of our coding conventions. :)

Wed, May 11, 7:56 AM
autobuild committed rP26871: [Windows] Automated build..
[Windows] Automated build.
Wed, May 11, 6:05 AM

Tue, May 10

smiley added inline comments to D4628: Fix non-visual autostart, as well as client/host autostart..
Tue, May 10, 9:17 PM
Vulcan added a comment to D4628: Fix non-visual autostart, as well as client/host autostart..

Successful build - Chance fights ever on the side of the prudent.

Tue, May 10, 7:21 PM
Vulcan added a comment to D4628: Fix non-visual autostart, as well as client/host autostart..

Successful build - Chance fights ever on the side of the prudent.

Tue, May 10, 7:18 PM
wraitii updated the diff for D4628: Fix non-visual autostart, as well as client/host autostart..

Always load the network JSI functions.

Tue, May 10, 6:48 PM
wraitii added inline comments to D4628: Fix non-visual autostart, as well as client/host autostart..
Tue, May 10, 6:43 PM
Harbormaster failed to build B20293: rP26870: Avoids drawing text in GUI if it will be clipped. for rP26870: Avoids drawing text in GUI if it will be clipped.!
Tue, May 10, 6:42 PM
wraitii added inline comments to D4575: Implement ES6 Module Loading.
Tue, May 10, 6:37 PM
vladislavbelov committed rP26870: Avoids drawing text in GUI if it will be clipped..
Avoids drawing text in GUI if it will be clipped.
Tue, May 10, 6:32 PM
vladislavbelov closed D4640: Avoids drawing text in GUI if it will be clipped.
Tue, May 10, 6:32 PM
smiley added a comment to D4575: Implement ES6 Module Loading.

Assertion failure: aDst + aNElem <= aSrc || aSrc + aNElem <= aDst (destination and source must not overlap)

Tue, May 10, 6:31 PM
Vulcan added a comment to D4575: Implement ES6 Module Loading.

Build failure - The Moirai have given mortals hearts that can endure.

Tue, May 10, 6:27 PM
phosit added inline comments to D4642: Add EGL support for Wayland.
Tue, May 10, 6:26 PM
Vulcan added a comment to D4575: Implement ES6 Module Loading.

Successful build - Chance fights ever on the side of the prudent.

Tue, May 10, 6:25 PM
smiley retitled D4575: Implement ES6 Module Loading from [WIP] Implement ES Module Loading to [WIP] Implement ES6 Module Loading.
Tue, May 10, 6:19 PM
Vulcan added a comment to D4575: Implement ES6 Module Loading.

Build failure - The Moirai have given mortals hearts that can endure.

Tue, May 10, 6:10 PM
smiley added inline comments to D4575: Implement ES6 Module Loading.
Tue, May 10, 6:05 PM
smiley updated the diff for D4575: Implement ES6 Module Loading.

Fix build

Tue, May 10, 5:59 PM
smiley added inline comments to D4644: Remove own generate_uniform_real implementation from boost.
Tue, May 10, 4:53 PM
Langbart resigned from rP26269: Remove leftover terrain-based movement cost code..

see D4627
"Needs another fix to be tested so trust me bro ™"
ok

Tue, May 10, 4:27 PM
Vulcan added a comment to D4575: Implement ES6 Module Loading.

Build failure - The Moirai have given mortals hearts that can endure.

Tue, May 10, 4:01 PM
vladislavbelov added inline comments to D4644: Remove own generate_uniform_real implementation from boost.
Tue, May 10, 3:57 PM
Vulcan added a comment to D4575: Implement ES6 Module Loading.

Successful build - Chance fights ever on the side of the prudent.

Tue, May 10, 3:52 PM
Vulcan added a comment to D4575: Implement ES6 Module Loading.

Build failure - The Moirai have given mortals hearts that can endure.

Tue, May 10, 3:37 PM
Stan added a comment to D4644: Remove own generate_uniform_real implementation from boost.

I didn't check but do we know we don't have an old distro we support with a stupidly old boost, in which case we should add a safeguard ? Like nvtt.

Tue, May 10, 3:37 PM
smiley requested review of D4644: Remove own generate_uniform_real implementation from boost.
Tue, May 10, 3:34 PM
smiley updated the diff for D4575: Implement ES6 Module Loading.

AutoCheckCannotGC needs a scope

Tue, May 10, 3:16 PM
Harbormaster failed to build B20289: rP26869: Fixes shader program and technique reloading. for rP26869: Fixes shader program and technique reloading.!
Tue, May 10, 3:09 PM
smiley added a reverting change for rP11857: Replace boost::uniform_real to avoid OOS caused by changes in behaviour between…: D4644: Remove own generate_uniform_real implementation from boost.
Tue, May 10, 2:57 PM
vladislavbelov committed rP26869: Fixes shader program and technique reloading..
Fixes shader program and technique reloading.
Tue, May 10, 2:55 PM
vladislavbelov closed D4641: Fixes shader program and technique reloading.
Tue, May 10, 2:55 PM
vladislavbelov added inline comments to D4641: Fixes shader program and technique reloading.
Tue, May 10, 2:50 PM
Stan added a comment to D3998: [PetraAI] - Implement an emergency mode in case of huge losses..

You don't have to abandon you can just overwrite :)

Tue, May 10, 2:38 PM
Vulcan added a comment to D4575: Implement ES6 Module Loading.

Build failure - The Moirai have given mortals hearts that can endure.

Tue, May 10, 1:59 PM
Vulcan added a comment to D4575: Implement ES6 Module Loading.

Build is unstable, some tests have failed - The Moirai have given mortals hearts that can endure.

Tue, May 10, 1:57 PM
Vulcan added a comment to D4575: Implement ES6 Module Loading.

Build failure - The Moirai have given mortals hearts that can endure.

Tue, May 10, 1:39 PM
smiley updated the diff for D4575: Implement ES6 Module Loading.

Add tests

Tue, May 10, 1:31 PM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

@wraitii Ok, thanks for the help :)

Tue, May 10, 12:47 PM
JCWasmx86 abandoned D3998: [PetraAI] - Implement an emergency mode in case of huge losses..

I will redo this, as the code here is an unreadable mess, same for the commit history

Tue, May 10, 12:42 PM
Mercury updated the diff for D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

style conformity changes, no semantic change.

Tue, May 10, 12:39 PM
phosit added a comment to D4642: Add EGL support for Wayland.

With SDL_VIDEODRIVER=wayland(or disabeling xwayland) sdl_video_backend is Wayland and without x11.
After using atlas sdl_video_backend is none.
Screenshots work in the game and atlas.

Tue, May 10, 12:31 PM
wraitii added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

Think this approach is workable, will let freagarach take over :)

Tue, May 10, 12:23 PM
Mercury updated the diff for D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

Remove DamageTaken, add attacker and attackerOwner to HealthChanged

Tue, May 10, 12:14 PM
Vulcan added a comment to D4642: Add EGL support for Wayland.

Successful build - Chance fights ever on the side of the prudent.

Tue, May 10, 12:01 PM
Vulcan added a comment to D4642: Add EGL support for Wayland.

Successful build - Chance fights ever on the side of the prudent.

Tue, May 10, 11:58 AM
vladislavbelov updated the test plan for D4642: Add EGL support for Wayland.
Tue, May 10, 11:57 AM
Langbart added a comment to D4640: Avoids drawing text in GUI if it will be clipped.

Apply the patch and compile the game

ok

Check that text input and multiline text are correctly clipped

I did not encounter any problems.

Tue, May 10, 11:54 AM
vladislavbelov updated the diff for D4642: Add EGL support for Wayland.
Tue, May 10, 11:40 AM
wraitii added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

So If I add changeOrigin to Reduce and to RegisterHealthChanged then I could add it to the HealthChanged message.
Does this sound good? If so should I pass attackerOwner along with it?

Tue, May 10, 11:37 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

HealthChanged is fired in RegisterHealthChanged
RegisterHealthChanged is called in Reduce
Reduce is called in TakeDamage
TakeDamage has attacker

Tue, May 10, 11:35 AM
Langbart added a comment to D4641: Fixes shader program and technique reloading.

Apply the patch and compile the game
Run the game

ok

Change something in shaders

Changing binaries/data/mods/public/shaders/glsl/common/debug_fragment.h while the game is running

  • from return vec3(alpha);
  • to return vec3(1.0, 0.8, 0.0) * (1.0 - alpha);

It would crash without the patch being applied.
With the patch, a crash could no longer be observed and the colour change takes place correctly within the game window.

Tue, May 10, 11:23 AM
wraitii added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

Hm, hadn't though of loot. Your right, that's more annoying.

Tue, May 10, 11:11 AM
Stan added a comment to D4642: Add EGL support for Wayland.

Missing extensions/egl.txt

Tue, May 10, 11:06 AM
vladislavbelov updated the summary of D4642: Add EGL support for Wayland.
Tue, May 10, 11:03 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

@wraitii Another issue with storing which entity they died trying to get out of is that the entity might not be destroyed at that moment.

Tue, May 10, 10:58 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

@wraitii Storing in the stats tracker and integrating at the end sounds ok. It won't assign loot.

Tue, May 10, 10:01 AM
Stan added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

Refs D3186.

Tue, May 10, 9:51 AM
wraitii abandoned D4632: Revert rP26298, put civ historical data back in the JSON file..

I think we found a better idea, see comments in the fixing diff that ended up being committed.

Tue, May 10, 9:34 AM
wraitii added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

As for some knowledge drop:

SendGlobalMessage(ent, msg);
that doesn't seem right? The messages are sent to the components they are supposed to go to on line 990?

Tue, May 10, 9:31 AM
Stan added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

By the way, your patch is missing context. You need to configure arcanist to show more https://trac.wildfiregames.com/wiki/Phabricator#OnWindows

Tue, May 10, 9:27 AM
wraitii added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

Looking at source/simulation2/system/ComponentManager.cpp line 974 it seems to be saying that when you provide an entity to PostMessage only the components of that entity will be notified.

Tue, May 10, 9:27 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

oh wait, the last line of
void CComponentManager::PostMessage(entity_id_t ent, const CMessage& msg)
is
SendGlobalMessage(ent, msg);

Tue, May 10, 9:18 AM
Stan added inline comments to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.
Tue, May 10, 9:18 AM
wraitii accepted D4486: Fix maps after rP26298..
Tue, May 10, 9:17 AM
Stan added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

Looking at source/simulation2/system/ComponentManager.cpp line 974 it seems to be saying that when you provide an entity to PostMessage only the components of that entity will be notified.

Sorry to be a talking back to you like this as a newcomer to the project :/

Tue, May 10, 9:16 AM
Stan added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.
In D4643#197397, @Stan wrote:

maybe we need a performance test map that includes garrisoned buildings, healers, heroes, garrisoned ships ect, so one can use the in game profiler for a quick test?

Tue, May 10, 9:14 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

Looking at source/simulation2/system/ComponentManager.cpp line 974 it seems to be saying that when you provide an entity to PostMessage only the components of that entity will be notified.

Tue, May 10, 9:11 AM
marder added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.
In D4643#197397, @Stan wrote:
Tue, May 10, 9:08 AM
Stan added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

Do not know. It has to be checked using the profiler. See https://trac.wildfiregames.com/wiki/EngineProfiling#In-gameprofiler and https://trac.wildfiregames.com/wiki/Profiler2

Tue, May 10, 9:04 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

@Stan would something like

Tue, May 10, 9:01 AM
nwtour removed 1 auditor(s) for rP26868: [Windows] Automated build.: williamsonoma.
Tue, May 10, 9:00 AM
Stan added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

In your case all entities on the map, whether they are allies, neutral or enemies will be notified.

Tue, May 10, 9:00 AM
nwtour accepted rP26868: [Windows] Automated build..
Tue, May 10, 8:59 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

@Stan Is that true when the event is targeting a single entity as well?

Tue, May 10, 8:55 AM
Stan added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

In a browser, maybe. But the implementation we have in the engine is different. Lots of entities to iterate and iteration is slow in a std::map.

Tue, May 10, 8:50 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

I put some time into thinking about how to do this without a message but didn't come up with anything better. JS event emitters are generally kinda cheap I thought? Just a hash table lookup with a JIT symbol and a run through an array of callbacks. Should cost almost nothing if there are no listeners. O(1)?

Tue, May 10, 8:44 AM
Freagarach added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

First of all, thanks for working on this. :)

Tue, May 10, 8:19 AM
Mercury updated the diff for D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

included previously unincluded files

Tue, May 10, 7:56 AM
williamsonoma raised a concern with rP26868: [Windows] Automated build..

Sometimes, you may confront numerous problems with your [[ https://www.marketplace-help.com/facebook-marketplace/

Facebook marketplace due to several ]] reasons. However, if the situation is slipping out from you hand, you should make proper utilization of Facebook Marketplace Customer Service and get the significant assistance under the supervision of the highly experienced Facebook specialists in no time.
Tue, May 10, 7:52 AM
Freagarach added a member for Contributors: Mercury.
Tue, May 10, 7:48 AM
Mercury updated the diff for D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

fixing which files are included hopefully

Tue, May 10, 7:37 AM
Mercury requested review of D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.
Tue, May 10, 7:34 AM
Vulcan added a comment to D4626: add parentheses overlooked in rP26520.

Successful build - Chance fights ever on the side of the prudent.

Tue, May 10, 7:24 AM
Vulcan added a comment to D4626: add parentheses overlooked in rP26520.

Successful build - Chance fights ever on the side of the prudent.

Tue, May 10, 7:22 AM
Freagarach updated the diff for D4626: add parentheses overlooked in rP26520.

(Sorry for spamming the diff. It was less work than expected.)

Tue, May 10, 7:18 AM
Freagarach added a comment to D4626: add parentheses overlooked in rP26520.

I'll try and rewrite the tests.

Tue, May 10, 7:13 AM
Vulcan added a comment to D4626: add parentheses overlooked in rP26520.

Successful build - Chance fights ever on the side of the prudent.

Tue, May 10, 7:12 AM
Vulcan added a comment to D4626: add parentheses overlooked in rP26520.

Successful build - Chance fights ever on the side of the prudent.

Tue, May 10, 7:11 AM
Freagarach updated the diff for D4626: add parentheses overlooked in rP26520.

Fix tests.

Tue, May 10, 7:06 AM
Vulcan added a comment to D4486: Fix maps after rP26298..

Successful build - Chance fights ever on the side of the prudent.

Tue, May 10, 7:01 AM
Vulcan added a comment to D4486: Fix maps after rP26298..

Successful build - Chance fights ever on the side of the prudent.

Tue, May 10, 6:55 AM