Can be deleted. unused.

or disconnected. > according to the connection state.

unneeded. from previous version.

() => {}

() => {}

Engine.LobbySetPlayerPresence("available");

initGUIObjects();

can go below !g_Settings if

hidden anyway when dialog

untrue needed for double click.

do the math

Wrong file, common/

The only other sprite in this file can be deleted afterwards. Then the entire file.

Why isnt there any context in this diff?

// Ensures that no more than one message box is opened at a time.

Given that the other gui updaters aren't called simultaneously, updateGUIConnectionState

Intersting, comma.

Putting globals in the middle of the code?

The GUI functions should be grouped, for instance

+ initDialogStyle();
+ initGameFilters();
+ updateConnectedState();

update call can be moved out of the if

You have been disconnected from the lobby. Do you want to reconnect

those too short strings already exist

After having a look at the other GUI functions, initDialogStyle seems to fit better actually

withContext

This looks better if we only assign the onPress in an if g_Dialog statement rather than a ternary with a weird empty function

This one looks preferable to me:

+ Engine.GetGUIObjectByName("gameInfoEmpty").size = "0 0 100% 100%-30" + (g_Dialog ? "" : "-30");
+ Engine.GetGUIObjectByName("gameInfo").size = "0 0 100% 100%-30" + (g_Dialog ? "" : "-60");

This one still wasn't necessary according to my tests.

to the top

the other 2 calls should have dialog = true for consistency

lol sry this was not update to date. +1

Sry was from git diff before IsXmppConnected commit. Now svn diff with context i can take. I guess, because i cant commit to the svn localy i do it with git. Can i make context diffs with git too?

two sentences i guess.

works

so what we gonna do with them

seems to be for the languages

m8 be cleaner if true ommit.

Stay. Wont work. Test escape. Cancel hotkey is escape used for leaderboard, profile search hide too. It needs to hide that first (even if not shown) and then actualy leave lobby or u get error missing variables and gui elements because of popGui for in the hiding function from that two dialog boxes. So at least cancel key must be down here. I just grouped them both here. Can be only cancelDialog hotkey here.

all calls i can find in that patch do have dialog: true/false no?

Just removing the comma should do

keep

Oh that's where the bug came from... That's not too good. We should add an XML comment then.

needs a if (Engine.StartXmppClient) check for people who compiled without lobby but felt the urge to press the hotkey

1. TODO: fixed by rP22200.

That might explain errors with GetGUIObjectByName (but not "missing variables" if that means reference errors).
nani could reproduce this error on a23b released:

(16:35:19) nani: ERROR: JavaScript error: gui/lobby/lobby.js line 871 TypeError: playerList is undefined lookupSelectedUserProfile@gui/lobby/lobby.js:871:6 setLeaderboardVisibility@gui/lobby/lobby.js:844:2 __eventhandler437 (press)@__internal(22) press:0:1

ERROR: JavaScript error: gui/lobby/lobby.js line 851 TypeError: Engine.GetGUIObjectByName(...) is undefined setUserProfileVisibility@gui/lobby/lobby.js:851:53 __eventhandler441 (press)@__internal(33) press:0:1

and I have an a23b patched with rP22200, so I suspect it was that.

We see that even playerList does not throw a referene error but it complains about it being undefined, and the value comes from
let playerList = Engine.GetGUIObjectByName(guiObjectName);
So it seems like all of the complained values come from this GetGUIObjectByName, so it must have been that commit.

2. Second TODO:

There is another issue, that pressing escape when the page is a dialog closes both the lobby page and the leaderboard page / profile page. But there should only be one page closed per press. This can actually be fixed by reassigning the same hotkey value instead of using the hotkey for 3 objects, (for example 1 gui object or Engine.SetGlobalHotkey from rP22851)

First TODO removal and second TODO fix in D2412.

There is another issue, that pressing escape when the page is a dialog closes both the lobby page and the leaderboard page / profile page. But there should only be one page closed per press. This can actually be fixed by reassigning the same hotkey value instead of using the hotkey for 3 objects, (for example 1 gui object or Engine.SetGlobalHotkey from rP22851)

Leaderboard page / profile page are not really pages but overlays of the same page

I don't know what to respond to that.

No need, just stating that they are just overlays not real pages. ?

In the lobby you meant that if it would use PushGUIPage / PopGUIPage, then the "double-close" issue wouldn't happen, so that's true and perhaps it can be changed to that eventually (or perhaps not for performance reasons?)

But before then we need a way to have one page update the other page (thats needed for gamesetup aiconfig page too), since the leaderboardpage uses the profile panel of the lobby page (though that way around its different from gamesetup/aiconfig and session/networkpage). Anyway, I got it bandaged in D2412 for now by reassigning the cancel hotkey upon opening and closing the page.