Regarding static_cast<off_t>(expr): I admit I never got around with the various kinds of casts offered by C++ (when I design SW on my own, I try and avoid casting alltogether). When updating the patch, I can still put it in.

Oct 5 2019, 10:26 PM

Teiresias added a comment to D1511: Patch to solve ticket #5165 (Zip files with comments trip assertion on game startup).

I am sorry, I lost track of this ticket for health reasons. Regarding your questions, it seems I was so occupied by the zip archive problem that I neglected styleguide and common appearance. Here are attempts to answer your observations:

Oct 5 2019, 10:17 PM

Freagarach raised a concern with rP13541: Display current/max gatherers or builders when a resource or foundation is….

Oct 5 2019, 10:12 PM

Freagarach added inline comments to rP13541: Display current/max gatherers or builders when a resource or foundation is….

Oct 5 2019, 10:09 PM

elexis raised a concern with rP21953: New Kushite Background by Pedro Blanco.

The balcony is not scaled depending on window size while everything else is, so it gives the wrong ratio depending on used window size.

Oct 5 2019, 10:06 PM

elexis added a comment to D2355: Rewrite session chat to use class syntax / object-oriented programming.

Next upload includes:

Oct 5 2019, 9:35 PM

vladislavbelov updated the summary of D2356: Adds BMPBlockWriter to prevent huge memory allocation.

Oct 5 2019, 9:02 PM

Vulcan added a comment to D2358: Fix promoted entities not retaining order queue after rP22753..

Successful build - Chance fights ever on the side of the prudent.

Oct 5 2019, 8:52 PM

Freagarach added a comment to rP22753: Make Promotion.js use the common Transform helper, add resource gatherer and….

Was broken because previously the cheer order was added first and the rest of the orders thereafter. As per this commit that order was reversed, and the (faulty) cmpUnitAI.Cheer() did not push an order to the front but it replaced all orders (which it should not). D2358.

Oct 5 2019, 8:50 PM

Freagarach added inline comments to D2358: Fix promoted entities not retaining order queue after rP22753..

Oct 5 2019, 8:47 PM

Vulcan added a comment to D2358: Fix promoted entities not retaining order queue after rP22753..

Successful build - Chance fights ever on the side of the prudent.

Oct 5 2019, 8:47 PM

Freagarach created D2358: Fix promoted entities not retaining order queue after rP22753..

Oct 5 2019, 8:45 PM

elexis added a comment to D2357: Adds ScreenshotWriter to minimise code duplication.

Tested and seems to work on first sight, no compile warnings with clang 8.0.1.

Oct 5 2019, 8:24 PM

elexis removed 1 auditor(s) for rP22804: Cypresses, maritime pines, emergent teak variant, grasses ptolemaic tower…: minohaka.

Oct 5 2019, 7:42 PM

elexis removed 1 auditor(s) for rP23040: Elephant re-export and animations for the riders.: elexis.

Thanks for the fix!

Oct 5 2019, 7:42 PM

Freagarach added inline comments to rP22753: Make Promotion.js use the common Transform helper, add resource gatherer and….

Oct 5 2019, 7:35 PM

Stan added inline comments to D2355: Rewrite session chat to use class syntax / object-oriented programming.

Oct 5 2019, 7:21 PM

elexis added inline comments to D2355: Rewrite session chat to use class syntax / object-oriented programming.

Oct 5 2019, 7:05 PM

vladislavbelov added inline comments to D2357: Adds ScreenshotWriter to minimise code duplication.

Oct 5 2019, 6:50 PM

Stan added inline comments to D2357: Adds ScreenshotWriter to minimise code duplication.

Oct 5 2019, 6:47 PM

Vulcan added a comment to D2357: Adds ScreenshotWriter to minimise code duplication.

Successful build - Chance fights ever on the side of the prudent.

Oct 5 2019, 6:34 PM

Harbormaster failed remote builds in B9752: Diff 10089 for D2357: Adds ScreenshotWriter to minimise code duplication!

Oct 5 2019, 6:29 PM

Vulcan added a comment to D2357: Adds ScreenshotWriter to minimise code duplication.

Build failure - The Moirai have given mortals hearts that can endure.

Oct 5 2019, 6:28 PM

vladislavbelov created D2357: Adds ScreenshotWriter to minimise code duplication.

Oct 5 2019, 6:28 PM

Harbormaster failed to build B9751: rP23060: Fix "Didn't find any objects in the scene" in elephant_asian_armored_03.dae for rP23060: Fix "Didn't find any objects in the scene" in elephant_asian_armored_03.dae!

Oct 5 2019, 5:32 PM

Alexandermb committed rP23060: Fix "Didn't find any objects in the scene" in elephant_asian_armored_03.dae.

Fix "Didn't find any objects in the scene" in elephant_asian_armored_03.dae

Oct 5 2019, 5:25 PM

Harbormaster failed to build B9750: rP23059: Remove duplicated vertex groups and props from elephants for rP23059: Remove duplicated vertex groups and props from elephants!

Oct 5 2019, 5:01 PM

Vulcan added a comment to D2356: Adds BMPBlockWriter to prevent huge memory allocation.

Successful build - Chance fights ever on the side of the prudent.

Oct 5 2019, 4:56 PM

Harbormaster failed remote builds in B9749: Diff 10088 for D2356: Adds BMPBlockWriter to prevent huge memory allocation!

Oct 5 2019, 4:53 PM

Vulcan added a comment to D2356: Adds BMPBlockWriter to prevent huge memory allocation.

Build failure - The Moirai have given mortals hearts that can endure.

Oct 5 2019, 4:53 PM

Alexandermb committed rP23059: Remove duplicated vertex groups and props from elephants.

Remove duplicated vertex groups and props from elephants

Oct 5 2019, 4:51 PM

vladislavbelov updated the diff for D2356: Adds BMPBlockWriter to prevent huge memory allocation.

Oct 5 2019, 4:49 PM

Stan added inline comments to D2356: Adds BMPBlockWriter to prevent huge memory allocation.

Oct 5 2019, 4:42 PM

vladislavbelov added inline comments to D2356: Adds BMPBlockWriter to prevent huge memory allocation.

Oct 5 2019, 4:37 PM

Stan added inline comments to D2356: Adds BMPBlockWriter to prevent huge memory allocation.

Oct 5 2019, 4:33 PM

Vulcan added a comment to D2356: Adds BMPBlockWriter to prevent huge memory allocation.

Successful build - Chance fights ever on the side of the prudent.

Oct 5 2019, 4:33 PM

Harbormaster failed remote builds in B9748: Diff 10087 for D2356: Adds BMPBlockWriter to prevent huge memory allocation!

Oct 5 2019, 4:33 PM

Vulcan added a comment to D2356: Adds BMPBlockWriter to prevent huge memory allocation.

Build failure - The Moirai have given mortals hearts that can endure.

Oct 5 2019, 4:32 PM

vladislavbelov updated the diff for D2356: Adds BMPBlockWriter to prevent huge memory allocation.

Removes unused variables.

Oct 5 2019, 4:26 PM

Harbormaster failed to build B9747: rP23058: Fix weight on ship sails missing in the mastiff. for rP23058: Fix weight on ship sails missing in the mastiff.!

Oct 5 2019, 4:25 PM

Alexandermb committed rP23058: Fix weight on ship sails missing in the mastiff..

Fix weight on ship sails missing in the mastiff.

Oct 5 2019, 4:20 PM

vladislavbelov added inline comments to D2356: Adds BMPBlockWriter to prevent huge memory allocation.

Oct 5 2019, 4:17 PM

Stan added inline comments to D2356: Adds BMPBlockWriter to prevent huge memory allocation.

Oct 5 2019, 4:10 PM

Vulcan added a comment to D2356: Adds BMPBlockWriter to prevent huge memory allocation.

Successful build - Chance fights ever on the side of the prudent.

Oct 5 2019, 4:07 PM

Harbormaster failed remote builds in B9746: Diff 10086 for D2356: Adds BMPBlockWriter to prevent huge memory allocation!

Oct 5 2019, 4:05 PM

Vulcan added a comment to D2356: Adds BMPBlockWriter to prevent huge memory allocation.

Build failure - The Moirai have given mortals hearts that can endure.

Oct 5 2019, 4:05 PM

vladislavbelov updated the diff for D2356: Adds BMPBlockWriter to prevent huge memory allocation.

Oct 5 2019, 4:02 PM

Vulcan added a comment to D2356: Adds BMPBlockWriter to prevent huge memory allocation.

Successful build - Chance fights ever on the side of the prudent.

Oct 5 2019, 3:58 PM

Harbormaster failed remote builds in B9745: Diff 10085 for D2356: Adds BMPBlockWriter to prevent huge memory allocation!

Oct 5 2019, 3:57 PM

Vulcan added a comment to D2356: Adds BMPBlockWriter to prevent huge memory allocation.

Build failure - The Moirai have given mortals hearts that can endure.

Oct 5 2019, 3:57 PM

vladislavbelov updated the diff for D2356: Adds BMPBlockWriter to prevent huge memory allocation.

Fixes @elexis `s notes.

Oct 5 2019, 3:52 PM

Harbormaster failed to build B9744: rP23057: Remove unused animation and tweak levy idle ready. for rP23057: Remove unused animation and tweak levy idle ready.!

Oct 5 2019, 3:30 PM

Harbormaster failed to build B9743: rP23056: Replace gather meat animation on camel riders. for rP23056: Replace gather meat animation on camel riders.!

Oct 5 2019, 3:25 PM

Alexandermb committed rP23057: Remove unused animation and tweak levy idle ready..

Remove unused animation and tweak levy idle ready.

Oct 5 2019, 3:21 PM

Alexandermb committed rP23056: Replace gather meat animation on camel riders..

Replace gather meat animation on camel riders.

Oct 5 2019, 3:19 PM

Vulcan added a comment to D2356: Adds BMPBlockWriter to prevent huge memory allocation.

Successful build - Chance fights ever on the side of the prudent.

Oct 5 2019, 3:15 PM

Vulcan added a comment to D2356: Adds BMPBlockWriter to prevent huge memory allocation.

Successful build - Chance fights ever on the side of the prudent.

Oct 5 2019, 2:53 PM

vladislavbelov added inline comments to D2356: Adds BMPBlockWriter to prevent huge memory allocation.

Oct 5 2019, 2:46 PM

vladislavbelov created D2356: Adds BMPBlockWriter to prevent huge memory allocation.

Oct 5 2019, 2:45 PM

Harbormaster failed to build B9741: rP23055: Add missing garrisoned flag on the cart temple missing since rP18939 for rP23055: Add missing garrisoned flag on the cart temple missing since rP18939!

Oct 5 2019, 2:32 PM

Stan committed rP23055: Add missing garrisoned flag on the cart temple missing since rP18939.

Add missing garrisoned flag on the cart temple missing since rP18939

Oct 5 2019, 2:27 PM

Vulcan added a comment to D2355: Rewrite session chat to use class syntax / object-oriented programming.

Successful build - Chance fights ever on the side of the prudent.

Oct 5 2019, 12:46 PM

elexis raised a concern with rP22753: Make Promotion.js use the common Transform helper, add resource gatherer and….

Thanks for the fix. It would be good to compare the implementation against the paste some day.

Or the new implementation against the removed implementation.

Oct 5 2019, 12:45 PM

Vulcan added a comment to D2355: Rewrite session chat to use class syntax / object-oriented programming.

Successful build - Chance fights ever on the side of the prudent.

Oct 5 2019, 12:43 PM

elexis updated the diff for D2355: Rewrite session chat to use class syntax / object-oriented programming.

Use markForTranslation with chat filters too, fix excess semicolons.

Oct 5 2019, 12:41 PM

elexis added inline comments to D2355: Rewrite session chat to use class syntax / object-oriented programming.

Oct 5 2019, 12:37 PM

Stan added inline comments to D2355: Rewrite session chat to use class syntax / object-oriented programming.

Oct 5 2019, 12:23 PM

elexis updated the summary of D2355: Rewrite session chat to use class syntax / object-oriented programming.

Oct 5 2019, 12:19 PM

Vulcan added a comment to D2355: Rewrite session chat to use class syntax / object-oriented programming.

Successful build - Chance fights ever on the side of the prudent.

Oct 5 2019, 12:18 PM

Vulcan added a comment to D2355: Rewrite session chat to use class syntax / object-oriented programming.

Successful build - Chance fights ever on the side of the prudent.

Oct 5 2019, 12:16 PM

elexis created D2355: Rewrite session chat to use class syntax / object-oriented programming.

Oct 5 2019, 12:13 PM

Harbormaster failed to build B9738: rP23054: Correct button hovering following rP23020 / D2325, clarify difference between… for rP23054: Correct button hovering following rP23020 / D2325, clarify difference between…!

Oct 5 2019, 12:04 PM

elexis committed rP23054: Correct button hovering following rP23020 / D2325, clarify difference between….

Correct button hovering following rP23020 / D2325, clarify difference between…

Oct 5 2019, 11:58 AM

elexis closed D2354: Correct button hovering following rP23020 / D2325, clarify difference between IsMouseOver and IsMouseHovering following rP74.

Oct 5 2019, 11:58 AM

elexis added a comment to D2354: Correct button hovering following rP23020 / D2325, clarify difference between IsMouseOver and IsMouseHovering following rP74.

Related: CGUI::FindObjectUnderMouse, IGUIObject::ChooseMouseOverAndClosest, but Im totally not touching those now.

Oct 5 2019, 11:57 AM

vladislavbelov awarded D2354: Correct button hovering following rP23020 / D2325, clarify difference between IsMouseOver and IsMouseHovering following rP74 a Like token.

Oct 5 2019, 11:52 AM

Vulcan added a comment to D2354: Correct button hovering following rP23020 / D2325, clarify difference between IsMouseOver and IsMouseHovering following rP74.

Successful build - Chance fights ever on the side of the prudent.

Oct 5 2019, 11:48 AM

Harbormaster failed remote builds in B9737: Diff 10080 for D2354: Correct button hovering following rP23020 / D2325, clarify difference between IsMouseOver and IsMouseHovering following rP74!

Oct 5 2019, 11:46 AM

Vulcan added a comment to D2354: Correct button hovering following rP23020 / D2325, clarify difference between IsMouseOver and IsMouseHovering following rP74.

Build failure - The Moirai have given mortals hearts that can endure.

Oct 5 2019, 11:46 AM

elexis created D2354: Correct button hovering following rP23020 / D2325, clarify difference between IsMouseOver and IsMouseHovering following rP74.

Oct 5 2019, 11:46 AM

OptimusShepard added a comment to D2353: L3 Ryzen 3000 Bugfix.

In D2353#98463, @Imarok wrote:

In D2353#98462, @elexis wrote:

In D2353#98374, @Imarok wrote:

I think we now had multiple Zen 2 users complaining about crashes.

Got a link?

Just see the ticket and the link in the post above.

Here is another link. https://wildfiregames.com/forum/index.php?/topic/15796-known-problems-please-read-before-posting/&do=findComment&comment=384917
So we allready have Ryzen 3600, 3600X, 3700X and 3800X. So we only miss a crash report of an 3900X user to complete the Ryzen Zen2 series.

Oct 5 2019, 11:41 AM

Imarok requested changes to D2353: L3 Ryzen 3000 Bugfix.

Please add a comment with some explanation and the link to the doc.

Oct 5 2019, 11:21 AM

Imarok added a comment to D2353: L3 Ryzen 3000 Bugfix.

In D2353#98462, @elexis wrote:

In D2353#98374, @Imarok wrote:

I think we now had multiple Zen 2 users complaining about crashes.

Got a link?

Just see the ticket and the link in the post above.

The other question I have is whether we should actually call ENSURE in AddTLB.
It sounds better to fail more softly with a red error message?
Wouldn't object to a ticket for that (perhaps we already have a "dont use ENSURE" ticket?).

I think we should in general not use ENSURE in hardware detection but red error warnings instead.
Afaik there is nothing that critical that would justify an ENSURE

Sooner or later the magic numbers will change again I assume.

I don't think so.

Looking at the spec of that CPU(PDF page 75) it seems 0x9 is still reserved.

It sounds useful to add the links in the code, there already are some

Good idea

What does reserved mean?

That the number has no current meaning but is reservered for assigning some meaning in the future.

After this change it means in the worst case it will report a 16-way associative cache when someone just has a 8-way or a 32-way or whatever.

Reporting the correct number of not reporting would be more correct if the number is not known.

Either the magic number is correct for all caches, or there should be a wildcard and the Validate function should be changed to account for that wildcard?
(I have no clue what Im talking about)

Seems like ;P
The issue is: we currently don't know what this 0x9 means. But everyone who played 0ad and got this 0x9 had a CPU with a L3 16-way associative cache.
And to be honest: I don't even know why we need this information at all...

Oct 5 2019, 11:20 AM

elexis added a comment to D2353: L3 Ryzen 3000 Bugfix.