I intend to commit this probably this week, unless someone else does so first.

Successful build - Chance fights ever on the side of the prudent.

years

Successful build - Chance fights ever on the side of the prudent.

some white spaces and comments

Some bot is complaining that this patch is rotting to long and needs a license year update

I can do separate patch for injured function and to unify this.hittpoints calling but I do not see reason for this diff to wait for it :)

Renamings of spear => spearman and co is good imo (wasn't there some earlier revision where it was discussed?)

@wraitii usually the reviewer commits the patch. @Angen doesn't have commit access.

I'm keeping this as accepted, the committed should do the "IsInjured" function thingy (in a separate commit ideally) before committing

Crashes preventing access to the lobby feel like a blocker to me, and if this fixes it that's enough to get it committed _ as far as I am concerned _ . It's a small fix in terms of code debt, easy to git/svn-blame, and won't change much for our end-users.
The issue might be in our code (and it might not) but I don't have time to debug it properly and/or won't do it anyways as I already have plenty of things I care to do on this project.

Yeah, it would be nice to have it for A24 but that's all.

In D1772#74964, @wraitii wrote:

I don't actually care enough to understand why this is required.

Acceptable as such, with the two notes handled before committing.
Commit message should detail the behaviour change (i.e. this diff's title).

I don't actually care enough to understand why this is required.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

boost::random::uniform_int_distribution & boost::random::uniform_real_distribution<float> → 1.47 https://www.boost.org/doc/libs/1_47_0/doc/html/boost/random/uniform_int_distribution.html Before it's not documented.

Which version of boost starts support it?

Comments By: elexis, Imarok

proofreading the gamesetup xml and global objects says the patch is complete (did not read the full file for any hidden tooltip in the code)

Thx for the patch

Successful build - Chance fights ever on the side of the prudent.

move some code back to Reduce and rename function

@vladislavbelov should this code not be in other source/gui/ code where all the other GUI code is, for two reasons (1) cohesion and (2) performance (onTick)?
About (1), I suspect C++ has access to things that JS doesn't have access, but would either required or useful to be accessible / interactable / configurable in this context.
But I can't make a conclusion without having seen the thing in action.

Successful build - Chance fights ever on the side of the prudent.

Well good thing that option doesn't exist because this means only enable-fat is needed.
I'm not sure that's an issue upstream more us supporting too many platforms with one build.

Agreed with elexis that you may commit this if you're confident enough.

Yes, but you forgot to run the tests... ?

In rP22184#32826, @Itms wrote:

If the math isn't trivial, it should be done somewhere, so people don't have to rely on trusting you (especially in a few years when they stumble on the code).

In rP22184#32821, @wraitii wrote:

As commented, left as an exercise to the reader. The math isn't trivial.

In rP22184#32823, @wraitii wrote:

@Itms Any idea why this failed? Compiled fine and ran on my machine.

Build failure - The Moirai have given mortals hearts that can endure.

@Itms Any idea why this failed? Compiled fine and ran on my machine.

Build failure - The Moirai have given mortals hearts that can endure.

This also makes the launch point a parameter, though I only add "y" as implementing the rotation is left as an exercise to the reader.

As commented, left as an exercise to the reader. The math isn't trivial.

Rebased addressing bb's comments. Hopefully good to go this time :)

Yes, both changes are coming in different patches, probably this weekend. This is a very early WIP, you can ignore it ?

What does <LaunchPoint y="3"/> mean? Also, y suggests there could be x and z components.
Furthermore, if it's always 3, wouldn't it be better to set that by default? Same question for <Gravity>9.81</Gravity>.

Make the JPS cache and the debug variables mutable. The reasoning is that neither of those should affect the outer const-ness of the functions.

Fixed by Nescio in rP22183.

Thanks for the quick fix! ?

Hi Lancelot ? Let's not change the minimum version, we worked hard enough during the rerelease to make sure we could keep 10.9 as the minimum. Apart from that, if it works for you I can accept.

Sorry didn't mean to accept here :p

enable-fit doesn't seem to be an option: https://gmplib.org/manual/Build-Options.html

I'd say let's use the enum, default to VFS::SORTED or something, and let's sort everywhere at the moment - if it becomes a problem down the line we'll change then.

This is a sneaky bug lol. i guess it's more of a logic issue (as a can indeed refer to our very own variable and we don't check for that). I haven't actually encountered this as a "classic mistake you might make in C++" when it feels like it might be.

Feels a bit like bike shedding at this point. I suppose this is good to go once the 'else's are fixed.

I'm mostly looking for comments on whether we actually want to do this or not.

Successful build - Chance fights ever on the side of the prudent.

I suggest setting 10.12 as the new min version (but that can be overturned), and Xcode could use setting the min OSX version too.

Commandeering for minute adjustments.

Some minor changes are still needed but imo this looks much better.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

While trying to add the nice improvements from rP22096 to Jenkins, I got this error:

Error parsing structures/spart_syssiton: Duplicate child node 'Classes' at Entity.pm line 45.

Successful build - Chance fights ever on the side of the prudent.

mod inline variable

I assume agricultural products would be the most general term? Do we want that in game?

No, we don't; agricultural products can also include cotton, fruits, cheese, eggs, meat, etc.
Let's keep it simple: all farms provide the food.grain resource, thus let's simply write "harvest grain"; using any different wording can only make things more confusing.

Successful build - Chance fights ever on the side of the prudent.