Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

https://trac.wildfiregames.com/ticket/6532

in favor of D4605

In D4636#197100, @phosit wrote:

Could you at least make the dummy::CDevice constructor public.
The public create function allows to create it from everywere only prevents creation on the stack:
ps/ArchiveBuilder.cpp L80 and praphics/tests/test_TextureManager.h L31 could be "normal" stack variables.

Ok.

In D4636#197087, @vladislavbelov wrote:

In D4636#197050, @phosit wrote:

Why are the constructors private?

To emphasize that they should be created only by their device.

In D4636#197050, @phosit wrote:

Why are the constructors private?

To emphasize that they should be created only by their device.

In D4636#197049, @Langbart wrote:

Thanks!

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

timer before component

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Looks good (in more ways than one :) ).

1.5

You'll need to update cmpUnitMotionFlying to also update the clearance in cmpObstruction.

I would like to see the ITA of a unit as a first fix (so a value of 1.5). Than we can later discuss/establish whether the value is necessary at all.

No clue why, and D4593 seem okay.

This is your error:

ERROR: JavaScript error: simulation/components/Formation.js line 158
Engine.QueryInterface(...) is null
  Formation.prototype.Init@simulation/components/Formation.js:158:9
  global.ConstructComponent@simulation/components/tests/setup.js:112:6
  @simulation/components/tests/test_Formation.js:22:40

see rP26852

In D4636#197040, @vladislavbelov wrote:

In D4636#197031, @phosit wrote:

Why not use variant? (instead of a pointer to base class)

A bit longer usage, having GL (and other backends) includes (direct or indirect) for regular code to know the size

Apply the patch and compile the game

1. Applied the patch with pull0ad.
2. When compiling, I get a myriad of new warnings. It did compile though.
   • Entire build log: https://ttm.sh/b4G.txt

In D4636#197031, @phosit wrote:

Why not use variant? (instead of a pointer to base class)

Ok, tested on random/unknown, skirmishes/corinthian_isthmus_2p and skirmishes/forest_battle_4p maps. The issue from the ticket could not be reproduced.

Why not use variant? (instead of a pointer to base class)

An issues was found tracked down to this changeset. See #6531

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Reverted translation, which led to build failure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Added translation to user facing messages as suggested by @Stan .

see rP26849

In D4631#196937, @Langbart wrote:

Check that game looks like before (with different settings): water, shadows, particles, skies, trees, terrain, ao

(not yet, will upload some images later)

The mentioned performance difference between OpenGL and OpenGL ARB in D4631 is caused by this changeset. See ticket #6525 for more details.

Hey thanks for the patch! I heard rumors it worked but never saw the distribution patches for it.

I would say the game on this Arch just works, but too slow to be in a playable state. I upload this patch mainly for 0ad lovers using riscv or people who are interested in riscv to try out. It is totally fine for me if this patch is left unmerged or ignored.

bisecting leads me to this changeset for ticket #6524

In D4631#196937, @Langbart wrote:

Compare performance

• system_info.txt is here #5969
• I created a map with 5 players (me+4AI's) on a normal sized Ratumacos map. Entered the cheat code gift from the gods and have 91 horses run around the edge of the map..

D4631_replay.zip8 KBDownload

Apply the patch and compile the game

It worked for the most part with arc patch D4631, but I had to create source/ps/containers/Span.h manually.
It did compile.

Check that game looks like before (with different settings): water, shadows, particles, skies, trees, terrain, ao

(not yet, will upload some images later)

Compare performance

• system_info.txt is here #5969
• I created a map with 5 players (me+4AI's) on a normal sized Ratumacos map. Entered the cheat code gift from the gods and have 91 horses run around the edge of the map..

Procedure (Visual Replay):

1. add profiler2.autoenable = true to user.cfg file
2. run the following command 0ad/binaries/system/pyrogenesis -mod=public -replay-visual=PATH
3. open profiler2.html in browser (but only when the loading screen disappears and the actual replay starts)
4. replay begins, choose paria and click Follow Player
5. replay ends, click Save Live Report to file
6. save profiler2.jsonp from the log folder and rename it accordingly
7. perform this for default settings with OpenGL and OpenGL ARB with/without applying the patch.

not sure what this should tell me:
Test failed: L"Running script simulation/components/tests/test_Formation.js"

It could be considered a bugfix which ads GUI part too but that depends if @Stan @Silier @Freagarach agree that it can be committed.

In D4632#196919, @Freagarach wrote:

Furthermore, basically all callsites have been complicated by the diff instead of simplified, which shows IMO that something is awry.

I see only the call in templates.js being complicated?

In D4623#196589, @sotirangelo wrote:

The time elapsed should display properly now.

Yes, it is fixed. I did not find any other issues when testing the patch. Seems to work as planned. Good job.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

comments + another try

#1 -> This leads to weird code, because:

• Maps don't care about non-JSON data

I'm not sure what you mean here, but grep -irn maps/ -e 'gettemplate' results in quite some hits. ^^

• GUI cares about JSON data and the 'Identity' part of the XML data, but only that part.

Also civ/team bonuses, available templates etc.?

• Sim mostly doesn't care about JSON data.

Working to ensure that. ;P

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Back to non-generic solution.

In D4626#196812, @marder wrote:

But even without seeing the bug, I would say we should be able to conceptually agree that the function should have parenthesis as we want to get the modulo for a circle and not the modulo 2 times pi :)

Yeah, just curious to what the symptoms were. ^^

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

only test to 179°

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

since the test do work now, expand them.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.