Currently I'm unable to open Atlas, so I tried opening some Ptolemaic Sandbox scenario. There are two of them, and both crashed when this patch is applied. The error is 'error displaying error message'. Not sure what happened, perhaps something to do with existing Juggernaut in maps?

Jul 20 2021, 12:08 PM

Vulcan added a comment to D4149: Call to the Arms-Button (#1364).

Successful build - Chance fights ever on the side of the prudent.

Jul 20 2021, 10:56 AM

Vulcan added a comment to D4149: Call to the Arms-Button (#1364).

Successful build - Chance fights ever on the side of the prudent.

Jul 20 2021, 10:54 AM

azayrahmad updated subscribers of D4196: Limited abilities for Introductory Tutorial.

Jul 20 2021, 10:54 AM · Contributors

JCWasmx86 updated the diff for D4149: Call to the Arms-Button (#1364).

Jul 20 2021, 10:50 AM

Freagarach added inline comments to D4149: Call to the Arms-Button (#1364).

Jul 20 2021, 10:22 AM

Vulcan added a comment to D4149: Call to the Arms-Button (#1364).

Successful build - Chance fights ever on the side of the prudent.

Jul 20 2021, 9:48 AM

Vulcan added a comment to D4149: Call to the Arms-Button (#1364).

Successful build - Chance fights ever on the side of the prudent.

Jul 20 2021, 9:46 AM

JCWasmx86 updated the diff for D4149: Call to the Arms-Button (#1364).

Jul 20 2021, 9:42 AM

azayrahmad added a comment to D4196: Limited abilities for Introductory Tutorial.

In D4196#178358, @Freagarach wrote:

I think it is cleaner to disable stuff using triggers.

Jul 20 2021, 9:12 AM · Contributors

Freagarach committed rP25828: Fix PetraAI constructing ships as ordinary units..

Fix PetraAI constructing ships as ordinary units.

Jul 20 2021, 7:20 AM

Freagarach closed D4193: Fix PetraAI training ships as ordinary units..

Jul 20 2021, 7:20 AM

Freagarach updated the summary of D4193: Fix PetraAI training ships as ordinary units..

Jul 20 2021, 7:16 AM

Freagarach accepted D4195: [AI] Simplify getMetadata in sharedscript.

One could use the ?. notation to make it a one-liner.

Jul 20 2021, 6:53 AM

Freagarach added a comment to D4196: Limited abilities for Introductory Tutorial.

I think it is cleaner to disable stuff using triggers.

Jul 20 2021, 6:48 AM · Contributors

Freagarach added a member for Contributors: azayrahmad.

Jul 20 2021, 6:46 AM

azayrahmad requested review of D4196: Limited abilities for Introductory Tutorial.

Jul 20 2021, 4:44 AM · Contributors

Jul 19 2021

Jammyjamjamman added a comment to D4191: Enable Cartography at Start of Game Option.

In D4191#178292, @Angen wrote:

At first you would need to get separate code for library and build it,
Adding option itself is C++, but mostly it would be copy pasting of existing code, if C++ would be concidered issue.
https://trac.wildfiregames.com/wiki/BuildInstructions?version=416#BuildingAtlas

Jul 19 2021, 10:20 PM

Silier accepted D4193: Fix PetraAI training ships as ordinary units..

Ships are fixed

Jul 19 2021, 10:09 PM

Vulcan added a comment to D4195: [AI] Simplify getMetadata in sharedscript.

Successful build - Chance fights ever on the side of the prudent.

Jul 19 2021, 9:47 PM

Vulcan added a comment to D4195: [AI] Simplify getMetadata in sharedscript.

Successful build - Chance fights ever on the side of the prudent.

Jul 19 2021, 9:43 PM

Vulcan added a comment to D4195: [AI] Simplify getMetadata in sharedscript.

Successful build - Chance fights ever on the side of the prudent.

Jul 19 2021, 9:41 PM

Vulcan added a comment to D4195: [AI] Simplify getMetadata in sharedscript.

Successful build - Chance fights ever on the side of the prudent.

Jul 19 2021, 9:39 PM

Silier updated the diff for D4195: [AI] Simplify getMetadata in sharedscript.

fix typo

Jul 19 2021, 9:38 PM

Silier published D4195: [AI] Simplify getMetadata in sharedscript for review.

Jul 19 2021, 9:36 PM

Vulcan added a comment to D4193: Fix PetraAI training ships as ordinary units..

Successful build - Chance fights ever on the side of the prudent.

Jul 19 2021, 4:10 PM

Vulcan added a comment to D4193: Fix PetraAI training ships as ordinary units..

Successful build - Chance fights ever on the side of the prudent.

Jul 19 2021, 4:09 PM

Freagarach updated the diff for D4193: Fix PetraAI training ships as ordinary units..

Don't exclude ships explicitly ships.

Jul 19 2021, 4:04 PM

Freagarach added inline comments to D4149: Call to the Arms-Button (#1364).

Jul 19 2021, 3:57 PM

Silier added a comment to D4193: Fix PetraAI training ships as ordinary units..

Why does Ship need to be excluded? Does not that mean somewhere are still wrong classes passed?

Jul 19 2021, 3:37 PM

Vulcan added a comment to D4149: Call to the Arms-Button (#1364).

Successful build - Chance fights ever on the side of the prudent.

Jul 19 2021, 2:02 PM

Vulcan added a comment to D4149: Call to the Arms-Button (#1364).

Successful build - Chance fights ever on the side of the prudent.

Jul 19 2021, 2:01 PM

JCWasmx86 added inline comments to D4149: Call to the Arms-Button (#1364).

Jul 19 2021, 1:57 PM

JCWasmx86 updated the diff for D4149: Call to the Arms-Button (#1364).

Added correction.

Jul 19 2021, 1:56 PM

autobuild committed rP25827: [i18n] Updated POT and PO files..

[i18n] Updated POT and PO files.

Jul 19 2021, 9:24 AM

Freagarach requested changes to D4149: Call to the Arms-Button (#1364).

Jul 19 2021, 8:24 AM

Vulcan added a comment to D4193: Fix PetraAI training ships as ordinary units..

Successful build - Chance fights ever on the side of the prudent.

Jul 19 2021, 7:05 AM

Vulcan added a comment to D4193: Fix PetraAI training ships as ordinary units..

Successful build - Chance fights ever on the side of the prudent.

Jul 19 2021, 7:04 AM

Freagarach updated the diff for D4193: Fix PetraAI training ships as ordinary units..

Need both classes (fixes PetraAI training loads of cavalry).

Jul 19 2021, 7:00 AM

Freagarach accepted D4191: Enable Cartography at Start of Game Option.

Code looks good, I haven't tested this.

Jul 19 2021, 6:49 AM

azayrahmad updated the summary of D4194: Tutorial in Learn to Play menu refer to Introductory Tutorial.

Jul 19 2021, 2:11 AM · Contributors

Jul 18 2021

andy5995 added a comment to D4191: Enable Cartography at Start of Game Option.

Sure. I'm currently building the game+developing this patch from the github mirror. What would "adding this option to atlas" involve?

Jul 18 2021, 9:16 PM

Silier added a comment to D4191: Enable Cartography at Start of Game Option.

At first you would need to get separate code for library and build it,
Adding option itself is C++, but mostly it would be copy pasting of existing code, if C++ would be concidered issue.
https://trac.wildfiregames.com/wiki/BuildInstructions?version=416#BuildingAtlas

Jul 18 2021, 7:47 PM

Jammyjamjamman added a comment to D4191: Enable Cartography at Start of Game Option.

In D4191#178269, @Angen wrote:

Some minor comments.
Patch is overall working as expected.

I have one additional question.
Would you be interested in adding this option to the atlas?
For that you would need to build the game from source, I do not know if you are willing to do that.

Jul 18 2021, 7:32 PM

Vulcan added a comment to D4191: Enable Cartography at Start of Game Option.

Successful build - Chance fights ever on the side of the prudent.

Jul 18 2021, 7:20 PM

Vulcan added a comment to D4191: Enable Cartography at Start of Game Option.

Successful build - Chance fights ever on the side of the prudent.

Jul 18 2021, 7:18 PM

Jammyjamjamman updated the diff for D4191: Enable Cartography at Start of Game Option.

More small changes suggested by Angen

Jul 18 2021, 7:14 PM

azayrahmad requested review of D4194: Tutorial in Learn to Play menu refer to Introductory Tutorial.

Jul 18 2021, 1:38 PM · Contributors

Silier accepted D4191: Enable Cartography at Start of Game Option.

Jul 18 2021, 12:23 PM

Silier added a comment to D4191: Enable Cartography at Start of Game Option.

Some minor comments.
Patch is overall working as expected.

Jul 18 2021, 12:23 PM

Silier requested changes to D4193: Fix PetraAI training ships as ordinary units..

Or use another notation which means and among classes

Jul 18 2021, 11:44 AM

Freagarach requested review of D4193: Fix PetraAI training ships as ordinary units..

Jul 18 2021, 11:18 AM

Vulcan added a comment to D4192: [PetraAI] - Manage bases in separate BaseManager..

Successful build - Chance fights ever on the side of the prudent.

Jul 18 2021, 10:34 AM

Vulcan added a comment to D4192: [PetraAI] - Manage bases in separate BaseManager..

Successful build - Chance fights ever on the side of the prudent.

Jul 18 2021, 10:34 AM

Freagarach updated the diff for D4192: [PetraAI] - Manage bases in separate BaseManager..

Separate baseless base.

Jul 18 2021, 10:28 AM

Freagarach committed rP25826: (Partly) Fix PetraAI building a lot of siege and not using it..

(Partly) Fix PetraAI building a lot of siege and not using it.

Jul 18 2021, 7:07 AM

Freagarach closed D4184: Fix PetraAI building a lot of siege and not using it..

Jul 18 2021, 7:07 AM

Freagarach updated the Trac tickets for D4184: Fix PetraAI building a lot of siege and not using it..

Jul 18 2021, 6:56 AM

Vulcan added a comment to D4191: Enable Cartography at Start of Game Option.

Successful build - Chance fights ever on the side of the prudent.

Jul 18 2021, 1:59 AM

Vulcan added a comment to D4191: Enable Cartography at Start of Game Option.

Successful build - Chance fights ever on the side of the prudent.

Jul 18 2021, 1:59 AM

Jammyjamjamman added a comment to D4191: Enable Cartography at Start of Game Option.

Thanks @Angen and @Freagarach for your feedback. I've (finally) applied your suggested changes.

Jul 18 2021, 1:56 AM

Jammyjamjamman updated the diff for D4191: Enable Cartography at Start of Game Option.

Add option to enable cartography at start of game
Apply changes suggested by Angen and Freagarach (see points below).
Remove changes to translation files (not needed).
Add comments to translations.
Fix wrong function in MapExploration.js.
Tidy + simplify code in InitGame.js.

Jul 18 2021, 1:53 AM

Jul 17 2021

Silier added a comment to D4192: [PetraAI] - Manage bases in separate BaseManager..

yes i do

Jul 17 2021, 8:17 PM

Vulcan added a comment to D4184: Fix PetraAI building a lot of siege and not using it..

Successful build - Chance fights ever on the side of the prudent.

Jul 17 2021, 10:19 AM

Vulcan added a comment to D4184: Fix PetraAI building a lot of siege and not using it..

Successful build - Chance fights ever on the side of the prudent.

Jul 17 2021, 10:11 AM

Freagarach added a comment to D4192: [PetraAI] - Manage bases in separate BaseManager..

I agree, that base is special, so it can also be treated special.
Can I conclude that you agree to the concept?

Jul 17 2021, 10:08 AM

Freagarach updated the diff for D4184: Fix PetraAI building a lot of siege and not using it..

Fix PetraAI building Siege Towers now (which she doesn't understand how to use).

Jul 17 2021, 10:04 AM

Freagarach added a comment to rP25824: Fix treasure in statistics.

Thanks for this. It shows that I should use better naming.

Jul 17 2021, 8:45 AM

Jul 16 2021

autobuild committed rP25825: [i18n] Updated POT and PO files..

[i18n] Updated POT and PO files.

Jul 16 2021, 9:27 AM

Stan added a comment to D4123: Fix some gaia units having incorrect players.

My regex filter ignores sheeps and goats. i could ignore zebus too.
For ruins I'm not sure since it's basically stone they have no other purpose like an aura.

Jul 16 2021, 7:40 AM

wowgetoffyourcellphone added a comment to D4123: Fix some gaia units having incorrect players.

Some of these, such as cattle and sheep, were intentional. Player Tigers, notsmuch.

Jul 16 2021, 1:17 AM