In D4695#199629, @jprahman wrote:

Curious as well what sort of tooling 0AD has for template scanning/validation? I saw the templateanalyzer under source/tools, but that appears to be about balance analysis, rather than validation.

Curious as well what sort of tooling 0AD has for template scanning/validation? I saw the templateanalyzer under source/tools, but that appears to be about balance analysis, rather than validation.

Is it possible there are other templates with this same issue?

Successful build - Chance fights ever on the side of the prudent.

In D4679#199512, @wraitii wrote:

In D4679#199184, @Freagarach wrote:

That sounds like good play then? And reckless play from the defender? There are walls to fend off these kind of raids?

While I would +1 that this makes sense, it might lead to big gameplay changes

Successful build - Chance fights ever on the side of the prudent.

before I start to change stats: @Freagarach does the unitAI changes look ok?

Build failure - The Moirai have given mortals hearts that can endure.

• assigne g_Profiler2 also in the tests
• edit some coments in Profiler2.h

In D4682#199600, @phosit wrote:

Is there generaly a need to remove ps/Singleton? should i also work on that?

By removing that you semantically won't remove singletons from the code, only safety checks.

Successful build - Chance fights ever on the side of the prudent.

The wall builder changes are out of scope and somewhat extensive, so it could be refactored later.

Build failure - The Moirai have given mortals hearts that can endure.

In D4682#199514, @wraitii wrote:

Per https://trac.wildfiregames.com/wiki/Coding_Conventions, we have Prefer global variables over singletons, because then they're not trying to hide their ugliness. It's definitely something I kind of like, because singletons by design make it annoying to have two of something, and that can occasionally be useful.

I like basically all of the changes here, but I think you should just make it a regular global.

small overlap sometimes for romans

replace houses by one temple & one market

Build failure - The Moirai have given mortals hearts that can endure.

lgtm and seems to work as intended

I would rather just remove all the houses and possibly replace them by e.g. one temple or a market.

Agreed.

not a singleton anymore.

In D4696#199578, @lyv wrote:

For the overlap, I am not convinced that not providing equal houses is valid. We should fix the root cause instead. Not requesting changes though, as I am not sure how best to proceed. Any fix of the "root cause" is going be pretty extensive and IMO, not prudent to commit during FF. In the meantime, a "fix" is to indiscriminately add a fixed margin to non-wall templates but it is as bad as it sounds.

Texture and metal placement changes are good.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Shorted code. Removed stances part.

Go right ahead.

The stances part seems a bit wonky, but the responding sounds like a good idea. @lyv, do you mind if I take over? (I can obviously state what I would like to see changed, but if you don't care about UnitAI, I figure you might not want to keep updating this.)

I've tested this a bit, PetraAI goes into emergency mode correctly and also resumes from it. Nomad is also functioning properly.
The code reads correct and this is a nice first step.
I'll commit it after FF has thawed.

In D4380#189803, @wowgetoffyourcellphone wrote:

Looks like this has broad appeal. Anyone wish to Accept Revision?

@balancing?

s/might/will
;)
We can experiment with this in the next alpha.

Yes looks good, thanks for solfing the tiket.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

TryToConnectWithXmpp -> TryToConnectViaLobby to match the SetupConnection call (and because XMPP is basically the lobby client).

GetCameraDirection -> GetCameraOrientation for consistency with C++

@edoput How do you want to appear in the credits?

I don't see why we would ever need two profiler instances? Running multiple matches?

Looks like a bugfix that could go in for me but your call :)

In D4682#199519, @Stan wrote:

Oh my bad then. Just thought it'd be nice if someday we decide to have proper dependency injection.

Good catch feels like we could have a python script for that. Using the rl interface.

linting I assume ?

Oh my bad then. Just thought it'd be nice if someday we decide to have proper dependency injection.

Seems like you could fix a few listing problems while at it, but this gets a +1 for being a good idea.

Per https://trac.wildfiregames.com/wiki/Coding_Conventions, we have Prefer global variables over singletons, because then they're not trying to hide their ugliness. It's definitely something I kind of like, because singletons by design make it annoying to have two of something, and that can occasionally be useful.

In D4679#199184, @Freagarach wrote:

That sounds like good play then? And reckless play from the defender? There are walls to fend off these kind of raids?

Think this is generally a fairly good first use case, but I believe you could write simpler code, particularly since this bit doesn't really require us to optimise it to death.

In D4676#199132, @chrstgtr wrote:

Maybe this is too simple, but why don’t we just switch default unit behavior to destroy instead of capture and adjust health and control metrics to reflect how we want them? [...] It seems like it an all around win.

I'll make a minor tweak to avoid double-messages but I think this looks good

I'll need to properly test, but will not commit it while we're in FF.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Update from feedback

In D4676#199132, @chrstgtr wrote:

Maybe this is too simple, but why don’t we just switch default unit behavior to destroy instead of capture and adjust health and control metrics to reflect how we want them? So for example,make the health points for non-military buildings (e.g. houses and markets) low so that they can be quickly destroyed. We could also do the opposite with military buildings that we want to buff (e.g. towers) where we increase capture points a bunch. That way the health and capture metrics are easily viewable/understandable by the player, it keeps all current strategies (I.e. capturing a temple in enemy territory to get a footing, border skirmishes to gain enemy buildings, sneaks cc captures, etc) , and gets rid of annoying capture delete mechanic meta that currently exists. It also shifts the game to fighting-based the way that wraitii wants and any deviation from that is an intentional Strategy move. It seems like it an all around win.

#6569

#6560

rP26933

rP26933

Any news on this @jprahman

@Freagarach is this good to go?

Refs. https://trac.wildfiregames.com/ticket/6559