Build is green
Feed All Stories
Jan 23 2021
Jan 23 2021
wraitii requested review of D3459: Hash match passwords better..
wraitii updated the diff for D3438: Verify password in Authenticate.
Slight formatting tweaks before commit.
borg- requested review of D3458: [gameplay] Balance levy infantry/cavalry techs..
wraitii updated the diff for D3438: Verify password in Authenticate.
Make the password not print to the logs. The length doesn't matter since it's hashed to a constant length (or 0 if there is no password, but that's also not secret information).
Vulcan added a comment to D3456: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of rP24217.
Build is green
wraitii updated the diff for D3456: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of rP24217.
Fix Angen's remarks.
wraitii added a comment to D3456: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of rP24217.
Stan added a comment to D1751: [WIP] Map flares.
I get some warnings about g_LastFlare not being defined. I remade the highlited version. Should be better now.
Fix cheering issue entering from idle state
Stan added a comment to D3456: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of rP24217.
Is there a way to test what broke and forces the revert of this?
wraitii added a comment to D3326: Make WxWidgets High-DPI aware / Upgrade WXWidgets to 3.1.4 on MacOS.
asterix added a comment to D3326: Make WxWidgets High-DPI aware / Upgrade WXWidgets to 3.1.4 on MacOS.
Any news here?
Fix issues with Cheering and PushOrderFront
wraitii committed rP24772: Fix hero cavalry spearman bonus.
Fix hero cavalry spearman bonus
wraitii added inline comments to D3398: improve some texts.
Silier added inline comments to D3456: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of rP24217.
wraitii requested changes to D3398: improve some texts.
I'm not a fan of several of these, to be honest.
Stan added inline comments to D3452: Fix issues with Cheering and PushOrderFront.
wraitii added a comment to D3457: Removes shadow bias for landscape shader.
I can see a few artefacts with mines with 0 bias, but 0.0005 is probably bigger than it needs to be for medium/high/very high shadow settings (looks bad with chicken)
Perhaps we should just scale the bias with the shadow setting, from like 0.001 (very low) to 0.0001 (very high)
wraitii added inline comments to D3457: Removes shadow bias for landscape shader.
vladislavbelov updated the test plan for D3457: Removes shadow bias for landscape shader.
vladislavbelov added inline comments to D3457: Removes shadow bias for landscape shader.
wraitii added inline comments to D3457: Removes shadow bias for landscape shader.
vladislavbelov added inline comments to D3457: Removes shadow bias for landscape shader.
wraitii added inline comments to D3457: Removes shadow bias for landscape shader.
vladislavbelov requested review of D3457: Removes shadow bias for landscape shader.
DanW58 updated the diff for D3454: Modified CFixedVector2D/3D that cache length to reduce calls to isqrt64(), plus a few other fixes.
- Removed comments.
- Fixed the tabs that were spaces issue, courtesy of CodeLite
- Added alignment directives
- Removed padding member
- svn diff'ed from the instructions in the wiki
Vulcan added a comment to D3456: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of rP24217.
Build is green
wraitii added inline comments to D3452: Fix issues with Cheering and PushOrderFront.
wraitii updated the diff for D3456: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of rP24217.
Fix tests.
Stan added inline comments to D3452: Fix issues with Cheering and PushOrderFront.
Silier added a comment to D3455: Fix cheering issue entering from idle state.
I meant idle timer may not run yet
wraitii added a comment to D3455: Fix cheering issue entering from idle state.
I'm not entirely sure where units are supposed to check their surroundings in CHEERING, tbh.
Silier requested review of D3455: Fix cheering issue entering from idle state.
wraitii added a comment to rP24217: Update range queries to account for entity size..
Fix error in GATHERING when disbanding formation while members gather.
wraitii added a comment to D3454: Modified CFixedVector2D/3D that cache length to reduce calls to isqrt64(), plus a few other fixes.
Congrats on your first patch :)
A few general remarks:
- Not everything is specified, but we have some general conventions here: https://trac.wildfiregames.com/wiki/Coding_Conventions
- We write comments capitalised + dotted
- from reading your forum posts, I believe you're used to 'older' C++, this has no real impact here but we're using C++17
- we don't really do the "author: some comment" thing, though I guess you might intend those for review only. In that case, you can also leave inline comments on Phabricator.
- you appear to have a few whitespace issues with the patch.
Freagarach added a comment to D3398: improve some texts.
I disagree with the change in the shared dropsites tech. The rest seems okay.
Freagarach added a comment to D3309: [gameplay] set plane <BuffHeal> to 0.
I'm opposed, as it is a nice bonus for a cheat unit. That being said, if someone disagrees with mee, feel free to commit (I won't).
autobuild committed rP24770: [Windows] Automated build..
[Windows] Automated build.
Freagarach added a comment to D1971: Support attack-ground for ranged units..
Attack-zone was also an idea I had some time ago, yeah.
Freagarach added inline comments to rP24034: Cheer after combat when no enemy units are in range.
Freagarach added inline comments to D3450: Fix error in GATHERING when disbanding formation while members gather..
borg- updated the summary of D3453: Fix hero cavalry spearman bonus.
borg- requested review of D3453: Fix hero cavalry spearman bonus.
Jan 22 2021
Jan 22 2021
[Petra/Ai] Fix not researching free and instant technologies
Vulcan added a comment to D3388: [Petra/Ai] Fix not researching free and instant technologies.
Build is green
Silier updated the diff for D3388: [Petra/Ai] Fix not researching free and instant technologies.
update so i dont mess up
wraitii added a comment to D1971: Support attack-ground for ranged units..
You need to rebase this one m8 :p
Silier added a comment to rP24034: Cheer after combat when no enemy units are in range.
Enter Cheer
In Cheering state, get attacked/notice a target. PushOrderFront("Attack", newTarget). This just pushes 'Cheer' back onto the order queue.
Target is killed, FINDINGNEWTARGET::FinishOrder -> Cheering is found -> back to step 1.
wraitii requested review of D3452: Fix issues with Cheering and PushOrderFront.
wraitii raised a concern with rP24034: Cheer after combat when no enemy units are in range.
See https://trac.wildfiregames.com/ticket/5945#comment:10 & corresponding replay (works on rP24757 to rP24767)
Allows to override GL version for SDL.
Small icon changes, use a custom icon for the gallic plow
Fix target height computation when launching projectiles.
Silier added inline comments to D3388: [Petra/Ai] Fix not researching free and instant technologies.
Fix AI undefined error from garrisoned entities.
Tested to work and this seems reasonable, and fixes Seleucids.
wraitii added a reverting change for D3067: Fix visual-replays not processing turn 0 commands.: rP24764: Revert rP24280, causing false OOS in visual replays..
wraitii added a reverting change for rP24280: Fix visual-replays not processing turn 0 commands.: rP24764: Revert rP24280, causing false OOS in visual replays..
Revert rP24280, causing false OOS in visual replays.
Vulcan added a comment to D3425: Fix target height computation when launching projectiles..
Build is green
wraitii added a comment to D3425: Fix target height computation when launching projectiles..
Height difference (__A is SVN).
TBH at the moment it looks pretty bad because the projectile doesn't disappear on hit...
wraitii updated the diff for D3425: Fix target height computation when launching projectiles..
I actually renamed the C++ to "GetHeightAtFixed", which makes more sense.
wraitii added inline comments to D3450: Fix error in GATHERING when disbanding formation while members gather..
wraitii requested review of D3451: Fix AI undefined error from garrisoned entities..
Stan added inline comments to D3450: Fix error in GATHERING when disbanding formation while members gather..
wraitii requested review of D3450: Fix error in GATHERING when disbanding formation while members gather..
@user1 What do you think of this patch?