Page MenuHomeWildfire Games
Feed All Stories

Tue, Nov 16

Freagarach added a comment to D4333: Split tasks from ProductionQueue..
		if (!tech)
		{
			ret[i] = undefined;
			continue;
		}

Results in normal behaviour.

WARNING: ["phase_town_generic", (void 0), "unlock_shared_dropsites", "unlock_spies"]

Whilst:

		if (!tech)
			continue;

Results in:

WARNING: ["phase_town_generic", , "unlock_shared_dropsites", "unlock_spies"]
ERROR: Errors executing script event "SimulationUpdate"
ERROR: JavaScript error: gui/session/selection_panels.js line 681
data.item is undefined
  setupButton@gui/session/selection_panels.js:681:7
  setupUnitPanel@gui/session/unit_commands.js:94:35
  updateUnitCommands@gui/session/unit_commands.js:152:18
  updateSelectionDetails@gui/session/selection_details.js:536:20
  updateGUIObjects@gui/session/session.js:727:2
  onSimulationUpdate@gui/session/session.js:677:2
  __eventhandler54 (SimulationUpdate)@session SimulationUpdate:1:1
Tue, Nov 16, 7:48 AM
Vulcan added a comment to D4349: Fix infinite loop when queuing a gather order after garrison..

Successful build - Chance fights ever on the side of the prudent.

Tue, Nov 16, 7:43 AM
Vulcan added a comment to D4349: Fix infinite loop when queuing a gather order after garrison..

Successful build - Chance fights ever on the side of the prudent.

Tue, Nov 16, 7:42 AM
Freagarach updated the diff for D4349: Fix infinite loop when queuing a gather order after garrison..

isGarrisoned is also used for turreted entities.

Tue, Nov 16, 7:29 AM

Mon, Nov 15

andy5995 added a comment to D4303: Add new TeamPlacement option "Beside Allies"; Add more TeamPlacement options to Mainland and African Plains: stronghold, line, randomGroup.

In this example (mainland, medium), the 3 players are on the same team, but do you think they are too close together? If so, any suggestions or pseudo-code ideas on how to alter the algorithm on how to prevent that?

Mon, Nov 15, 8:48 PM
vladislavbelov requested review of D4351: Slightly improves minimap flares.
Mon, Nov 15, 8:07 PM
autobuild committed rP25999: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Mon, Nov 15, 9:12 AM
ValihrAnt awarded D4303: Add new TeamPlacement option "Beside Allies"; Add more TeamPlacement options to Mainland and African Plains: stronghold, line, randomGroup a Love token.
Mon, Nov 15, 9:12 AM
Vulcan added a comment to D4303: Add new TeamPlacement option "Beside Allies"; Add more TeamPlacement options to Mainland and African Plains: stronghold, line, randomGroup.

Successful build - Chance fights ever on the side of the prudent.

Mon, Nov 15, 7:04 AM
Vulcan added a comment to D4303: Add new TeamPlacement option "Beside Allies"; Add more TeamPlacement options to Mainland and African Plains: stronghold, line, randomGroup.

Successful build - Chance fights ever on the side of the prudent.

Mon, Nov 15, 7:01 AM
andy5995 updated the diff for D4303: Add new TeamPlacement option "Beside Allies"; Add more TeamPlacement options to Mainland and African Plains: stronghold, line, randomGroup.

Fix placement of players when they are not assigned teams

Mon, Nov 15, 6:57 AM
autobuild committed rP25998: [Windows] Automated build..
[Windows] Automated build.
Mon, Nov 15, 5:58 AM

Sun, Nov 14

vladislavbelov committed rP25997: Removes border pixels drawing of the minimap texture with scissors after….
Removes border pixels drawing of the minimap texture with scissors after…
Sun, Nov 14, 5:52 PM
vladislavbelov closed D4350: Fixes border pixels in rP25993.
Sun, Nov 14, 5:52 PM
vladislavbelov added a comment to D4329: Copy/Open button for file path in replay window.

The C++ part looks ok to me.

Sun, Nov 14, 4:20 PM
Silier updated the Trac tickets for D4350: Fixes border pixels in rP25993.
Sun, Nov 14, 11:42 AM
Langbart added a comment to D4350: Fixes border pixels in rP25993.

This patch fixes the problem I described in the referenced ticket.

Sun, Nov 14, 11:14 AM
Langbart resigned from rP25993: Moves MiniMap texture rendering to a separate framebuffer to update it less….

D4350

Sun, Nov 14, 11:13 AM
Vulcan added a comment to D4350: Fixes border pixels in rP25993.

Successful build - Chance fights ever on the side of the prudent.

Sun, Nov 14, 11:09 AM
Vulcan added a comment to D4350: Fixes border pixels in rP25993.

Successful build - Chance fights ever on the side of the prudent.

Sun, Nov 14, 11:09 AM
vladislavbelov updated the diff for D4350: Fixes border pixels in rP25993.
Sun, Nov 14, 11:01 AM
vladislavbelov added a comment to rP25993: Moves MiniMap texture rendering to a separate framebuffer to update it less….

Minimap stretched lines - #6382.

Sun, Nov 14, 10:57 AM
vladislavbelov requested review of D4350: Fixes border pixels in rP25993.
Sun, Nov 14, 10:48 AM
vladislavbelov committed rP25996: Adds alpha and custom options to render debug modes..
Adds alpha and custom options to render debug modes.
Sun, Nov 14, 9:35 AM
vladislavbelov closed D4346: Adds more alpha and custom options to render debug mods..
Sun, Nov 14, 9:35 AM
Silier added a comment to D4333: Split tasks from ProductionQueue..

That is sus (playcode)

const ret = [];
Sun, Nov 14, 9:32 AM
vladislavbelov added a comment to D4346: Adds more alpha and custom options to render debug mods..

However, one problem is when you change the dropdown to a value and then quit the game (not the entire 0ad game, just the current game you are in) and start a new game. The overlay is still visible.
I tested it with the toggle box Obstruction Overlay and the Render Debug Mode AO. The first one turns off, the second one does not. This works since D4311 was committed, maybe it can be fixed with this changeset, otherwise I will create a ticket.

Debug overlays are mostly for objects not for UI or overlays. But maybe it might be improved.

Sun, Nov 14, 9:30 AM
Freagarach requested review of D4349: Fix infinite loop when queuing a gather order after garrison..
Sun, Nov 14, 8:52 AM
Vulcan added a comment to D4333: Split tasks from ProductionQueue..

Successful build - Chance fights ever on the side of the prudent.

Sun, Nov 14, 8:02 AM
Vulcan added a comment to D4333: Split tasks from ProductionQueue..

Successful build - Chance fights ever on the side of the prudent.

Sun, Nov 14, 8:02 AM
Freagarach updated the diff for D4333: Split tasks from ProductionQueue..

@Silier's comments.

Sun, Nov 14, 7:55 AM
Freagarach added inline comments to D4333: Split tasks from ProductionQueue..
Sun, Nov 14, 7:55 AM
Freagarach requested changes to D4305: Fix bug where scenario map was not loading as revealed when set to revealed..

If I have all three enabled, and disabled the allied view, it also disables the revealed map. Do note that allied view is also the ability to browse eachothers summary, so isn't tied only to the view state.

Sun, Nov 14, 7:26 AM
Langbart raised a concern with rP25993: Moves MiniMap texture rendering to a separate framebuffer to update it less….

Minimap stretched lines - #6382.

Sun, Nov 14, 6:46 AM
Langbart added a comment to D4346: Adds more alpha and custom options to render debug mods..

However, one problem is when you change the dropdown to a value and then quit the game (not the entire 0ad game, just the current game you are in) and start a new game. The overlay is still visible.
I tested it with the toggle box Obstruction Overlay and the Render Debug Mode AO. The first one turns off, the second one does not. This works since D4311 was committed, maybe it can be fixed with this changeset, otherwise I will create a ticket.

Sun, Nov 14, 3:56 AM
Langbart added a comment to D4346: Adds more alpha and custom options to render debug mods..

Apply the patch and compile the game

Ok.

Make sure the game looks and runs the same for GLSL on/off

Yes, tested on the scenario map - third_macedonian_war.
GLSL off (default settings)
https://pasteall.org/media/4/1/41c41cb88fe3063bbe6c0e032ef5c695.png
https://pasteall.org/media/e/5/e52f340f23df37048e66281a5e253bc2.png
https://pasteall.org/media/a/1/a1a9fa71ef38c347087c0b92b7d506a3.png

Sun, Nov 14, 1:48 AM

Sat, Nov 13

Vulcan added a comment to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

Successful build - Chance fights ever on the side of the prudent.

Sat, Nov 13, 6:13 PM
Vulcan added a comment to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

Successful build - Chance fights ever on the side of the prudent.

Sat, Nov 13, 6:12 PM
JCWasmx86 updated the diff for D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].
Sat, Nov 13, 6:08 PM
Vulcan added a comment to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

Successful build - Chance fights ever on the side of the prudent.

Sat, Nov 13, 5:59 PM
JCWasmx86 added inline comments to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].
Sat, Nov 13, 5:57 PM
Vulcan added a comment to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

Successful build - Chance fights ever on the side of the prudent.

Sat, Nov 13, 5:57 PM
JCWasmx86 updated the diff for D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

Addressed nearly every code comment

Sat, Nov 13, 5:53 PM
nani added a comment to D4319: New game mode: capture the wonder.

@Freagarach do the new changes fix the issues?

Sat, Nov 13, 4:28 PM
Silier removed 1 auditor(s) for rP21121: Add a repair time tooltip: mimo.
Sat, Nov 13, 3:24 PM
Silier accepted D4305: Fix bug where scenario map was not loading as revealed when set to revealed..

@Freagarach can you also have a look if something is not overlooked just in case

Sat, Nov 13, 1:31 PM
Silier added a comment to D4330: Show the right message when exiting the game as a client.

Thank you for the patch

Sat, Nov 13, 1:27 PM
Silier committed rP25995: Show the correct message when exiting the multiplayer match as a client.
Show the correct message when exiting the multiplayer match as a client
Sat, Nov 13, 1:27 PM
Silier closed D4330: Show the right message when exiting the game as a client.
Sat, Nov 13, 1:27 PM
Silier removed reviewers for D2620: use non-breaking space in 0 A.D.: Silier, Restricted Owners Package.
Sat, Nov 13, 1:20 PM
Silier requested changes to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].
Sat, Nov 13, 12:10 PM
Silier added a comment to D4333: Split tasks from ProductionQueue..

some comments

Sat, Nov 13, 11:36 AM
JCWasmx86 added inline comments to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].
Sat, Nov 13, 11:33 AM
Silier added inline comments to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].
Sat, Nov 13, 10:48 AM
Vulcan added a comment to D4343: [PetraAI] - Use enum-like variables instead of magic values. [2/n].

Successful build - Chance fights ever on the side of the prudent.

Sat, Nov 13, 8:58 AM
Vulcan added a comment to D4343: [PetraAI] - Use enum-like variables instead of magic values. [2/n].

Successful build - Chance fights ever on the side of the prudent.

Sat, Nov 13, 8:56 AM
Vulcan added a comment to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

Successful build - Chance fights ever on the side of the prudent.

Sat, Nov 13, 8:53 AM
Vulcan added a comment to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

Successful build - Chance fights ever on the side of the prudent.

Sat, Nov 13, 8:51 AM
JCWasmx86 updated the diff for D4343: [PetraAI] - Use enum-like variables instead of magic values. [2/n].
Sat, Nov 13, 8:50 AM
JCWasmx86 updated the diff for D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].
Sat, Nov 13, 8:47 AM
Vulcan added a comment to D4333: Split tasks from ProductionQueue..

Successful build - Chance fights ever on the side of the prudent.

Sat, Nov 13, 7:47 AM
Vulcan added a comment to D4333: Split tasks from ProductionQueue..

Successful build - Chance fights ever on the side of the prudent.

Sat, Nov 13, 7:46 AM
Freagarach updated the summary of D4333: Split tasks from ProductionQueue..
Sat, Nov 13, 7:42 AM
Freagarach updated the diff for D4333: Split tasks from ProductionQueue..

Fix templates of trainer units.

Sat, Nov 13, 7:41 AM
Vulcan added a comment to D4333: Split tasks from ProductionQueue..

Successful build - Chance fights ever on the side of the prudent.

Sat, Nov 13, 7:36 AM
Freagarach edited P256 Fix D4333.
Sat, Nov 13, 7:28 AM
Vulcan added a comment to D4333: Split tasks from ProductionQueue..

Successful build - Chance fights ever on the side of the prudent.

Sat, Nov 13, 7:25 AM
Freagarach updated the diff for D4333: Split tasks from ProductionQueue..

Sort here.

Sat, Nov 13, 7:19 AM
Freagarach edited P256 Fix D4333.
Sat, Nov 13, 7:17 AM
JCWasmx86 added inline comments to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].
Sat, Nov 13, 7:04 AM
autobuild committed rP25994: [Windows] Automated build..
[Windows] Automated build.
Sat, Nov 13, 7:03 AM
Freagarach edited P256 Fix D4333.
Sat, Nov 13, 6:55 AM
Freagarach edited P256 Fix D4333.
Sat, Nov 13, 6:45 AM
Freagarach edited P256 Fix D4333.
Sat, Nov 13, 6:44 AM
Vulcan added a comment to D4347: Console close function (without hotkey) .

Successful build - Chance fights ever on the side of the prudent.

Sat, Nov 13, 5:47 AM
Vulcan added a comment to D4347: Console close function (without hotkey) .

Successful build - Chance fights ever on the side of the prudent.

Sat, Nov 13, 5:45 AM
nwtour updated the diff for D4347: Console close function (without hotkey) .

Short Alias: modmod -> engine

Sat, Nov 13, 5:38 AM

Fri, Nov 12

Silier requested changes to D4343: [PetraAI] - Use enum-like variables instead of magic values. [2/n].

please do not replace undefined

Fri, Nov 12, 9:31 PM
Silier requested changes to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].
Fri, Nov 12, 9:24 PM
vladislavbelov committed rP25993: Moves MiniMap texture rendering to a separate framebuffer to update it less….
Moves MiniMap texture rendering to a separate framebuffer to update it less…
Fri, Nov 12, 8:16 PM
vladislavbelov closed D4331: Move MiniMap texture to a separate framebuffer.
Fri, Nov 12, 8:16 PM
nwtour added inline comments to D4347: Console close function (without hotkey) .
Fri, Nov 12, 7:22 PM
vladislavbelov added inline comments to D4347: Console close function (without hotkey) .
Fri, Nov 12, 6:39 PM
nwtour requested review of D4347: Console close function (without hotkey) .
Fri, Nov 12, 6:34 PM
vladislavbelov requested review of D4346: Adds more alpha and custom options to render debug mods..
Fri, Nov 12, 6:00 PM
Langbart raised a concern with rP25353: Generalize icon-specific tooltips to a tag, streamline code..

A small visual change was noted, see #6380.

Fri, Nov 12, 4:27 PM
Langbart raised a concern with rP25876: [PetraAI] - Manage bases in a separate BasesManager..

A strong change in behavior could be observed with this set of changes - see #6381.

Fri, Nov 12, 3:18 PM
vladislavbelov committed rP25992: Adds render debug modes..
Adds render debug modes.
Fri, Nov 12, 12:22 PM
vladislavbelov closed D4311: Adds render debug modes.
Fri, Nov 12, 12:22 PM
vladislavbelov added inline comments to D4331: Move MiniMap texture to a separate framebuffer.
Fri, Nov 12, 10:42 AM
Stan added inline comments to D4331: Move MiniMap texture to a separate framebuffer.
Fri, Nov 12, 9:27 AM
autobuild committed rP25991: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Fri, Nov 12, 9:14 AM
Vulcan added a comment to D4333: Split tasks from ProductionQueue..

Successful build - Chance fights ever on the side of the prudent.

Fri, Nov 12, 8:52 AM
Vulcan added a comment to D4333: Split tasks from ProductionQueue..

Successful build - Chance fights ever on the side of the prudent.

Fri, Nov 12, 8:51 AM
Freagarach updated the summary of D4333: Split tasks from ProductionQueue..
Fri, Nov 12, 8:48 AM
Freagarach updated the diff for D4333: Split tasks from ProductionQueue..

Reduce number of unneeded changes.

Fri, Nov 12, 8:47 AM
Freagarach edited P256 Fix D4333.
Fri, Nov 12, 8:43 AM
Vulcan added a comment to D4333: Split tasks from ProductionQueue..

Successful build - Chance fights ever on the side of the prudent.

Fri, Nov 12, 8:26 AM
Vulcan added a comment to D4333: Split tasks from ProductionQueue..

Successful build - Chance fights ever on the side of the prudent.

Fri, Nov 12, 8:23 AM
Vulcan added a comment to D4333: Split tasks from ProductionQueue..

Successful build - Chance fights ever on the side of the prudent.

Fri, Nov 12, 8:20 AM