if (!tech)
		{
			ret[i] = undefined;
			continue;
		}

Results in normal behaviour.

WARNING: ["phase_town_generic", (void 0), "unlock_shared_dropsites", "unlock_spies"]

Whilst:

		if (!tech)
			continue;

Results in:

WARNING: ["phase_town_generic", , "unlock_shared_dropsites", "unlock_spies"]
ERROR: Errors executing script event "SimulationUpdate"
ERROR: JavaScript error: gui/session/selection_panels.js line 681
data.item is undefined
  setupButton@gui/session/selection_panels.js:681:7
  setupUnitPanel@gui/session/unit_commands.js:94:35
  updateUnitCommands@gui/session/unit_commands.js:152:18
  updateSelectionDetails@gui/session/selection_details.js:536:20
  updateGUIObjects@gui/session/session.js:727:2
  onSimulationUpdate@gui/session/session.js:677:2
  __eventhandler54 (SimulationUpdate)@session SimulationUpdate:1:1

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

isGarrisoned is also used for turreted entities.

In this example (mainland, medium), the 3 players are on the same team, but do you think they are too close together? If so, any suggestions or pseudo-code ideas on how to alter the algorithm on how to prevent that?

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Fix placement of players when they are not assigned teams

The C++ part looks ok to me.

This patch fixes the problem I described in the referenced ticket.

D4350

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

In rP25993#54386, @Langbart wrote:

Minimap stretched lines - #6382.

That is sus (playcode)

const ret = [];

In D4346#185111, @Langbart wrote:

However, one problem is when you change the dropdown to a value and then quit the game (not the entire 0ad game, just the current game you are in) and start a new game. The overlay is still visible.
I tested it with the toggle box Obstruction Overlay and the Render Debug Mode AO. The first one turns off, the second one does not. This works since D4311 was committed, maybe it can be fixed with this changeset, otherwise I will create a ticket.

Debug overlays are mostly for objects not for UI or overlays. But maybe it might be improved.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

@Silier's comments.

If I have all three enabled, and disabled the allied view, it also disables the revealed map. Do note that allied view is also the ability to browse eachothers summary, so isn't tied only to the view state.

Minimap stretched lines - #6382.

However, one problem is when you change the dropdown to a value and then quit the game (not the entire 0ad game, just the current game you are in) and start a new game. The overlay is still visible.
I tested it with the toggle box Obstruction Overlay and the Render Debug Mode AO. The first one turns off, the second one does not. This works since D4311 was committed, maybe it can be fixed with this changeset, otherwise I will create a ticket.

Apply the patch and compile the game

Ok.

Make sure the game looks and runs the same for GLSL on/off

Yes, tested on the scenario map - third_macedonian_war.
GLSL off (default settings)
https://pasteall.org/media/4/1/41c41cb88fe3063bbe6c0e032ef5c695.png
https://pasteall.org/media/e/5/e52f340f23df37048e66281a5e253bc2.png
https://pasteall.org/media/a/1/a1a9fa71ef38c347087c0b92b7d506a3.png

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Addressed nearly every code comment. (Doesn't work at the moment)

@Freagarach do the new changes fix the issues?

@Freagarach can you also have a look if something is not overlooked just in case

Thank you for the patch

some comments

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Fix templates of trainer units.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Sort here.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Short Alias: modmod -> engine

please do not replace undefined

A small visual change was noted, see #6380.

A strong change in behavior could be observed with this set of changes - see #6381.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Reduce number of unneeded changes.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.