Comments are possible although I'm not sure whether it works with tokens, though.
I'm not a fan of XML comments, espcecially when it requires more maintenance but up to the person committing this ;)

From IRC.

14:17 < phosit> Stan: why the "?"
14:22 <@Stan> Cause I didn't really understand your last message ^^
[...]
14:38 < phosit> Stan: is replacing lib/rand.h out of scope for that patch?
14:55 <@Stan> phosit: Maybe but does an intermediate step make sense and if so what would it be ?

That sounds... good?

It would seem I need to call

Refs: D4573 by @phosit
I think the issue is that ActorViewer::ActorViewer() creates a new Terrain without making the minimap dirty.

Somewhere in lib we have some stuff about random used by the soundmanager there IIRC.

Can you make this a helper function or something to remove the duplication ?

Might want to check observer / coop mode :)
What happens when it turns to gaia?

Could there be any mirage shenanigans?
Does serialization work?

Aiend said elite cavalry should be archer cavalry.
Elite crossbowmen doesn't make sense because they are supposed to be trash units.

Yeah back to 60 but I suppose but keep it to 50 for the hans as to not alter their stats ? No strong feeling.

Per @vladislavbelov

Doesn’t sound good.
I have an idea, but I can’t write it atm.
The update should happen in atlas code on the terrain change.

Does it fix #6560?
Might also fix https://code.wildfiregames.com/rP26469 while at it?

Hey @dark_moughty send me an email at dolcini dot stan at live dot fr. I'll get you in touch.

cc @Dunedan @user1 is this still valid?

I think it's fixed now that you no longer need the proxy for the AI?

Also mind the warnings in the linux ci output :)

Did you forget the test file?

More auras less performance by the way.

Have you seen https://trac.wildfiregames.com/ticket/3362 ? It also talks about memory pools :)
Also worth mentioning it could maybe used for the Pathfinder https://trac.wildfiregames.com/ticket/3588#comment:4

@Freagarach I think this is superseeded by your patch.

@Freagarach

https://godbolt.org/z/v8jEfMx9W

Fair enough. Did you test multiplayer? Rejoining a match ? This shouldn't affect the simulation but it would be bad if it broke serialization or something.

Yes. I'd like people to accept it. It's a “big” change.

Fix @Langbart's notes, mark autoresearched techs as root, and reference paired techs. add deps for identity techs.

Thanks for testing. Wonder why it does not find the others I will investigate.

Seems there is no more leak anymore. :)
Did you test on combat demo huge ?
Is it thread safe? Should it be?

Feel free to make some improvements as well. :)

Profiler2 also allows you to load jsonp files from other runs to do the comparison :)

Hey @borg-
Thanks for the patch.

Does it make that code slower?

Can you fix all the while( to while ( and for( to for (?

Can we mitigate this? Now that we have a new RB we gained more time to fix things better.

Thanks for the patch.

LGTM, I was afraid it would mean a too small shadowmap (and thus low quality) on high end settings, but if @vladislavbelov says it's okay then it's fine by me.

Refs D4610 rP26815

I'm a bit torn between ugly buttons and overlapping text ^^ At least people are used to overlapping text?

AIEND seems not to support the removal of units, though.

Might wanna test units demo

We were talking about https://m.youtube.com/watch?v=qH6sSOr-yk8&feature=youtu.be might be of some interest to you too

I think you introduced a memory leak on Windows. This shows up in the test output failing them.

Can you show some screenshots and fix the lint warnings? :)

Might ask @AIEND specifically.

Fine by me.

@borg- feel free to accept if you like it. The sooner the balancing patches get merged the sooner RC2 comes and maybe becomes A26.

@real_tabasco_sauce No, it's not wrong to accept, in fact, we are more inclined to committing patches that have been formally accepted, since it's hard to get a consensus, it can give us a sense of majority.

Thanks for the update. No need to add the po files an automatic script takes cares of them :)

Well we agree. We were talking about it with Vladislav. The issue is that as of right now we don't have a way to restrict options per platform (e.g. the option menu doesn't know about the hardware and there is currently no coded way to make it aware of it) this is something we hope to have for A27