Thanks! I'll try to commit this during the week, we have some bank holidays...

The lexical scope of how test_vector.js is executed might need to change, I'm not sure. It's possible that it is already fine though. I can take a closer look later.

Can one of you submit a patch, so @Teiresias can finish his patch eventually? :D

Build failure - The Moirai have given mortals hearts that can endure.

In D2649#115710, @Itms wrote:

[…] Currently if devs forget to bump the value of LIB_VERSION for SpiderMonkey, it won't build, because it won't find the archive.

Hoist bundled lib versions to top of file. Add version suffix for nvtt as well.

Note to self: According to Vladislav a texture should be used to draw circles. Scaling should be done with "adding tex coords and so on". Entry point for understanding how that works could be OverlayRenderer::RenderForegroundOverlays.

I agree for the most part. I've always hated the "Persian Hall" as a buildable structure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Sort <Identity> nodes as specified in simulation/components/Identity.js.

Build failure - The Moirai have given mortals hearts that can endure.

Successful build - Chance fights ever on the side of the prudent.

In D665#115525, @wraitii wrote:

Some comments:

• I think you can use global regions to skip the ReachableRegions logic entirely, which should be faster.

You're right. I have changed the patch to do that. When I first wrote the patch, GetGlobalRegion didn't exist.

Use GetGlobalRegion

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

And one final idea: maybe the nvtt version should have a wildfiregames suffix so that it gets rebuilt when we add some patches, like I will do in D2563.

Successful build - Chance fights ever on the side of the prudent.

peacock, crocodile

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Include suggested changes

I am requesting changes over https://code.wildfiregames.com/D1398#inline-53440 which needs to be fixed before committing. This is otherwise in a commit-worthy state to me.

Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

What about fixing it instead?

That's probably a lot more work and not worth the effort. And even if that's done, the magical flying ram doesn't really belong in those map files.

What about fixing it instead?

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

@wraitii it is related to this https://wildfiregames.com/forum/index.php?/topic/28059-svn-public-alpha-24-version-on-macos-ui-problem/&tab=comments#comment-395402

Additionally I had this idea: P203

I've tested this and it works correctly.
@Krinkle Do you still experience the graphical issue you reported? I don't notice this.

Successful build - Chance fights ever on the side of the prudent.

Hi Krinkle, very nice patch! It will help the CI considerably.

Clean template a bit more

ricotz asked today on IRC if we could make the va_list fix specific to the platforms it's broken on aka arm aarch64

#if NV_CPU_ARM || NV_CPU_AARCH64 || NV_OS_DARWIN || NV_OS_IOS
       for (uint i = 0; i < lines.count(); i++) {
            va_list empty_va_list = {};
            messageHandler->log(lines[i], empty_va_list);
            delete lines[i];
        }
#else
       for (uint i = 0; i < lines.count(); i++) {
            messageHandler->log(lines[i], NULL);
            delete lines[i];
        }
#endif

Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

Fix code, use status effects name everywhere.

Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

Fix review comments.

In D2735#115555, @bb wrote:

This patch is correct by default if the design is that order.foo sets a state depending on the given order and state.enter checks if the state is possible and if it fails we simply go to the next order.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.