Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Annoying that you have to compile to do C++ :P Remove useless comment and fix build

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Successful build - Chance fights ever on the side of the prudent.

Remove the remaining auto

Successful build - Chance fights ever on the side of the prudent.

Fix missing headers

Make it more moddable

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Fix missing S, will commit this soon unless someone objects

Should be done in D2849

Compiles, runs.
Tried:

• Local MP with PetraAI. (Rejoining.)
• Tests.
• Loading a map in Atlas.

I believe that's a bug present in vanilla?

SM Builds for me. Lubuntu 18.04.

In D2453#111230, @Stan wrote:

Plane still land when targetting building.

?

@Freagarach, @Angen?

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Fix tests[C

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Could be done in source/lib/posix/posix_mman.h maybe. Would save some conditionnals.

Build failure - The Moirai have given mortals hearts that can endure.

Update to HEAD

I fail to notice a difference, but then again, I don't have musical ears.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build is unstable, some tests have failed - The Moirai have given mortals hearts that can endure.

Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

Always write messages to files, except when the logger is set to disabled

Build failure - The Moirai have given mortals hearts that can endure.

Use enum instead, fix default value, do it after config has been inited instead, use enum class

Successful build - Chance fights ever on the side of the prudent.

@Freagarach, @Angen could you test this and tell me if it feels better for you too? Basically notice the sound is better attenuated when zooming out.

Remove the new construct as @vladislavbelov pointed out it breaks our auto convention. Fix HDATA warning, + Path warnings

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

As I said earlier, it's a nice change, but I would still like to see mercenaries costing just a good amount of food and metal, like 7/3.

In D3162#140182, @Stan wrote:

No I mean the part used by the hardware detection :) that was in your patches before.

No I mean the part used by the hardware detection :) that was in your patches before.

In D3162#140177, @Stan wrote:

There is no CPU detection anymore. Did you forget a file?

Do you mean this part in source/renderer/ModelRenderer.cpp?

#if ARCH_X86_X64
# include "lib/sysdep/arch/x86_x64/x86_x64.h"
#endif

I thought it was only necessary for this if (x86_x64::Cap(x86_x64::CAP_SSE))

I agree it is cleaner and changing values is now easier.

There is no CPU detection anymore. Did you forget a file?

In D3162#140024, @Stan wrote:

If you want to remove the duplication, you should put it in lib.h instead.

Fix redirection

Fix typo

Build was aborted.

Build was aborted.

Maybe account for <cstring>

Build was aborted.

More fixes (this one was weird)

Build was aborted.

Build was aborted.

Fix more no-pch

Fix command

Make it less dependent on OS

That's not how alignment works. And it's not the GCC 7.5 bug (maybe they have bug, but it doesn't matter) but we have UB with alignment.

template_unit_champion_cavalry_melee.xml
template_unit_champion_cavalry_ranged.xml
template_unit_hero_cavalry_melee.xml
template_unit_hero_cavalry_ranged.xml

don't exist either.

You shouldn't add *.rej files.

Fix range visualisation.

Only for auras or also the healer and attack range visualizations? Could you also take elevation bonus into account for the latter?

In D2946#140117, @Angen wrote:

Note: jenkins is failing with loading result of debug tests, not sure what changed in config

not really, i like the hierarchy

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Fix Iber monument & Fix range visualisation.

Note: jenkins is failing with loading result of debug tests, not sure what changed in config