• don't add it to cart, kush, pers, per @borg-

Gauls also have an extra farming technology (D2668/rP23803) and there is a proposal to give them a carnyx aura unit (D3320), so yes, Gauls seem to have an advantage over the Britons, so maybe the celt_structures bonus should be limited to brit only. However, that discussion belongs in D2841; doing one bonus at a time makes patches simpler, so let's concentrate here on the proposed cavalry bonus.

Not necessary following rP24563

Build is green

Build is green

Bug fix required for D2830 to work.

Build is green

• Nice change, not adding all resources is better for modders (don't need to purge resources that they remove) and us (if we decide to add another resource we don't need to update all techs to be consistent).
• Complete.
• Checkrefs passes.

• insert “idle” in health_regen_units.json tooltip, spotted by @Freagarach

Hi, after I realized that the look of this version of the map might not be as bad as I thought back then, I decided to rebase it to open it once again for feedback.
When evaluating the look of the map I recommend to sometimes generate it with the fog of war, as seeing it from a players perspective can be different from having all revealed.

Also revert rP24466 since that is no longer necessary.

Build is green

This patch is heavily outdated, most of these string changes have been committed as part of D2821/rP23837, D2892/rP23865, and elsewhere

@user1 says it's a release blocker, and that he will review it.

Build is green

Yeah as discussed on IRC, this is working as designed, though it looks a bit odd. The # of column is static.
I've created #5910, I don't think it warrants more at the moment?

I think we're hitting a VS17 bug and I'm not sure which.
Trying a different hash.

Apparently it's a "feature" (the problem comes when you switch between fullscreen and windowed) If you load the gamesetup in fullscreen it works. See the images i posted above.

Build is green

Nah, it is not needed when you have a patch, but thanks anyway :)

Build is green

I think there is something wrong in fullscreen.
I'd expect to see 9 or 12 maps in fullscreen and not only two:

xp

Build is green

Build is green

Build has FAILED

My concern was fixed by rP24517.

Fix the tests.

Thanks! I was just checking how to do this scripted ;)

Here's a script for indenting json files:

Much of the training was against immobile targets, so against a moving target it's still an experience.

Thanks! I was just checking how to do this scripted ;)

They're weak, so I wouldn't make it too high. I don't really see how killing civilians would make you a better soldier. How about 10%?

they are not, what is the prefered health xp ratio ?

While breastplates, scale armour, and chain mail existed and were used, leather, linen, wool, and cotton were very common materials for body armour.

How about the armour (hack resistance) technologies costing food and metal, and the shield (pierce resistance) technologies costing wood and metal?

Build has FAILED

I would keep the xp,

For me no problem If u want keep xp.

Fine by me, if the value is proportional to their health. I'll leave it up to you to choose a suitable percentage.

Build has FAILED

Build has FAILED

Update using GCHashTable following mozilla dev's comments (asked them questions on Matrix today).

ok, so if @Stan agrees on icons, he can commit them beforehand :)

Better now. For me no problem If u want keep xp.

Build is green

exclude ships and do it separately,
I would keep the xp, although most of them cant fight back, they do move and particulary ranged units should get better when shooting at moving target or any target

@Nescio is exchanging bronze armor for leather and putting food and wood cost realistic?

Build is green

Then just check next week whether they're still there, and if so, manually retranslate them on transifex.

nah, there is odd featurre on transifex which will keep translation if string is "the same", it happened with "Learn To Play" -> "Learn to Play" so can happen here too.

Add tests that validate that this doesn't crash.

translations will take care of themselves :) probably they did copy paste, maybe transifex will screw it with auto translation, but we can just add comment there, maybe @Gallaecio could force clear these after this is commited but there is still chance they will reuse old translations?

If strings are changed they are automatically prompted for retranslation, so committing this patch (without the builder entities line, of course) most likely means those characters will be gone too (in a few days).

Build is green

• UnitDemo loads fine.
• Change is nice.

My concern was fixed :)

Rename a few, per @Freagarach:

• metropolis.json → hellenistic_metropolis.json
• unlock_reformed_army.json → reformed_army_sele.json
• unlock_traditional_army.json → traditional_army_sele.json

Build is green